After a lengthy debugging session it turns out this is the change that breaks
core file loading on FreeBSD. The core file has no sections (the core data
and thread / register notes are in program segments), so
ParseSectionHeaders() returns 0.
Oh dang. I originally had a comment on that in
Author: tfiala
Date: Thu Jun 26 17:35:36 2014
New Revision: 211812
URL: http://llvm.org/viewvc/llvm-project?rev=211812view=rev
Log:
Fix an incomplete null structure spec in Python readline suppression module.
Now that I'm building Linux with clang, I'm seeing more clang warnings.
This fills in
Hey Ed,
This patch fixes the ParseHeaders() with a zero return value so that it does
not fail out the GetArchitecture() call.
Let me know if that gets you further.
We'll still need to figure out how to adjust the code to not require a FreeBSD
version number (or adjust how the version number
Okay cool, thanks!
On Thu, Jun 26, 2014 at 3:39 PM, Greg Clayton gclay...@apple.com wrote:
On Jun 26, 2014, at 3:03 PM, Todd Fiala tfi...@google.com wrote:
Hey Greg,
On Thu, Jun 26, 2014 at 2:52 PM, Greg Clayton gclay...@apple.com
wrote:
A few things with respect to triple
Hi emaste,
This change modifies how ObjectFileELF determines the architecture of an ELF
file. It no longer assumes the elf file's vendor and OS is the same as the
current host. It is one step in supporting running lldb across
MacOSX/Linux/FreeBSD/NetBSD.
The current ELF note parsing added
Hang on - just caught a couple member variables that are not in the initializer
list. Will add a new diff in a few minutes with all members properly in the
initializer list.
http://reviews.llvm.org/D4302
___
lldb-commits mailing list
Author: tfiala
Date: Tue Jun 24 16:38:31 2014
New Revision: 211635
URL: http://llvm.org/viewvc/llvm-project?rev=211635view=rev
Log:
Fix up Windows build for the SBUnixSignals addition.
Change by Zachary Turner.
Modified:
lldb/trunk/source/API/CMakeLists.txt
Missed this one earlier this month. I'll have a look at this now.
http://reviews.llvm.org/D4091
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: tfiala
Date: Mon Jun 23 10:59:04 2014
New Revision: 211503
URL: http://llvm.org/viewvc/llvm-project?rev=211503view=rev
Log:
lldb: deal with non-portable PTRACE-related constants
See http://reviews.llvm.org/D4091 for details.
Change by Paul Osmialowski.
Modified:
, stop or
forward using the Python and C++ APIs.
Change by Russell Harmon.
Xcode build system changes (and any mistakes) by Todd Fiala. Tested on MacOSX
10.9.3 and Xcode 6 beta. (Xcode 5 is hitting the dependency checker crasher on
all my systems).
Added:
lldb/trunk/include/lldb/API
Author: tfiala
Date: Mon Jun 23 15:56:48 2014
New Revision: 211535
URL: http://llvm.org/viewvc/llvm-project?rev=211535view=rev
Log:
Part 2 of SBUnitSignals check-in.
I missed adding a few new files to the change list.
The build is broken from r211526 without this fix.
(And Ed Maste caught it
for all the ptrace values we use.
On Mon, Jun 23, 2014 at 1:48 PM, Paul Osmialowski paw...@king.net.pl
wrote:
On Mon, 23 Jun 2014, Todd Fiala wrote:
Hi Paul,
I guess we're not going to require access to kernel headers for lldb
cross-compilation, so your fix should be a better solution.
Yeah
Author: tfiala
Date: Fri Jun 20 12:39:24 2014
New Revision: 211381
URL: http://llvm.org/viewvc/llvm-project?rev=211381view=rev
Log:
Added gdb-remote tests for Q{Save,Restore}RegisterState.
Tests for both thread suffix and no thread suffix execution.
Moved some bit-flipping helper methods from
Author: tfiala
Date: Fri Jun 20 19:48:09 2014
New Revision: 211425
URL: http://llvm.org/viewvc/llvm-project?rev=211425view=rev
Log:
Fix a gdbremote bug in _M/_m stub support detection.
When a stub reported $#00 (unsupported) for _M and _m
packets, the unsupported response was not handled and
the
Author: tfiala
Date: Thu Jun 19 12:35:40 2014
New Revision: 211283
URL: http://llvm.org/viewvc/llvm-project?rev=211283view=rev
Log:
Fixed up gdb-remote auxv regex issues with binary data.
Fixes two causes for https://github.com/tfiala/lldb/issues/7.
1. Ensures the inferior program has started
Author: tfiala
Date: Tue Jun 17 11:04:45 2014
New Revision: 211105
URL: http://llvm.org/viewvc/llvm-project?rev=211105view=rev
Log:
Added gdb-remote auxv tests.
First batch of auxv-related tests from llgs branch.
Includes helpers for unescaping gdb-remote binary-escaped
data, converting binary
testing.
On Tue, Jun 17, 2014 at 12:25 PM, Todd Fiala tfi...@google.com wrote:
Ok - so given it's a linker related flags issue, what is the correct cmake
way to test out the linker being used?
On Tue, Jun 17, 2014 at 11:49 AM, Ed Maste ema...@freebsd.org wrote:
On 17 June 2014 14:33, Todd
Darwin)
On Tue, Jun 17, 2014 at 1:02 PM, Todd Fiala tfi...@google.com wrote:
This latest patch works on Ubuntu12.04/gcc4.8.2 and MacOSX10.9.3/clang.
But thinking more about it, the predicate as a whole (changing based on
compiler rather than Linker) is just incorrect. So the platform
I've now tested that final cmake patch on Ubuntu Linux 12.04/gcc-4.8.2,
MacOSX 10.9.3/clang, FreeBSD 10/clang and they all pass.
I'll go check it in. Ping me with your failure case if you end up with one
after the change.
On Tue, Jun 17, 2014 at 1:14 PM, Todd Fiala tfi...@google.com wrote
Author: tfiala
Date: Tue Jun 17 15:54:56 2014
New Revision: 211123
URL: http://llvm.org/viewvc/llvm-project?rev=211123view=rev
Log:
Fix up lldb cmake linker flags for MacOSX.
Change r210035 broke the Darwin cmake build. The
initial change was intended to stop the --start-group/--end-group
Author: tfiala
Date: Tue Jun 17 17:01:27 2014
New Revision: 211127
URL: http://llvm.org/viewvc/llvm-project?rev=211127view=rev
Log:
Added gdb-remote auxv test for chunked reads.
Verifies that a sum of offset,length auxv reads
matches a single large read, and that the auxv data
extracted from
Author: tfiala
Date: Mon Jun 16 09:49:28 2014
New Revision: 211026
URL: http://llvm.org/viewvc/llvm-project?rev=211026view=rev
Log:
Move x86-specific struct user code for Linux ProcessMonitor behind #define
guards.
See http://reviews.llvm.org/D4092 for details.
Change by Paul Osmialowski.
Author: tfiala
Date: Sun Jun 15 18:33:09 2014
New Revision: 211006
URL: http://llvm.org/viewvc/llvm-project?rev=211006view=rev
Log:
Minor gdb-remote test QListThreadsInStopReply changes from llgs branch.
Modified:
lldb/trunk/test/tools/lldb-gdbserver/TestGdbRemoteThreadsInStopReply.py
Author: tfiala
Date: Sat Jun 14 17:00:36 2014
New Revision: 210982
URL: http://llvm.org/viewvc/llvm-project?rev=210982view=rev
Log:
Added several gdb-remote tests around QListThreadsInStopReply.
Added:
lldb/trunk/test/tools/lldb-gdbserver/TestGdbRemoteThreadsInStopReply.py
Modified:
Author: tfiala
Date: Fri Jun 13 18:34:17 2014
New Revision: 210957
URL: http://llvm.org/viewvc/llvm-project?rev=210957view=rev
Log:
Sync accumulated minor diffs in llgs branch gdb-remote tests.
I've been making some subtle changes to the gdb-remote tests as I implement
them in the llgs branch.
Author: tfiala
Date: Fri Jun 13 22:03:23 2014
New Revision: 210963
URL: http://llvm.org/viewvc/llvm-project?rev=210963view=rev
Log:
Added gdb-remote expedited register dupe check.
The llgs branch had a bug where register sets were not terminated with
LLDB_INVALID_REGNUM so the expedite register
Author: tfiala
Date: Fri Jun 13 22:13:01 2014
New Revision: 210964
URL: http://llvm.org/viewvc/llvm-project?rev=210964view=rev
Log:
Properly terminated POSIX register sets with LLDB_INVALID_REGNUM.
RegisterSets are assumed to be terminated by this value. Loops over
register set values would
Author: tfiala
Date: Thu Jun 12 15:38:56 2014
New Revision: 210818
URL: http://llvm.org/viewvc/llvm-project?rev=210818view=rev
Log:
Added gdb-remote P/p thread suffix test.
Improved the P writes all GPR register values test. It now
limits itself to GPR registers that are not containers for
Author: tfiala
Date: Wed Jun 11 13:09:01 2014
New Revision: 210681
URL: http://llvm.org/viewvc/llvm-project?rev=210681view=rev
Log:
Add gdb-remote P register write test.
Added test that attempts to write a value to each general
purpose register that is bit-flipped from the initial read
value.
Author: tfiala
Date: Tue Jun 10 15:16:31 2014
New Revision: 210573
URL: http://llvm.org/viewvc/llvm-project?rev=210573view=rev
Log:
Added gdb-remote tests around $qSupported.
Right now it just checks that qSupported returns at least
one recognized gdb stub feature.
Modified:
Author: tfiala
Date: Tue Jun 10 17:15:56 2014
New Revision: 210594
URL: http://llvm.org/viewvc/llvm-project?rev=210594view=rev
Log:
Added gdb-remote test to verify M memory write.
Modified:
lldb/trunk/test/tools/lldb-gdbserver/TestLldbGdbServer.py
Author: tfiala
Date: Mon Jun 9 12:46:37 2014
New Revision: 210481
URL: http://llvm.org/viewvc/llvm-project?rev=210481view=rev
Log:
Added gdb-remote test for s packet, single stepping.
Modified:
lldb/trunk/test/tools/lldb-gdbserver/TestLldbGdbServer.py
Author: tfiala
Date: Fri Jun 6 16:59:19 2014
New Revision: 210376
URL: http://llvm.org/viewvc/llvm-project?rev=210376view=rev
Log:
Remove invalid comment from last commit.
Modified:
lldb/trunk/test/tools/lldb-gdbserver/TestLldbGdbServer.py
Modified:
Author: tfiala
Date: Thu Jun 5 11:34:13 2014
New Revision: 210272
URL: http://llvm.org/viewvc/llvm-project?rev=210272view=rev
Log:
Added gdb-remote test for software breakpoints.
Tests $Z0 and $z0. Extends test exe get-code-address-hex:
to take a function name.
Enabled for debugserver,
Author: tfiala
Date: Wed Jun 4 11:42:12 2014
New Revision: 210196
URL: http://llvm.org/viewvc/llvm-project?rev=210196view=rev
Log:
Added gdb-remote $qMemoryRegionInfo tests for heap and stack.
Added two new tests: one to verify that a test exe heap address
returned is readable and writeable,
Author: tfiala
Date: Wed Jun 4 15:13:37 2014
New Revision: 210213
URL: http://llvm.org/viewvc/llvm-project?rev=210213view=rev
Log:
Move MemoryRegionInfo out of Target/Process.h into its own header.
lldb-gdbserver and NativeProcessProtocol will use MemoryRegionInfo
but don't want to pull in
Author: tfiala
Date: Tue Jun 3 13:09:56 2014
New Revision: 210116
URL: http://llvm.org/viewvc/llvm-project?rev=210116view=rev
Log:
Added gdb-remote memory read ($m) test.
Added set-memory:{content} and get-memory-address-hex: commands
to the test exe for gdb-remote. Added a test that sets the
Author: tfiala
Date: Wed Jun 4 00:07:40 2014
New Revision: 210163
URL: http://llvm.org/viewvc/llvm-project?rev=210163view=rev
Log:
Fix a couple minor typos in $qMemoryRegionInfo packet docs.
Modified:
lldb/trunk/docs/lldb-gdb-remote.txt
Modified: lldb/trunk/docs/lldb-gdb-remote.txt
URL:
Author: tfiala
Date: Mon Jun 2 12:30:22 2014
New Revision: 210035
URL: http://llvm.org/viewvc/llvm-project?rev=210035view=rev
Log:
Fix most of the remaining Windows build warnings.
See http://reviews.llvm.org/D3944 for more details.
Change by Zachary Turner.
Modified:
Author: tfiala
Date: Mon Jun 2 12:49:35 2014
New Revision: 210036
URL: http://llvm.org/viewvc/llvm-project?rev=210036view=rev
Log:
Add executable extension to debugger name, run dotest via binary.
See http://reviews.llvm.org/D3904 for details.
Change by Scott Graham.
Modified:
Author: tfiala
Date: Mon Jun 2 15:55:29 2014
New Revision: 210046
URL: http://llvm.org/viewvc/llvm-project?rev=210046view=rev
Log:
Add support for inspecting enum members.
Change by Russell Harmon.
Xcode project updates (and all errors therein)
by Todd Fiala.
Added:
lldb/trunk/include
Author: tfiala
Date: Fri May 30 12:59:47 2014
New Revision: 209912
URL: http://llvm.org/viewvc/llvm-project?rev=209912view=rev
Log:
gdb-remote signal delivery test cleanup.
Learned that MacOSX only accepts signal delivery on a thread that is
already signal handling. Reworked the test exe to
Author: tfiala
Date: Thu May 29 15:44:45 2014
New Revision: 209845
URL: http://llvm.org/viewvc/llvm-project?rev=209845view=rev
Log:
gdb-remote testing: new test, cleaned up socket reading.
Added new SocketPacketPump class to decouple gdb remote packet
reading from packet expectations code. This
Author: tfiala
Date: Wed May 28 12:06:04 2014
New Revision: 209752
URL: http://llvm.org/viewvc/llvm-project?rev=209752view=rev
Log:
Cmake build changes.
Disables exception handling in LLDB, using appropriate compiler
flags depending on the platform. This is consistent with the build
of LLVM,
Author: tfiala
Date: Wed May 28 12:58:29 2014
New Revision: 209756
URL: http://llvm.org/viewvc/llvm-project?rev=209756view=rev
Log:
Disabled warning C4251 on MSVC builds.
See http://reviews.llvm.org/D3934 for more details.
This is only the CMakeLists.txt portion of that change.
Change by
Author: tfiala
Date: Fri May 23 17:25:29 2014
New Revision: 209560
URL: http://llvm.org/viewvc/llvm-project?rev=209560view=rev
Log:
Added gdb remote tests to verify $Hg{thread-id}.
Added test to check that each thread reported by $q{f,s}ThreadInfo
can be switched to by $Hg, verified by a
Author: tfiala
Date: Fri May 23 17:33:42 2014
New Revision: 209561
URL: http://llvm.org/viewvc/llvm-project?rev=209561view=rev
Log:
Remove some unnecessary comments from previous check-in.
Removed a done TODO comment.
Moved some helper methods to the top of the unit test.
Removed some
Author: tfiala
Date: Thu May 22 12:18:18 2014
New Revision: 209452
URL: http://llvm.org/viewvc/llvm-project?rev=209452view=rev
Log:
Added gdbremote protocol test for $p and returned data size.
Each register returned by $qRegisterInfo is tested that it's
$p register read returns a representation
Author: tfiala
Date: Wed May 21 13:12:14 2014
New Revision: 209314
URL: http://llvm.org/viewvc/llvm-project?rev=209314view=rev
Log:
Added gdb-remote tests for q{f,s}ThreadInfo.
The First test verifies that qThreadInfo queries work for stub-launched
processes.
The second test verifies that $qC
Author: tfiala
Date: Wed May 21 15:12:01 2014
New Revision: 209318
URL: http://llvm.org/viewvc/llvm-project?rev=209318view=rev
Log:
Added tests for q{f,s}ThreadInfo for attached processes.
Added helper methods:
prep_debug_monitor_and_inferior(): properly handles
the two cases of running the stub
Author: tfiala
Date: Tue May 20 15:02:08 2014
New Revision: 209234
URL: http://llvm.org/viewvc/llvm-project?rev=209234view=rev
Log:
Change gdb remote test support multi-request format.
The multi request-response test infrastructure support was adding
the optional request suffix iteration index
Author: tfiala
Date: Mon May 19 01:11:41 2014
New Revision: 209109
URL: http://llvm.org/viewvc/llvm-project?rev=209109view=rev
Log:
Added gdb remote test for one valid qRegisterInfo result.
Checks that at at least qRegisterInfo0 responds with a valid
register info reply packet. The packet is
Author: tfiala
Date: Mon May 19 11:58:52 2014
New Revision: 209142
URL: http://llvm.org/viewvc/llvm-project?rev=209142view=rev
Log:
Update Xcode settings for Xcode 5.1 (5B130a) to remove workspace warning.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
, Todd Fiala todd.fi...@gmail.com wrote:
Author: tfiala
Date: Mon May 19 01:11:41 2014
New Revision: 209109
URL: http://llvm.org/viewvc/llvm-project?rev=209109view=rev
Log:
Added gdb remote test for one valid qRegisterInfo result.
Checks that at at least qRegisterInfo0 responds
Author: tfiala
Date: Mon May 19 13:30:48 2014
New Revision: 209151
URL: http://llvm.org/viewvc/llvm-project?rev=209151view=rev
Log:
Revert r209142.
Need to spend a little more time with suppressing the debugserver 64-to-32 bit
warnings.
Will re-submit after I get the warnings properly
Author: tfiala
Date: Mon May 19 17:35:24 2014
New Revision: 209170
URL: http://llvm.org/viewvc/llvm-project?rev=209170view=rev
Log:
Added gdb remote protocol tests across all qRegisterInfo responses.
Added support for gdb remote protocol capture/playback where there is a
query/multiple-response
/lldbgdbserverutils.py
Sendingtest/tools/lldb-gdbserver/main.cpp
Transmitting file data ...
Committed revision 209170
On Mon, May 19, 2014 at 1:45 PM, Todd Fiala tfi...@google.com wrote:
Yep, going to do that :-)
Almost done.
On Mon, May 19, 2014 at 1:29 PM, Greg Clayton gclay...@apple.com wrote
Author: tfiala
Date: Sun May 18 23:57:23 2014
New Revision: 209108
URL: http://llvm.org/viewvc/llvm-project?rev=209108view=rev
Log:
Add support for gdb remote $X stop notification.
debugserver now returns $X09 as the immediate response to
a $k kill process request rather than $W09.
209108.
On Thu, May 15, 2014 at 9:41 AM, Todd Fiala tfi...@google.com wrote:
Ah right yep. I'll address that too.
On Thu, May 15, 2014 at 9:31 AM, Greg Clayton gclay...@apple.com wrote:
Looks fine. Just be sure that all code that looks for 'W' also handles
'X'. I see some code
Author: tfiala
Date: Fri May 16 15:43:19 2014
New Revision: 209016
URL: http://llvm.org/viewvc/llvm-project?rev=209016view=rev
Log:
Refactored RegisterInfoInterface into its own header.
Also moved it into the lldb_private namespace.
The llgs branch is making use of this interface and its use is
Author: tfiala
Date: Wed May 14 09:51:27 2014
New Revision: 208782
URL: http://llvm.org/viewvc/llvm-project?rev=208782view=rev
Log:
Added debugserver/llgs test for command-line --attach {pid} variant.
Checks that the pid reported by $qProcessInfo matches the pid that was
launched as the attach
Author: tfiala
Date: Wed May 14 11:15:43 2014
New Revision: 208789
URL: http://llvm.org/viewvc/llvm-project?rev=208789view=rev
Log:
Replace SIZE_T_MAX with std::numeric_limits value in Section.cpp.
SIZE_T_MAX is not available on Linux.
Modified:
lldb/trunk/source/Core/Section.cpp
Modified:
Author: tfiala
Date: Wed May 14 14:34:06 2014
New Revision: 208804
URL: http://llvm.org/viewvc/llvm-project?rev=208804view=rev
Log:
Added gdbremote tests to verify kill and continue after attach.
Modified:
lldb/trunk/test/tools/lldb-gdbserver/TestLldbGdbServer.py
Hey guys,
Debugserver is responding to a $k kill process command with W09 rather than
X09 (i.e. indicating a normal exit with return code 9 rather than a
signal-based exit from signal 9). Any issue with me changing that? I've
tested it locally and it doesn't appear to cause any harm. lldb
Modify debugserver to follow gdb remote $qC protocol definition.
$qC from debugserver now returns the current thread's thread-id (and, like
$?, will set a current thread if one is not already selected). Previously
it was returning the current process id.
lldb will now query $qProcessInfo to
Great thanks. Will put it in now.
On Wed, May 7, 2014 at 11:34 AM, Greg Clayton gclay...@apple.com wrote:
Looks good!
On May 7, 2014, at 11:15 AM, Todd Fiala todd.fi...@gmail.com wrote:
Modify debugserver to follow gdb remote $qC protocol definition.
$qC from debugserver now returns
Author: tfiala
Date: Wed May 7 14:28:21 2014
New Revision: 208241
URL: http://llvm.org/viewvc/llvm-project?rev=208241view=rev
Log:
Modify debugserver to follow gdb remote $qC protocol definition.
$qC from debugserver now returns the current thread's thread-id (and, like $?,
will set a current
Author: tfiala
Date: Tue Apr 29 11:57:45 2014
New Revision: 207556
URL: http://llvm.org/viewvc/llvm-project?rev=207556view=rev
Log:
Make lldb-gdbserver configure/(g)make build parity with cmake.
This now builds lldb-gdbserver on all Linux and FreeBSD architectures
rather than being locked to
Author: tfiala
Date: Tue Apr 29 13:21:07 2014
New Revision: 207568
URL: http://llvm.org/viewvc/llvm-project?rev=207568view=rev
Log:
Added gdb remote protocol tests for no output and inferior non-zero exit code.
Tests added for debugserver and lldb-gdbserver. lldb-gdbserver marked as
XFAIL on
Author: tfiala
Date: Mon Apr 28 01:04:46 2014
New Revision: 207398
URL: http://llvm.org/viewvc/llvm-project?rev=207398view=rev
Log:
Fixed up lldb-gdbserver to match slightly different debugserver listener
host:port message.
Fixed up typo in lldb-gdbserver name missed when working on the OS X
Author: tfiala
Date: Tue Apr 29 00:01:01 2014
New Revision: 207492
URL: http://llvm.org/viewvc/llvm-project?rev=207492view=rev
Log:
Added debugserver/llgs protocol test for output and clean exit.
Tests for $vCont;c program start, $O output and $W status code.
@llgs_test variant currently marked
Author: tfiala
Date: Sun Apr 27 23:49:40 2014
New Revision: 207395
URL: http://llvm.org/viewvc/llvm-project?rev=207395view=rev
Log:
Added two new test types: @debugserver_test and @llgs_test.
TestLldbGdbServer now supports both lldb-gdbserver (llgs) and
debugserver tests. Similar to the
Author: tfiala
Date: Fri Apr 25 16:09:28 2014
New Revision: 207273
URL: http://llvm.org/viewvc/llvm-project?rev=207273view=rev
Log:
Prevent TestLldbGdbServer shutdown cleanup failures from failing the test.
Adds try/except blocks around clean-up code. Prevents a race between gdb
remote kill
Author: tfiala
Date: Fri Apr 25 18:08:24 2014
New Revision: 207285
URL: http://llvm.org/viewvc/llvm-project?rev=207285view=rev
Log:
Added TestLldbGdbServer test for A start exe packet.
Fixed up bug in XFAIL tests where I appended an array when I intended to merge
an array.
Added:
Author: tfiala
Date: Tue Apr 22 18:16:53 2014
New Revision: 206930
URL: http://llvm.org/viewvc/llvm-project?rev=206930view=rev
Log:
Added a packet-playback test facility for lldb-gdbserver and a few starter
tests.
lldbgdbserverutils.py has a new expect_lldb_gdbserver_replay() method
that plays
301 - 375 of 375 matches
Mail list logo
