Replace strtoul with ConvertString::ToUInt32
Socket::DecodeHostAndPort was accepting negative port numbers and numbers
65535, fixed
http://reviews.llvm.org/D6917
Files:
gtest/gtest.xcodeproj/project.pbxproj
gtest/unittest/Host/
gtest/unittest/Host/Makefile
You removed a comment from line 1 of source/Host/common/Socket.cpp. Fix that
and it will be good to go.
http://reviews.llvm.org/D6917
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
REPOSITORY
rL LLVM
http://reviews.llvm.org/D6917
Files:
lldb/trunk/gtest/gtest.xcodeproj/project.pbxproj
lldb/trunk/gtest/unittest/Host/Makefile
lldb/trunk/gtest/unittest/Host/SocketAddressTest.cpp
lldb/trunk/gtest/unittest/Host/SocketTest.cpp
The other option is to move all static Args::StringTo* calls into the Host
layer at an appropriate place.
Changes should be:
- please use Args::StringTo calls instead of manual strtoul() calls so we have
a common codebase and so people don't start using strtoul() on their own in
other places
Hi clayborg, ovyalov, sivachandra,
Why did I make this patch?
I am trying to get the remote tests running linux-linux when the hosts are
multi-homed, localhost or don't have proper DNS entries.
I need to add Socket::Get[Remote/Local]IpAddress
I wanted to make some unit tests to test it
So I
