Committed here:
svn commit
Sending
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
Transmitting file data .
Committed revision 217773.
On Fri, Sep 12, 2014 at 1:39 PM, Todd Fiala tfi...@google.com wrote:
My pleasure!
On Fri, Sep 12, 2014 at 1:38 PM, Stephane
I'm going to go ahead and get this in since I didn't hear any feedback.
(Working through your backlog of patches, Stephane...)
On Fri, Sep 5, 2014 at 8:11 AM, Todd Fiala tfi...@google.com wrote:
This looks reasonable; however, I’d like to hear the Apple guys since I’m
not sure if there’s any
I had a look at a few of the asserts in that function which end up being
the only portion of the body of some if checks. I tried rolling the ifs
into the assert, but made the assert relatively more complicated to read.
I ended up punting on that in the name of maintainability.
I'm hitting a
My pleasure!
On Fri, Sep 12, 2014 at 1:38 PM, Stephane Sezer s...@fb.com wrote:
Thanks a lot, Todd :)
On Sep 12, 2014, at 10:09 AM, Todd Fiala tfi...@google.com wrote:
I'm going to go ahead and get this in since I didn't hear any feedback.
(Working through your backlog of patches,
This looks reasonable; however, I’d like to hear the Apple guys since I’m
not sure if there’s any case for their hardware where this line wouldn’t be
true:
if (byte_order != eByteOrderInvalid)
{
assert (byte_order ==
