This revision was automatically updated to reflect the committed changes.
Closed by commit rL243281: [lldb-mi] Fix breakpoints on functions when C++
namespaces are used. (authored by dperchik).
Changed prior to commit:
http://reviews.llvm.org/D11396?vs=30609id=30704#toc
Repository:
rL LLVM
dawn updated this revision to Diff 30609.
dawn added a comment.
Comment about ::func syntax not working in lldb added as requested. Please
accept this patch - it fixes namespace tokens used in lldb-mi breakpoints like
-break-insert ns::func. Patches to lldb and other issues are not intended
dawn added a comment.
In http://reviews.llvm.org/D11396#210455, @ki.stfu wrote:
Please add this test and comment it out with FIXME explanation why it's
disabled. Also, could you please create a bug for this and add a link in
FIXME?
I don't have an account on bugzilla and don't want to
dawn added a comment.
In http://reviews.llvm.org/D11396#209412, @brucem wrote:
Could you please add a test for the file: + ::func case?
::func doesn't work in lldb! It needs to be fixed there first. If/when it is
fixed, I will add a test.
Repository:
rL LLVM
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
In http://reviews.llvm.org/D11396#209959, @dawn wrote:
In http://reviews.llvm.org/D11396#209412, @brucem wrote:
Could you please add a test for the file: + ::func case?
brucem added a comment.
Could you please add a test for the file: + ::func case?
Repository:
rL LLVM
http://reviews.llvm.org/D11396
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
dawn added a subscriber: lldb-commits.
dawn updated this revision to Diff 30300.
dawn added a comment.
This revision fixes the case that we have 'file:ns::func' and enables a test
case.
Repository:
rL LLVM
http://reviews.llvm.org/D11396
Files:
test/tools/lldb-mi/breakpoint/TestMiBreak.py
