:-)
On Thu, Sep 11, 2014 at 10:39 AM, Tong Shen wrote:
> Thanks Todd!
>
> http://reviews.llvm.org/D5307
>
>
>
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs
svn commit
Sendingsource/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp
Sendingsource/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
Sendingsource/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h
Sendingsource/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
Sendi
Great! I'll get those in, Tong.
On Thu, Sep 11, 2014 at 9:34 AM, Greg Clayton wrote:
> Looks good.
>
> > On Sep 10, 2014, at 7:34 PM, Tong Shen wrote:
> >
> > http://reviews.llvm.org/D5307
> >
> > Files:
> > source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp
> > source/Plugins/
Looks good.
> On Sep 10, 2014, at 7:34 PM, Tong Shen wrote:
>
> http://reviews.llvm.org/D5307
>
> Files:
> source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp
> source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
> source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h
> source/Pl
http://reviews.llvm.org/D5307
Files:
source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp
source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h
source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
source/Plugins/SymbolFile/DWA
Address Jason's comments
http://reviews.llvm.org/D5307
Files:
source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp
source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h
source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
sou
Greg has done most of the DWARF parser work, he should comment.
In DWARFDebugInfoEntry.cpp DW_FORM_ref_addr you use cu->GetAddressByteSize()
for the size (or cu_addr_size, used in a different part of the file) -- but if
this is a 64-bit binary using DWARF32, that would be wrong - this is a
refe
