Re: [Lldb-commits] [PATCH] Do not assert on POSIXDYLD double-eAdd.

2015-03-23 Thread Stephane Sezer
REPOSITORY rL LLVM http://reviews.llvm.org/D8495 Files: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp Index: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp === --- lldb/trunk/source

Re: [Lldb-commits] [PATCH] Do not assert on POSIXDYLD double-eAdd.

2015-03-20 Thread Greg Clayton
lgtm http://reviews.llvm.org/D8495 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] Do not assert on POSIXDYLD double-eAdd.

2015-03-20 Thread Stephane Sezer
Hi clayborg, tfiala, This has been discovered while experimenting with the gecko linker on android. In general, assert()'ing on "user input" is a bad idea. http://reviews.llvm.org/D8495 Files: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp Index: source/Plugins/DynamicLoader/POSIX