Re: [Lldb-commits] [PATCH] Fetch module specification from remote process also

2015-03-23 Thread Greg Clayton
Its mainly an efficiency thing. If you have a std::string you might need to allocate data on the heap to store the string just to make the call. Since this argument is a path, it is more likely to have to allocate on the heap. Most std::string implementations store the first 20 some bytes in the

Re: [Lldb-commits] [PATCH] Fetch module specification from remote process also

2015-03-23 Thread Greg Clayton
Fix the "std::string" arguments as noted in inline comments and this is good to go. Comment at: include/lldb/Host/common/NativeProcessProtocol.h:291 @@ +290,3 @@ +virtual lldb_private::FileSpec +GetLoadedModuleFileSpec(const std::string& module_path) = 0; + -

[Lldb-commits] [PATCH] Fetch module specification from remote process also

2015-03-23 Thread Tamas Berghammer
Hi ovyalov, clayborg, Fetch module specification from remote process also Previously the remote module specification was fetched only from the remote platform. With this CL if we have a remote process then we ask it if it have any information from a given module. It is required because on android