Re: [Lldb-commits] [PATCH] Fix Target::Launch in case of synchronous execution

2015-03-23 Thread Pavel Labath
Hi, what is the exact case this patch is trying to fix? Could you give steps to reproduce? Or even better, a test case? cheers, pl http://reviews.llvm.org/D8541 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___

Re: [Lldb-commits] [PATCH] Fix Target::Launch in case of synchronous execution

2015-03-23 Thread Ilia K
In http://reviews.llvm.org/D8541#145060, @labath wrote: Hi, what is the exact case this patch is trying to fix? Could you give steps to reproduce? Or even better, a test case? cheers, pl Sure. See it in TEST PLAN section. http://reviews.llvm.org/D8541 EMAIL PREFERENCES

[Lldb-commits] [PATCH] Fix Target::Launch in case of synchronous execution

2015-03-23 Thread Ilia K
Hi jingham, clayborg, This patch fixes Target::Launch in case of synchronous execution. http://reviews.llvm.org/D8541 Files: source/Target/Target.cpp Index: source/Target/Target.cpp === --- source/Target/Target.cpp +++

Re: [Lldb-commits] [PATCH] Fix Target::Launch in case of synchronous execution

2015-03-23 Thread Pavel Labath
wow, that's quite a test plan. :) Sorry about that, I didn't see anything in the email, and I did not know that phab does not send out the test plans O:) pl http://reviews.llvm.org/D8541 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

Re: [Lldb-commits] [PATCH] Fix Target::Launch in case of synchronous execution

2015-03-23 Thread Ilia K
In http://reviews.llvm.org/D8541#145077, @labath wrote: Sorry about that, I didn't see anything in the email, and I did not know that phab does not send out the test plans O:) It's a surprise for me too :) http://reviews.llvm.org/D8541 EMAIL PREFERENCES

Re: [Lldb-commits] [PATCH] Fix Target::Launch in case of synchronous execution

2015-03-23 Thread Greg Clayton
Looks good. http://reviews.llvm.org/D8541 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits