Re: [Lldb-commits] [PATCH] Fix junk content handling within GDBRemoteCommunication::CheckForPacket.

2014-10-30 Thread Greg Clayton
Can you redo this patch and only change stuff that is changed? There is so much whitespace change here I can't tell what little things have changed http://reviews.llvm.org/D6042 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Fix junk content handling within GDBRemoteCommunication::CheckForPacket.

2014-10-30 Thread Greg Clayton
Looks good. http://reviews.llvm.org/D6042 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fix junk content handling within GDBRemoteCommunication::CheckForPacket.

2014-10-30 Thread Shawn Best
Hey Oleksiy, can you rebase the patch for me, I got HUNK Failed when applying. It could be related to the whitespace stripping you did for Greg. Also, I notice something weird with the block of code you wrapped with the while() loop. It appears to be indented only 2 spaces instead of 4.