Re: [Lldb-commits] [PATCH] Fix up the HostThread interface

2014-09-23 Thread Zachary Turner
Closed by commit rL218325 (authored by @zturner). REPOSITORY rL LLVM http://reviews.llvm.org/D5417 Files: lldb/trunk/include/lldb/Core/Debugger.h lldb/trunk/include/lldb/Host/HostNativeThreadBase.h lldb/trunk/include/lldb/Host/HostThread.h lldb/trunk/include/lldb/Host/posix/HostThreadP

Re: [Lldb-commits] [PATCH] Fix up the HostThread interface

2014-09-23 Thread Greg Clayton
Looks good. > On Sep 19, 2014, at 1:51 PM, Zachary Turner wrote: > > * Removes GetState / SetState > * Adds a method IsJoinable() > > There is no need for a distinction between IsHandleValid and IsThreadRunning, > because even if a thread has run to completion, you are still required to > Jo

Re: [Lldb-commits] [PATCH] Fix up the HostThread interface

2014-09-23 Thread Greg Clayton
I just added an account. My username is "clayborg" registered with "Greg Clayton" as the name. > On Sep 19, 2014, at 3:06 PM, Zachary Turner wrote: > > +greg. Any chance you guys are willing to create Phabricator accounts? Even > if you don't use it to submit reviews, it's nice to just be ab

Re: [Lldb-commits] [PATCH] Fix up the HostThread interface

2014-09-19 Thread Zachary Turner
+greg. Any chance you guys are willing to create Phabricator accounts? Even if you don't use it to submit reviews, it's nice to just be able to type your name into the website and have it include you in the original email automatically. On Fri, Sep 19, 2014 at 1:51 PM, Zachary Turner wrote: >