Re: [Lldb-commits] [PATCH] Handle ARM ELF symbols properly.

2014-09-15 Thread Todd Fiala
Part 1 committed here: ``` svn commit Sendingsource/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Transmitting file data . Committed revision 217782. ``` Stephane - it would be great if you could add a unit test to verify those symbols are getting stripped. Let me know if you need help

Re: [Lldb-commits] [PATCH] Handle ARM ELF symbols properly.

2014-09-15 Thread Stephane Sezer
Version with comments added. On Sep 15, 2014, at 10:05 AM, Todd Fiala tfi...@google.com wrote: Hey Stephane, On patch 2 - could you add some comments around these bits? It’s a little unclear what’s happening there and I want to make sure we don’t break it at some point later. +

Re: [Lldb-commits] [PATCH] Handle ARM ELF symbols properly.

2014-09-15 Thread Todd Fiala
Looks good - change went in here: svn commit Sendingsource/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Sendingsource/Plugins/ObjectFile/ELF/ObjectFileELF.h Transmitting file data .. Committed revision 217841. ​ On Mon, Sep 15, 2014 at 3:30 PM, Todd Fiala tfi...@google.com wrote:

Re: [Lldb-commits] [PATCH] Handle ARM ELF symbols properly.

2014-09-10 Thread Stephane Sezer
Re-sending these, as the first email didn’t reach the mailing list for some reason. On Sep 9, 2014, at 5:27 PM, Stephane Sezer s...@fb.com wrote: Two patches here: [PATCH 1/2] Skip $t* and $a* symbols in ObjectFileELF. ELF objects contain marker symbols to differentiate between ARM and