Re: [Lldb-commits] [PATCH] LLDB ARM: Add support for arm-linux-gnu abi

2015-03-24 Thread Ed Maste
Comment at: lib/Makefile:41 @@ -40,2 +40,3 @@ lldbPluginABISysV_x86_64.a \ + lldbPluginABISysV_arm.a \ lldbPluginABISysV_hexagon.a \ Likely ought to be in alpha order, before _ppc (even if _hexagon is in the wrong spot)

[Lldb-commits] [PATCH] LLDB ARM: Add support for arm-linux-gnu abi

2015-03-23 Thread Muhammad Omair Javaid
Hi rengolin, vharron, tberghammer, This patch is first in a series of upcoming patches that add support for arm-linux-lldb. This patch will be usable once once support for Register Context will be added later this week. http://reviews.llvm.org/D8539 Files: cmake/LLDBDependencies.cmake

Re: [Lldb-commits] [PATCH] LLDB ARM: Add support for arm-linux-gnu abi

2015-03-23 Thread Tamas Berghammer
Looks good with a few minor suggestions Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:224 @@ +223,3 @@ +reg_value.SetUInt32(*ai); +if (!reg_ctx-WriteRegister(reg_ctx-GetRegisterInfoByName(reg_names[i]), reg_value)) +return false;