Re: [Lldb-commits] [PATCH] Make lldb-mi handle only MI commands

2015-03-20 Thread Hafiz Abid Qadeer
In http://reviews.llvm.org/D8381#142039, @ki.stfu wrote: > I don't mind about cleaning, but I disagree about CLI support in lldb-mi. In http://reviews.llvm.org/D8381#144097, @ted wrote: > gdb handles command line gdb and MI in one executable. I think lldb should do > the same. We ship one ex

Re: [Lldb-commits] [PATCH] Make lldb-mi handle only MI commands

2015-03-20 Thread Ilia K
Hello Ted, As I said above I planned to add support for CLI commands in lldb-mi. Here is my patch for that: http://reviews.llvm.org/D8483 Thanks, Ilia On Fri, Mar 20, 2015 at 5:47 PM, Ted Woodward wrote: > GDB handles command line GDB and MI in one executable. I think LLDB should > do the same

Re: [Lldb-commits] [PATCH] Make lldb-mi handle only MI commands

2015-03-18 Thread Hafiz Abid Qadeer
In http://reviews.llvm.org/D8381#142042, @ki.stfu wrote: > All tests pass on OS X. > > As I understood you will remove Driver.cpp later, right? Yes. I will remove it later. Thanks for review. http://reviews.llvm.org/D8381 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailprefere

Re: [Lldb-commits] [PATCH] Make lldb-mi handle only MI commands

2015-03-17 Thread Ilia K
All tests pass on OS X. As I understood you will remove Driver.cpp later, right? http://reviews.llvm.org/D8381 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http:

Re: [Lldb-commits] [PATCH] Make lldb-mi handle only MI commands

2015-03-17 Thread Ilia K
I don't mind about cleaning, but I disagree about CLI support in lldb-mi. I think it's useful (sometimes) to provide mix mode for user. I think support of mixed commands is useful (sometimes), and actually I planned to add this for lldb-mi one fine day. For example, lldb-mi supports "quit" comma

[Lldb-commits] [PATCH] Make lldb-mi handle only MI commands

2015-03-17 Thread Hafiz Abid Qadeer
Hi ki.stfu, Previously lldb-mi can also act as a driver like normal lldb. It needed a lot of redundant code in the lldb-mi for that. I think that if a user wants command line lldb driver then he/she should use the lldb for it. This change will cleanup the code a lot. When this change goes in, it