Re: [Lldb-commits] [PATCH] Move argument globbing to Target::Launch from Platform::LaunchProcess.

2015-02-20 Thread Greg Clayton
On Feb 19, 2015, at 7:55 PM, Zachary Turner ztur...@google.com wrote: Also, it seems to me there should be a function in Host called ShellExpand(). On Mac or whichever other platform wanted to, it could call in to argdumper. Other platforms could implement this some other way if they

Re: [Lldb-commits] [PATCH] Move argument globbing to Target::Launch from Platform::LaunchProcess.

2015-02-19 Thread Siva Chandra
Per the current design, the globbing feature will not work for remote debugging. Enrico has mentioned that he is working on the generalizing this feature. Until then, I do not see any harm in putting this in. Will commit shortly. http://reviews.llvm.org/D7743 EMAIL PREFERENCES

Re: [Lldb-commits] [PATCH] Move argument globbing to Target::Launch from Platform::LaunchProcess.

2015-02-19 Thread Enrico Granata
Disclaimer: any mention of “glowing” instead of “globbing” is autocorrect Over the next couple days, I want to spend some time generalizing this whole globbing thing Right now, it only works for local debugging, which is ugly. The theory is that Platforms should have a way to specify how they

Re: [Lldb-commits] [PATCH] Move argument globbing to Target::Launch from Platform::LaunchProcess.

2015-02-19 Thread Oleksiy Vyalov
Looks good to me - could you check whether this test passes remotely Linux-Linux? http://reviews.llvm.org/D7743 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Move argument globbing to Target::Launch from Platform::LaunchProcess.

2015-02-19 Thread Zachary Turner
There's currently a lot of ways to launch processes, and the interactions that lead to specific methods being chosen can be a bit confusing sometimes. Out of curiosity, if a plugin supports launching under a debugger directly, why is the separate start stopped / attach / resume algorithm used?

Re: [Lldb-commits] [PATCH] Move argument globbing to Target::Launch from Platform::LaunchProcess.

2015-02-19 Thread Oleksiy Vyalov
On Linux the platform is used to launch a process only when LLGS_LOCAL mode is on - otherwise, process plugin is used. I'm wondering whether we need the standalone binary argdumper for globbing - potentially, we may just use glob function on Linux and OSX. For remote execution there might be a