Re: [Lldb-commits] [PATCH] Print a newline before exiting the driver.

2015-01-16 Thread Greg Clayton
Looks fine. http://reviews.llvm.org/D5925 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Print a newline before exiting the driver.

2015-01-16 Thread Stephane Sezer
This issue does not repro anymore. http://reviews.llvm.org/D5925 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commi

Re: [Lldb-commits] [PATCH] Print a newline before exiting the driver.

2014-09-15 Thread Todd Fiala
That looks pretty reasonable. It'd be good to have Greg review it, though, since that's his baby. Greg, pushing on your stack. Thanks! -Todd On Mon, Sep 15, 2014 at 1:22 PM, Stephane Sezer wrote: > This should be slightly better. > > > > On Sep 15, 2014, at 9:52 AM, Todd Fiala wrote: > > >

Re: [Lldb-commits] [PATCH] Print a newline before exiting the driver.

2014-09-15 Thread Stephane Sezer
This should be slightly better. On Sep 15, 2014, at 9:52 AM, Todd Fiala wrote: > That'd be great, thanks! > > On Mon, Sep 15, 2014 at 9:48 AM, Stephane Sezer wrote: > Hey Todd, > > I see what you are talking about. If someone exits the debugger by typing > `exit` then there is an empty new-l

Re: [Lldb-commits] [PATCH] Print a newline before exiting the driver.

2014-09-15 Thread Todd Fiala
That'd be great, thanks! On Mon, Sep 15, 2014 at 9:48 AM, Stephane Sezer wrote: > Hey Todd, > > I see what you are talking about. If someone exits the debugger by typing > `exit` then there is an empty new-line being printed. The reason why I > wrote this patch in the first place is because I’m

Re: [Lldb-commits] [PATCH] Print a newline before exiting the driver.

2014-09-15 Thread Stephane Sezer
Hey Todd, I see what you are talking about. If someone exits the debugger by typing `exit` then there is an empty new-line being printed. The reason why I wrote this patch in the first place is because I’m used to exit the debugger with ^D instead, which results in the shell prompt being printe

Re: [Lldb-commits] [PATCH] Print a newline before exiting the driver.

2014-09-15 Thread Todd Fiala
Hey Stephane, For typical debugger usage, this is generally adding an extra blank line, which feels a little awkward. Could you consider reworking this perhaps to only add the extra \n if we're ending mid-line? Or fix the systems that are ending mid-line and have them add the \n when shutting do

[Lldb-commits] [PATCH] Print a newline before exiting the driver.

2014-09-10 Thread Stephane Sezer
This prevents messing up the shell's prompt. 0001-Print-a-newline-before-exiting-the-driver.patch Description: 0001-Print-a-newline-before-exiting-the-driver.patch ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/