Re: [Lldb-commits] [PATCH] Report breakpoint/watchpoint hits during single stepping.

2015-03-18 Thread Jim Ingham
Comment at: test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py:37-38 @@ +36,4 @@ +self.runCmd("target create " + exe, CURRENT_EXECUTABLE_SET) +self.runCmd("breakpoint set --name main", BREAKPOINT_CREATED) + +self.runCmd("process

Re: [Lldb-commits] [PATCH] Report breakpoint/watchpoint hits during single stepping.

2015-03-18 Thread Tamas Berghammer
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2254-2278 @@ -2253,53 +2253,27 @@ case 0: case TRAP_TRACE: // We receive this on single stepping. -if (log) -log->Printf ("NativeProcessLinux::%s() received trace event, pid = %"

Re: [Lldb-commits] [PATCH] Report breakpoint/watchpoint hits during single stepping.

2015-03-18 Thread Pavel Labath
Comment at: test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py:51 @@ +50,3 @@ + +self.expect("thread step-over") +self.expect("thread list", STOPPED_DUE_TO_WATCHPOINT, This test relies on step-over being implemented usin

Re: [Lldb-commits] [PATCH] Report breakpoint/watchpoint hits during single stepping.

2015-03-17 Thread Greg Clayton
Should probably init the references values to something invalid as mentioned in inlined comments. Comment at: source/Host/common/NativeRegisterContext.cpp:309 @@ -308,3 +308,3 @@ { return Error ("not implemented"); } Set "is_hit" to false? ==