Re: [Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-23 Thread Greg Clayton
Looks good. http://reviews.llvm.org/D8444 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-23 Thread Ilia K
Remove the const from SBxxx methods http://reviews.llvm.org/D8444 Files: include/lldb/API/SBCommandInterpreter.h include/lldb/Interpreter/CommandInterpreter.h scripts/Python/interface/SBCommandInterpreter.i source/API/SBCommandInterpreter.cpp source/Interpreter/CommandInterpreter.cpp

Re: [Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-23 Thread Ilia K
In http://reviews.llvm.org/D8444#145654, @clayborg wrote: > No, don't change any existing API. Unfortunately by the time we caught this > one, it was out in the wild and we had programs linking against it. Just make > sure to not add const to any new API. ok. http://reviews.llvm.org/D8444 E

Re: [Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-23 Thread Ilia K
Comment at: include/lldb/API/SBCommandInterpreter.h:27-67 @@ -26,43 +26,43 @@ bool GetStopOnContinue () const; void SetStopOnContinue (bool); bool GetStopOnError () const; void SetStopOnError (bool); bool GetStopOnCrash ()

Re: [Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-23 Thread Greg Clayton
No, don't change any existing API. Unfortunately by the time we caught this one, it was out in the wild and we had programs linking against it. Just make sure to not add const to any new API. http://reviews.llvm.org/D8444 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferen

Re: [Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-23 Thread Ilia K
Comment at: include/lldb/API/SBCommandInterpreter.h:223 @@ +222,3 @@ +bool +GetPromptOnQuit() const; + clayborg wrote: > You can actually take the const off of this as it does nothing when your only > member is an std::shared_ptr, std::auto_ptr or just a p

Re: [Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-23 Thread Ilia K
@clayborg, take a look again please. Comment at: include/lldb/API/SBCommandInterpreter.h:219-223 @@ -218,1 +218,7 @@ +bool +GetPromptOnQuit() const; + +void +SetPromptOnQuit(bool b); + clayborg wrote: > You also need to add these to the SBComman

Re: [Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-23 Thread Greg Clayton
Remove "const" as per inline comments. Comment at: include/lldb/API/SBCommandInterpreter.h:223 @@ +222,3 @@ +bool +GetPromptOnQuit() const; + You can actually take the const off of this as it does nothing when your only member is an std::shared_ptr, std:

Re: [Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-23 Thread Ilia K
Add GetPromptOnQuit/SetPromptOnQuit to SBCommandInterpreter.i http://reviews.llvm.org/D8444 Files: include/lldb/API/SBCommandInterpreter.h include/lldb/Interpreter/CommandInterpreter.h scripts/Python/interface/SBCommandInterpreter.i source/API/SBCommandInterpreter.cpp source/Interprete

Re: [Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-23 Thread Greg Clayton
Add the new API to the .i files as mentioned in the inline comments. Comment at: include/lldb/API/SBCommandInterpreter.h:219-223 @@ -218,1 +218,7 @@ +bool +GetPromptOnQuit() const; + +void +SetPromptOnQuit(bool b); + You also need to add these t

Re: [Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-23 Thread Ilia K
In http://reviews.llvm.org/D8444#145131, @abidh wrote: > MI part looks ok to me. Please wait for Greg to approve the rest. Thanks for review! @clayborg, take a look please. http://reviews.llvm.org/D8444 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _

Re: [Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-23 Thread Hafiz Abid Qadeer
MI part looks ok to me. Please wait for Greg to approve the rest. http://reviews.llvm.org/D8444 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.

Re: [Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-21 Thread Ilia K
Friendly ping. http://reviews.llvm.org/D8444 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

2015-03-19 Thread Ilia K
Hi abidh, clayborg, # Turn off interpreter.prompt-on-quit on startup (MI) # Add CommandInterpreter::SetPromptOnQuit # Add SBCommandInterpreter::GetPromptOnQuit/SetPromptOnQuit All tests pass on OS X. http://reviews.llvm.org/D8444 Files: include/lldb/API/SBCommandInterpreter.h include/lldb/I