Looks good.
http://reviews.llvm.org/D6918
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
REPOSITORY
rL LLVM
Comment at: /Users/vharron/ll/svn/lldb/source/Utility/UriParser.cpp:42
@@ -42,1 +41,3 @@
+char* end = nullptr;
int port_tmp = strtoul(port_buf, end, 10);
+if (*end != 0 || port_tmp 65535)
You may define port_tmp as auto instead
I would prefer this to use Args::StringToUInt32() instead of a manual call to
strtoul() from #include lldb/Interpreter/Args.h (even though the correct
usage of strtoul() is used here). This helps abstract us from the host we are
running on in case there is no strtoul() and also leads me to the
