looks good.
http://reviews.llvm.org/D10308
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Followed up on Jason's comments
- Added check for the presence of iOS
http://reviews.llvm.org/D10308
Files:
source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp
Index: source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp
===
---
If I understood you correctly, you want to add arch.GetTriple().isiOS() also
along with arch.GetTriple().isMacOSX(). Am I right ? If yes then I will do it.
http://reviews.llvm.org/D10308
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Add iOS as well as noted in the inline comment.
Comment at: source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp:240
@@ -240,1 +239,3 @@
+ if ((arch.GetTriple().getArch() == llvm::Triple::x86)
+ arch.GetTriple().isMacOSX())
{
add
On Mac OS X there's these simulator processes used for debugging iOS apps on
the Mac. They are native i386/x86_64 code, they use the native Mac OS X ABI,
but they link against different libraries so it behaves like an iOS device.
These processes will have an architecture like i386-apple-ios.
We need changes in every ABI plugin because same thing happens there also.
However, I wanted to fix MacOSX i386 ABI Plugin first. Thats why I
submitted fix for this Plugin as of now.
On Fri, Jun 5, 2015 at 6:00 PM, Ed Maste ema...@freebsd.org wrote:
On 5 June 2015 at 10:42,
From: Abhishek Aggarwal abhishek.a.aggar...@intel.com
- In ABIMacOSX_i386.cpp:
-- Earlier, only Triple:Arch was used to choose ABI
-- Now, Triple:OS is also used along with Triple:Arch
- Resolves PR-23718
Change-Id: Id8b1d86dda763241f9e594a1c71252555939af1e
Signed-off-by:
On 5 June 2015 at 10:42, abhishek.a.aggar...@intel.com wrote:
From: Abhishek Aggarwal abhishek.a.aggar...@intel.com
- In ABIMacOSX_i386.cpp:
-- Earlier, only Triple:Arch was used to choose ABI
-- Now, Triple:OS is also used along with Triple:Arch
- Resolves PR-23718
From: Abhishek Aggarwal abhishek.a.aggar...@intel.com
- In ABIMacOSX_i386.cpp:
-- Earlier, only Triple:Arch was used to choose ABI
-- Now, Triple:OS is also used along with Triple:Arch
- Resolves PR-23718
Change-Id: Id8b1d86dda763241f9e594a1c71252555939af1e
Signed-off-by:
