Re: [Lldb-commits] [PATCH] expose 64 bit addresses through MI

2015-03-18 Thread Chuck Ries
I am now using the PRIx64 macro in all locations. I checked and made sure that every type being used is either an MIUint64 or and lldb::addr_t, both of with are uint64s. I also noticed that IDS_CMD_ERR_LLDB_ERR_READ_MEM_BYTES was being initialized twice, and switched the second initialization

Re: [Lldb-commits] [PATCH] expose 64 bit addresses through MI

2015-03-13 Thread Ilia K
In http://reviews.llvm.org/D8238#140458, @zturner wrote: Or PRIxPTR as you said. Definitely not %ll though It depends on how an address type was specified. If it's uint64_t then use PRIx64, but if it was specified like void* then use PRIxPTR. http://reviews.llvm.org/D8238 EMAIL PREFERENCES

Re: [Lldb-commits] [PATCH] expose 64 bit addresses through MI

2015-03-13 Thread Ilia K
In some places address is printed as int instead of long long. I suppose that we should use %llx instead of %x. But perhaps would be better to use PRIx64 (or PRIxPTR) macro. Comment at: tools/lldb-mi/MICmdCmdBreak.cpp:337 @@ -336,3 +336,3 @@ // MI print -//