Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-07-01 Thread Greg Clayton
I will defer to Jim Ingham on this one. If he is OK with what you have done, I am good. REPOSITORY rL LLVM http://reviews.llvm.org/D9404 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-07-01 Thread Jim Ingham
I didn't look at the IRInterpreter part of this closely at first, but now looking over this a bit I am concerned about passing the ExecutionContext to CanInterpret, what information is that really providing? Do we expect some threads could interpret but not others? This just makes it

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-07-01 Thread Ewan Crawford
Could we please get a final answer on this? Cheers. REPOSITORY rL LLVM http://reviews.llvm.org/D9404 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-06-29 Thread Deepak Panickal
Adding Greg for review. REPOSITORY rL LLVM http://reviews.llvm.org/D9404 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-06-23 Thread Ewan Crawford
Thanks for the instructions Jim, I agree it would be good to get them documented somewhere. REPOSITORY rL LLVM http://reviews.llvm.org/D9404 Files: include/lldb/Expression/IRInterpreter.h include/lldb/Expression/IRMemoryMap.h include/lldb/Target/ABI.h

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-06-22 Thread Jim Ingham
Great. I am assuming these files are lldb_private, the instructions are slightly different for SB API files. Open the lldb.xcworkspace in the top-level lldb directory. Select the Project Navigator from the Navigators on the LHS of the Xcode window, and figure out where in the project

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-06-22 Thread Ed Maste
Is it worth documenting the XCode steps in the www docs? I had the same question some time ago and had someone on the IRC channel walk me through it. http://reviews.llvm.org/D9404 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-06-22 Thread Ewan Crawford
Hiya Jim, I do have access to an OSX system with Xcode. It would be good to know how to add files for future reference. http://reviews.llvm.org/D9404 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-06-19 Thread Ewan Crawford
Hi everyone, I'm still quite keen to get this patch through so I'd appreciate any more feedback you have. Also If I'm adding new files, how do I go about updating the xcode project file? http://reviews.llvm.org/D9404 Files: include/lldb/Expression/IRInterpreter.h

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-06-19 Thread Jim Ingham
Do you have a MacOS X system? If so I can explain how to add files in Xcode. If you don't, when you get around to checking this in just ping us and tell us what files you added, and one of us will add them to the project file. Jim On Jun 19, 2015, at 9:50 AM, Ewan Crawford e...@codeplay.com