Re: [Lldb-commits] [PATCH] Fix bug 23326.

In http://reviews.llvm.org/D9827#191558, @ki.stfu wrote: > @abidh, > > AFAIK, an another patch has been submitted: http://reviews.llvm.org/D10106. > Is this patch still necessary? Yes that one has been committed and I have closed the defect. Closing this revision. http://reviews.llvm.org/D98

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

Hiya Jim, I do have access to an OSX system with Xcode. It would be good to know how to add files for future reference. http://reviews.llvm.org/D9404 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mail

[Lldb-commits] [lldb] r240280 - Test Commit

Author: jaydeep Date: Mon Jun 22 08:58:30 2015 New Revision: 240280 URL: http://llvm.org/viewvc/llvm-project?rev=240280&view=rev Log: Test Commit Modified: lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp Modified: lldb/trunk/source/Plugins/Instruction/MIPS64/Emulat

Re: [Lldb-commits] [PATCH] Adding some more flakey tests to the XFAIL list

Logs sent directly to Ilia http://reviews.llvm.org/D10583 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] [MIPS] MIPS32 branch emulation and single-stepping

REPOSITORY rL LLVM http://reviews.llvm.org/D10596 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Avoid querying thread stop info if the thread hasn't been running

Feel free to use this but enable it only for specific triples where you know this is a valid approach. Try using the target's architecture and if it is android or linux OS, then enable this feature. http://reviews.llvm.org/D10550 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/email

Re: [Lldb-commits] [PATCH] Add handling of async notify packets.

Looks good. REPOSITORY rL LLVM http://reviews.llvm.org/D10544 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commi

Re: [Lldb-commits] [PATCH] Make SBValue::GetNonSyntheticValue return really that.

So the root shared pointer is always the original untouched value object (non-dynamic and non-synthetic). The ValueImpl sets booleans that allow it to say if it needs to get the dynamic or synthetic values from the untouched root shared pointer. These booleans for dynamic and synthetic are set b

Re: [Lldb-commits] [PATCH] Make SBValue::GetNonSyntheticValue return really that.

I checked in some code that clears up the ValueImpl::GetSP() a bit so it is easier to read. See: % svn commit source/API/SBValue.cpp Sendingsource/API/SBValue.cpp Transmitting file data . Committed revision 240299. http://reviews.llvm.org/D10581 EMAIL PREFERENCES http://revie

[Lldb-commits] [lldb] r240299 - Cleanup the code a bit to make it more readable.

Author: gclayton Date: Mon Jun 22 12:38:30 2015 New Revision: 240299 URL: http://llvm.org/viewvc/llvm-project?rev=240299&view=rev Log: Cleanup the code a bit to make it more readable. Add some if/then to avoid calling a function to get dynamic/synthetic types if we know we aren't going to need

Re: [Lldb-commits] [PATCH] Make SBValue::GetNonSyntheticValue return really that.

I have a case where in the ValueObject backing the SBValue (via the ValueImpl) is itself a synthetic value. I hoped to get the non-synthetic version by calling SBValue::GetNonSyntheticValue. Before the proposed change, it was only returning the SBValue made from the backing ValueObject (which wa

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

Great. I am assuming these files are lldb_private, the instructions are slightly different for SB API files. Open the lldb.xcworkspace in the top-level lldb directory. Select the Project Navigator from the Navigators on the LHS of the Xcode window, and figure out where in the project hierarch

Re: [Lldb-commits] [PATCH] [MIPS] MIPS32 branch emulation and single-stepping

Looks good. REPOSITORY rL LLVM http://reviews.llvm.org/D10596 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commi

Re: [Lldb-commits] [PATCH] Adding some more flakey tests to the XFAIL list

It would be great to try and fix these intermittent failures and see what the root cause it. Fine to expected fail them for now. Might be interesting to come up with a way to retry intermittent fails when running with dosep.py. We could make a "@expectedFailRetry" for the test cases that fail in

Re: [Lldb-commits] [PATCH] Make SBValue::GetNonSyntheticValue return really that.

I will need to check with Enrico Granata when he gets back as I think if what you are saying is true we are going to have more problems. If you can make a failing snippet of code and the python needed to make it fail, please attach it to a comment in here. Enrico is out until Wednesday so it mig

Re: [Lldb-commits] [PATCH] Make SBValue::GetNonSyntheticValue return really that.

The following is a small repro case I am using. C++ source (class.cc): 1 class CCC 2 { 3 public: 4 int a, b, c; 5 }; 6 7 int 8 main () 9 { 10 CCC obj = { 111, 222, 333 }; 11 return 0; 12 } Python (ccc.py): 1 import lldb 2 3 def ccc_summary(sbval

[Lldb-commits] [lldb] r240325 - Enhance lldb-mi arguments test (MI)

Author: dperchik Date: Mon Jun 22 15:41:57 2015 New Revision: 240325 URL: http://llvm.org/viewvc/llvm-project?rev=240325&view=rev Log: Enhance lldb-mi arguments test (MI) SUMMARY: Add additional arguments to lldb-mi args tests to make sure arguments with quotes are handled correctly. Reviewers:

Re: [Lldb-commits] [PATCH] Enhance lldb-mi arguments test (MI)

REPOSITORY rL LLVM http://reviews.llvm.org/D10523 Files: lldb/trunk/test/tools/lldb-mi/interpreter/TestMiInterpreterExec.py lldb/trunk/test/tools/lldb-mi/interpreter/main.cpp Index: lldb/trunk/test/tools/lldb-mi/interpreter/TestMiInterpreterExec.py =

Re: [Lldb-commits] [PATCH] Refactor GetVariableInfo/GetValueStringFormatted/GetValue to use the same code (MI), part 2

Please review? Thank you. REPOSITORY rL LLVM http://reviews.llvm.org/D10487 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/list

Re: [Lldb-commits] [PATCH] Add support for displaying the language in the frame-format string

Please review? Thank you. REPOSITORY rL LLVM http://reviews.llvm.org/D10561 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/list

[Lldb-commits] [lldb] r240327 - Adding some more flakey tests to the XFAIL list

Author: vharron Date: Mon Jun 22 15:54:14 2015 New Revision: 240327 URL: http://llvm.org/viewvc/llvm-project?rev=240327&view=rev Log: Adding some more flakey tests to the XFAIL list Modified: lldb/trunk/test/dosep.py lldb/trunk/test/tools/lldb-mi/TestMiGdbSetShow.py lldb/trunk/test/t

Re: [Lldb-commits] [PATCH] Adding some more flakey tests to the XFAIL list

Committed in r240327. http://reviews.llvm.org/D10583 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

Is it worth documenting the XCode steps in the www docs? I had the same question some time ago and had someone on the IRC channel walk me through it. http://reviews.llvm.org/D9404 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___

Re: [Lldb-commits] [PATCH] Add support for displaying the language in the frame-format string

Looks good. REPOSITORY rL LLVM http://reviews.llvm.org/D10561 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] r240351 - Fix a crasher on the MacOSX test suite for Objective C.

Author: gclayton Date: Mon Jun 22 17:35:07 2015 New Revision: 240351 URL: http://llvm.org/viewvc/llvm-project?rev=240351&view=rev Log: Fix a crasher on the MacOSX test suite for Objective C. Modified: lldb/trunk/source/Symbol/ClangASTType.cpp Modified: lldb/trunk/source/Symbol/ClangASTType.

[Lldb-commits] [lldb] r240354 - Reduced packet counts to the remote GDB server where possible.

Author: gclayton Date: Mon Jun 22 18:12:45 2015 New Revision: 240354 URL: http://llvm.org/viewvc/llvm-project?rev=240354&view=rev Log: Reduced packet counts to the remote GDB server where possible. We have been working on reducing the packet count that is sent between LLDB and the debugserver on

Re: [Lldb-commits] [PATCH] Make SBValue::GetNonSyntheticValue return really that.

For the record, I put a patch which solves the problem I describe here in a different way: http://reviews.llvm.org/D10624 With my understanding of the code base, I am inclined to think that both solutions should be present (though only one of them is sufficient to solve the problem I am hitting

Re: [Lldb-commits] [lldb] r240354 - Reduced packet counts to the remote GDB server where possible.

Greg's out of the office for tonight. Do you want to revert it or should I? > On Jun 22, 2015, at 7:10 PM, Chaoren Lin wrote: > > Hi Greg, > > This commit caused a severe breakage on the Linux buildbot. Would you mind if > I reverted it until you can find a fix? > > On Mon, Jun 22, 2015 at

[Lldb-commits] [lldb] r240371 - Revert "Reduced packet counts to the remote GDB server where possible."

Author: chaoren Date: Mon Jun 22 22:17:01 2015 New Revision: 240371 URL: http://llvm.org/viewvc/llvm-project?rev=240371&view=rev Log: Revert "Reduced packet counts to the remote GDB server where possible." This reverts commit 0cc0745ea9c68d7fdcadc9904cee3f13c96dae60. Due to breakage on Linux bui

[Lldb-commits] [lldb] r240373 - [LLDB][MIPS] MIPS32 branch emulation and single-stepping

Author: jaydeep Date: Mon Jun 22 22:37:08 2015 New Revision: 240373 URL: http://llvm.org/viewvc/llvm-project?rev=240373&view=rev Log: [LLDB][MIPS] MIPS32 branch emulation and single-stepping SUMMARY: This patch implements 1. Emulation of MIPS32 branch instructions 2. Enabl

Re: [Lldb-commits] [PATCH] Improve instruction emulation based stack unwinding on ARM

Tamas, I apologize for taking so long to get to this patch. I meant to do it over the weekend but didn't have the time - I need to think hard about changes in the unwinder before I feel comfortable with them and it took me a couple hours of staring at the patch and thinking things over. I much

Re: [Lldb-commits] [PATCH] Use both OS and Architecture to choose correct ABI

On Mac OS X there's these "simulator" processes used for debugging iOS apps on the Mac. They are native i386/x86_64 code, they use the native Mac OS X ABI, but they link against different libraries so it behaves like an iOS device. These processes will have an architecture like i386-apple-ios.