Re: [Lldb-commits] [lldb] r240435 - Mark SBFrame::GetFunctionName and SBFrame::IsInlined as const.

Hi, how will this affect the stability of the SB interface? I had a feeling we were trying to maintain backward compatibility ? I think a more backward compatible solution would be to introduce a new const method if you need it and leave the old one i

Re: [Lldb-commits] [PATCH] Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI)

Friendly ping. http://reviews.llvm.org/D9740 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Improve instruction emulation based stack unwinding on ARM

REPOSITORY rL LLVM http://reviews.llvm.org/D10447 Files: lldb/trunk/include/lldb/Symbol/FuncUnwinders.h lldb/trunk/source/Commands/CommandObjectTarget.cpp lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionAR

[Lldb-commits] [lldb] r240533 - Improve instruction emulation based stack unwinding on ARM

Author: tberghammer Date: Wed Jun 24 06:27:32 2015 New Revision: 240533 URL: http://llvm.org/viewvc/llvm-project?rev=240533&view=rev Log: Improve instruction emulation based stack unwinding on ARM * Add and fix the emulation of several instruction. * Disable frame pointer usage on Android. * Spec

[Lldb-commits] [lldb] r240546 - Proper handling of QNonStop packet response.

Author: ewancrawford Date: Wed Jun 24 10:14:26 2015 New Revision: 240546 URL: http://llvm.org/viewvc/llvm-project?rev=240546&view=rev Log: Proper handling of QNonStop packet response. Turn non-stop mode off if reply to QNonStop packet isn't an OK. Modified: lldb/trunk/include/lldb/Target/Tar

[Lldb-commits] [lldb] r240547 - Remove unused variable

Author: emaste Date: Wed Jun 24 10:27:35 2015 New Revision: 240547 URL: http://llvm.org/viewvc/llvm-project?rev=240547&view=rev Log: Remove unused variable Modified: lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp Modified: lldb/trunk/source/Plugins/Instruction/ARM64

Re: [Lldb-commits] [lldb] r240543 - Remove old local-only linux debugging code

On 24 June 2015 at 10:43, Pavel Labath wrote: > Author: labath > Date: Wed Jun 24 09:43:20 2015 > New Revision: 240543 > > URL: http://llvm.org/viewvc/llvm-project?rev=240543&view=rev > Log: > Remove old local-only linux debugging code Unfortunately the Phabricator notification didn't make it to

[Lldb-commits] [lldb] r240549 - Remove empty ProcessPOSIX::StopAllThreads

Author: emaste Date: Wed Jun 24 11:24:56 2015 New Revision: 240549 URL: http://llvm.org/viewvc/llvm-project?rev=240549&view=rev Log: Remove empty ProcessPOSIX::StopAllThreads The removal of ProcessLinux in r240543 left only an empty StopAllThreads (it's not needed on FreeBSD), so just remove it t

[Lldb-commits] [lldb] r240550 - Remove SetResumeState from POSIXThread::RefreshStateAfterStop

Author: emaste Date: Wed Jun 24 11:39:22 2015 New Revision: 240550 URL: http://llvm.org/viewvc/llvm-project?rev=240550&view=rev Log: Remove SetResumeState from POSIXThread::RefreshStateAfterStop With the removal of ProcessLinux in r240543 this code is used only on FreeBSD. FreeBSD isn't affected

Re: [Lldb-commits] [lldb] r240435 - Mark SBFrame::GetFunctionName and SBFrame::IsInlined as const.

Pavel is right. Our agreement was we wouldn't take anything AWAY from the SB API's. If you want to add a const version, you have to add one, not change an existing API. Jim > On Jun 24, 2015, at 12:43 AM, Pavel Labath wrote: > > Hi, > > how will this affect the stability of the SB interfac

[Lldb-commits] [PATCH] [LLDB][MIPS] Getting correct flags for MIPS

Hi clayborg, ovyalov, REPOSITORY rL LLVM http://reviews.llvm.org/D10685 Files: source/Plugins/Platform/Linux/PlatformLinux.cpp Index: source/Plugins/Platform/Linux/PlatformLinux.cpp === --- source/Plugins/Platform/Linux/Platfor

Re: [Lldb-commits] [PATCH] [ValueObjectPrinter::GetValueSummaryError] Get summary of non-synthetic values.

I don't think this is the right change. A summary should be getting the most qualified possible value - compatible with user settings - because it makes sense to use that extra information in presenting information. Imagine a summary that wants to say "I have %d elements". If we gave to it the

Re: [Lldb-commits] [PATCH] Remove POSIX thread/process abstraction

Comment at: source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:482-508 @@ +481,29 @@ + +#if 0 +/* Old posix one */ +Error +ProcessFreeBSD::DoResume() +{ +StateType state = GetPrivateState(); + +assert(state == eStateStopped); + +SetPrivateState(eStateRunning); + +boo

Re: [Lldb-commits] [PATCH] [ValueObjectPrinter::GetValueSummaryError] Get summary of non-synthetic values.

On Wed, Jun 24, 2015 at 10:46 AM, Enrico Granata wrote: > I don't think this is the right change. A summary should be getting the most > qualified > possible value - compatible with user settings - because it makes sense to > use that extra > information in presenting information. Imagine

Re: [Lldb-commits] [lldb] r240435 - Mark SBFrame::GetFunctionName and SBFrame::IsInlined as const.

Thanks. Jim > On Jun 24, 2015, at 11:12 AM, Oleksiy Vyalov wrote: > > Adding const modifier makes the class contract stricter and shouldn't break > existing clients. > In order to make it backward compatible will revert the CL and add new const > getters. > > On Wed, Jun 24, 2015 at 9:54 AM

Re: [Lldb-commits] [PATCH] [ValueObjectPrinter::GetValueSummaryError] Get summary of non-synthetic values.

Still not the right change. This will only "fix" the case of summaries - but other instances where people get their hands on an SBValue will still behave incorrectly. The underlying bug is the one in GetNonSyntheticValue(), and I'd prefer to fix that one instead of going around putting band-aid

Re: [Lldb-commits] [PATCH] [NativeProcessLinux] Use lambdas in DoOperation calls

Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:3171 @@ +3170,3 @@ + +intptr_t data = 0; + chaoren wrote: > Why not make this `void *` to begin with? Whoops, didn't see the assignment right below. Please ignore this. http://reviews.llvm.org/D10

Re: [Lldb-commits] [PATCH] [LLDBSwigPythonCallTypeScript] Remove redundant call to type summary func.

ping. This was probably missed due to the discussion on the other two patches. http://reviews.llvm.org/D10625 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://

Re: [Lldb-commits] [PATCH] Add branch emulation to aarch64 instruction emulator

Comment at: source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp:880 @@ +879,3 @@ +{ +#if 0 +// ARM64 pseudo code... Shouldn't this be a comment rather than `#if 0`? http://reviews.llvm.org/D10702 EMAIL PREFERENCES http://reviews.llvm.org/settings/p

Re: [Lldb-commits] [PATCH] Add branch emulation to aarch64 instruction emulator

Comment at: source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp:880 @@ +879,3 @@ +{ +#if 0 +// ARM64 pseudo code... emaste wrote: > Shouldn't this be a comment rather than `#if 0`? I did this based on the style we use in EmulateInstructionARM but it is

[Lldb-commits] [lldb] r240578 - Fix an issue where an SBValue could end up capturing a synthetic value and would then be unable to return the non-synthetic version thereof

Author: enrico Date: Wed Jun 24 14:53:22 2015 New Revision: 240578 URL: http://llvm.org/viewvc/llvm-project?rev=240578&view=rev Log: Fix an issue where an SBValue could end up capturing a synthetic value and would then be unable to return the non-synthetic version thereof This patch makes the ba

Re: [Lldb-commits] [PATCH] Make SBValue::GetNonSyntheticValue return really that.

Try this: Sendingsource/API/SBValue.cpp Transmitting file data . Committed revision 240578. It seems to fix your issue for me > On Jun 22, 2015, at 12:50 PM, Siva Chandra wrote: > > The following is a small repro case I am using. > > C++ source (class.cc): > > 1 class CCC > 2 { >

[Lldb-commits] [lldb] r240581 - Reduce FreeBSD log spam

Author: emaste Date: Wed Jun 24 15:02:56 2015 New Revision: 240581 URL: http://llvm.org/viewvc/llvm-project?rev=240581&view=rev Log: Reduce FreeBSD log spam The values of four important registers are included in logs for ptrace PT_GETREGS. Put all four on the same line for a more compact log. Als

Re: [Lldb-commits] [PATCH] Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined.

That seems fine. Jim > On Jun 24, 2015, at 2:05 PM, Oleksiy Vyalov wrote: > > Hi jingham, labath, > > Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined. > > http://reviews.llvm.org/D10711 > > Files: > include/lldb/API/SBFrame.h > scripts/interface/SBFrame.i > source/AP

Re: [Lldb-commits] [PATCH] Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined.

That seems fine. Jim http://reviews.llvm.org/D10711 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] [LLDBSwigPythonCallTypeScript] Remove redundant call to type summary func.

> On Jun 24, 2015, at 11:35 AM, Siva Chandra wrote: > > ping. > This was probably missed due to the discussion on the other two patches. > > > http://reviews.llvm.org/D10625 > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > > > > __

Re: [Lldb-commits] [lldb] r239996 - [LLDB][MIPS] Emulation of MIPS64 floating-point branch instructions

Hi Mohit, It seems this revision broke compile step on lldb-x86_64-freebsd builder: r 239995: http://lab.llvm.org:8011/builders/lldb-x86_64-freebsd/builds/5871 r 239996: http://lab.llvm.org:8011/builders/lldb-x86_64-freebsd/builds/5919 Please have a look at this? Thanks Galina On Wed, Jun

[Lldb-commits] [lldb] r240606 - Handle (or at least don't crash) trying to get the encoding for a bunch of new builtin types in clang trunk

Author: enrico Date: Wed Jun 24 18:13:23 2015 New Revision: 240606 URL: http://llvm.org/viewvc/llvm-project?rev=240606&view=rev Log: Handle (or at least don't crash) trying to get the encoding for a bunch of new builtin types in clang trunk Modified: lldb/trunk/source/Symbol/ClangASTType.cp

[Lldb-commits] [PATCH] Added expectedFlakey test decorator

Hi clayborg, chying, Flakey tests get two chances to pass http://reviews.llvm.org/D10721 Files: test/lldbtest.py Index: test/lldbtest.py === --- test/lldbtest.py +++ test/lldbtest.py @@ -646,6 +646,53 @@ return 'true' in

[Lldb-commits] [PATCH] Rename Mangled::GetLanguage to Mangled::GuessLanguage

Hi clayborg, The language can not be definitively determined from the mangling, so this new name helps clarify that fact. REPOSITORY rL LLVM http://reviews.llvm.org/D10723 Files: include/lldb/Core/Mangled.h source/Core/Mangled.cpp Index: include/lldb/Core/Mangled.h =

Re: [Lldb-commits] [PATCH] Rename Mangled::GetLanguage to Mangled::GuessLanguage

This patch addresses the concerns raised in http://reviews.llvm.org/rL226962. REPOSITORY rL LLVM http://reviews.llvm.org/D10723 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commit

Re: [Lldb-commits] [PATCH] Make SBValue::GetNonSyntheticValue return really that.

> On Jun 24, 2015, at 6:08 PM, Siva Chandra wrote: > > On Wed, Jun 24, 2015 at 12:58 PM, Enrico Granata wrote: >> >> Try this: >> Sendingsource/API/SBValue.cpp >> Transmitting file data . >> Committed revision 240578. >> >> It seems to fix your issue for me > > Yes, it works. Thanks

[Lldb-commits] [lldb] r240621 - xcode project file updates for the movement of the POSIX files into the FreeBSD process subdir.

Author: jmolenda Date: Wed Jun 24 22:03:47 2015 New Revision: 240621 URL: http://llvm.org/viewvc/llvm-project?rev=240621&view=rev Log: xcode project file updates for the movement of the POSIX files into the FreeBSD process subdir. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified

Re: [Lldb-commits] [PATCH] Add branch emulation to aarch64 instruction emulator

Greg's the best person to review this - as for the comment vrs. #if 0, I don't have a preference; I think for larger blocks of code the #if 0 is less noisy but it can also be easy to miss the fact that the code block is commented out when you're readingit. http://reviews.llvm.org/D10702 EMAIL

Re: [Lldb-commits] [lldb] r239996 - [LLDB][MIPS] Emulation of MIPS64 floating-point branch instructions

Hi Galina, On Thu, Jun 25, 2015 at 4:26 AM, Galina Kistanova wrote: > Hi Mohit, > > It seems this revision broke compile step on lldb-x86_64-freebsd builder: > > r 239995: > http://lab.llvm.org:8011/builders/lldb-x86_64-freebsd/builds/5871 > I assume you are talking about r 239991.In this commi