I will defer to Jim Ingham on this one. If he is OK with what you have done, I
am good.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D9404
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
I didn't look at the IRInterpreter part of this closely at first, but now
looking over this a bit I am concerned about passing the ExecutionContext to
CanInterpret, what information is that really providing? Do we expect some
threads could interpret but not others? This just makes it
Comment at: source/Commands/CommandObjectBugreport.cpp:72
@@ +71,3 @@
+
+char command_buffer[256];
+
I'd defined this buffer before the loop to avoid memory allocation per each
frame.
Comment at:
Comment at: source/Commands/CommandObjectBugreport.cpp:88
@@ +87,3 @@
+
+uint32_t open_options = File::eOpenOptionWrite |
File::eOpenOptionCanCreate;
+const bool append =
m_outfile_options.GetAppend().GetCurrentValue();
In
Hi labath, jasonmolenda,
Improve DWARF CFI CIE parsing and remove duplicated code
Previously we handled only a few opcode DWARF CFI opcode when we
were parsing the CIE. With this change we use mostly the same code
what we use for parsing the PDE which cover more opcode.
Hi clayborg, ovyalov,
Add new bugreport command to lldb
The new command add functionality to print out domain specific
information for reporting a bug. Currently the only supported
domain is stack unwinding (with bugreport unwind) but adding
new domains is fairly easy.
Address review comment about append and truncate
http://reviews.llvm.org/D10868
Files:
lldb.xcodeproj/project.pbxproj
source/Commands/CMakeLists.txt
source/Commands/CommandObjectBugreport.cpp
source/Commands/CommandObjectBugreport.h
source/Interpreter/CommandInterpreter.cpp
EMAIL
Comment at:
test/functionalities/thread/create_after_attach/TestCreateAfterAttach.py:83
@@ -80,1 +82,3 @@
+# std::thread may cause the program to spin up a thread pool (and it
does on
+# Windows), so the thread numbers are non-deterministic.
-pie is not compatible with -static. lldb-server can work on any API if
linked statically.
On Jul 1, 2015 02:17, Tamas Berghammer tbergham...@google.com wrote:
Comment at: cmake/platforms/Android.cmake:98-102
@@ -97,7 +101,2 @@
-# PIE is required for API 21+ so we enable it
On 30 June 2015 at 18:18, Enrico Granata egran...@apple.com wrote:
option a: cast the switched value to int: this should get rid of the
warning in this case..
If anything, this feels like a hack-around the warning. Given that there
is at least a better option, I’d say “nay” personally
I
REPOSITORY
rL LLVM
http://reviews.llvm.org/D10744
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
(fyi - added additional reviewers from related patch at
http://reviews.llvm.org/D7302)
REPOSITORY
rL LLVM
http://reviews.llvm.org/D10744
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
Author: enrico
Date: Wed Jul 1 15:06:40 2015
New Revision: 241184
URL: http://llvm.org/viewvc/llvm-project?rev=241184view=rev
Log:
When I introduced hard-coded formatters, I made them non-cacheable
This is because - in theory - the formatter could match on not just the type,
but also other
Author: jingham
Date: Wed Jul 1 14:27:08 2015
New Revision: 241181
URL: http://llvm.org/viewvc/llvm-project?rev=241181view=rev
Log:
Add a missing space.
Modified:
lldb/trunk/examples/python/scripted_step.py
Modified: lldb/trunk/examples/python/scripted_step.py
URL:
Hi zturner,
This commit moves the Windows DyanamicLoader to the common DynamicLoader
directory. This is required to remote debug Windows targets.
This commit also initializes the Windows DYLD plugin in
SystemInitializerCommon (similarly to both POSIX and MacOSX DYLD
plugins) so that we can
Comment at:
test/functionalities/thread/create_after_attach/TestCreateAfterAttach.py:93
@@ -90,1 +92,3 @@
+ 'main',
+ 'stop reason = breakpoint'])
amccarth wrote:
chaoren wrote:
amccarth wrote:
labath wrote:
Could we please get a final answer on this? Cheers.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D9404
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
Author: dperchik
Date: Wed Jul 1 12:41:02 2015
New Revision: 241173
URL: http://llvm.org/viewvc/llvm-project?rev=241173view=rev
Log:
Fix typo in comment.
Modified:
lldb/trunk/source/Expression/ClangUserExpression.cpp
Modified: lldb/trunk/source/Expression/ClangUserExpression.cpp
URL:
So much of the useful bug reporting information in lldb is gathered by turning
on logs BEFORE the bad thing occurs, then making it happen, then gathering the
logs that were produced as a part of that process. For instance, once a bad
unwind has occurred that info is cached, and you can't watch
I agree that we can collect only a very limited information with a single
command after the problem already occurred but my intuition is that if we want
the user to reproduce the issue then there is much lower chance that they will
submit a bug report even for people working on LLDB.
For stack
Does the LoL DB API output a clear and actionable error code if the
filename you are launching is too long? If not please add a test for this
On Jul 1, 2015 6:26 PM, Chaoren Lin chaor...@google.com wrote:
Hi sivachandra,
The long name causes problems with some shells.
LoL
LL
Spectacular speech to text failure
On Jul 1, 2015 8:11 PM, Vince Harron vi...@nethacker.com wrote:
Does the LoL DB API output a clear and actionable error code if the
filename you are launching is too long? If not please add a test for this
On Jul 1, 2015 6:26 PM, Chaoren Lin
Does the LoL DB API output a clear and actionable error code if the
filename you are launching is too long? If not please add a test for this
REPOSITORY
rL LLVM
http://reviews.llvm.org/D10888
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
LoL
LL
Spectacular speech to text failure
REPOSITORY
rL LLVM
http://reviews.llvm.org/D10888
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
See http://reviews.llvm.org/D10744 for a rewrite of this patch.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7302
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
I would prefer to see this patch done differently. There are new methods make
on Mangled and on ConstString that probably don't need to be there.
New methods on ConstString are required in order to undo/redo the demangling
once the language is known.
Can we have the mangled names be
Author: chying
Date: Wed Jul 1 17:44:27 2015
New Revision: 241202
URL: http://llvm.org/viewvc/llvm-project?rev=241202view=rev
Log:
Run teardown and setup before retry for expectedFlakey tests
Summary:
If test is decorated with expectedFlakey*, run teardown and setup before retry
Don't run retry
Author: sivachandra
Date: Wed Jul 1 18:27:32 2015
New Revision: 241208
URL: http://llvm.org/viewvc/llvm-project?rev=241208view=rev
Log:
[Python] Allow PyLong values in integer lists (when converting to C lists)
Test Plan: dotest.py -p TestSBData
Reviewers: clayborg, granata.enrico
Reviewed
Author: gclayton
Date: Wed Jul 1 18:29:06 2015
New Revision: 241210
URL: http://llvm.org/viewvc/llvm-project?rev=241210view=rev
Log:
Check to make sure we have a valid N_GSYM symbol name before we use it for
anything.
Modified:
Author: gclayton
Date: Wed Jul 1 18:28:31 2015
New Revision: 241209
URL: http://llvm.org/viewvc/llvm-project?rev=241209view=rev
Log:
Fix indentation.
Modified:
lldb/trunk/source/Target/Thread.cpp
Modified: lldb/trunk/source/Target/Thread.cpp
URL:
Author: jingham
Date: Wed Jul 1 19:24:17 2015
New Revision: 241216
URL: http://llvm.org/viewvc/llvm-project?rev=241216view=rev
Log:
Another slightly less goofy example of scripted steps.
Modified:
lldb/trunk/examples/python/scripted_step.py
Modified:
31 matches
Mail list logo
