Re: [Lldb-commits] [PATCH] Fix showing children of synthetic providers for void*

2014-06-24 Thread Bruce Mitchener
On Tue, Jun 24, 2014 at 1:23 AM, Enrico Granata egran...@apple.com wrote: If you want to pursue this avenue, you may want to test with something along these lines and then resubmit Thanks, I will! - Bruce ___ lldb-commits mailing list

Re: [Lldb-commits] r211607 - Added support for new MI commands and bug fixes.

2014-06-24 Thread John Wolfe
The changes to tools/lldb-mi/CMakeLists.txt have removed the source file MIUtilSetID.cpp, yet MIUtilSetID.cpp and MIUtilSetID.h are still visible in the source tree. cmake notices that discrepancy and fails with: CMake Error at cmake/modules/LLVMProcessSources.cmake:66 (message): Found

[Lldb-commits] [lldb] r211618 - Remove unused files, causing CMake build error.

2014-06-24 Thread Deepak Panickal
Author: panickal Date: Tue Jun 24 13:20:51 2014 New Revision: 211618 URL: http://llvm.org/viewvc/llvm-project?rev=211618view=rev Log: Remove unused files, causing CMake build error. Removed: lldb/trunk/tools/lldb-mi/MIUtilSetID.cpp lldb/trunk/tools/lldb-mi/MIUtilSetID.h Removed:

Re: [Lldb-commits] r211607 - Added support for new MI commands and bug fixes.

2014-06-24 Thread Deepak Panickal
Thanks John, have removed them now. -- Deepak On 24/06/2014 18:55, John Wolfe wrote: The changes to tools/lldb-mi/CMakeLists.txt have removed the source file MIUtilSetID.cpp, yet MIUtilSetID.cpp and MIUtilSetID.h are still visible in the source tree. cmake notices that discrepancy and fails

[Lldb-commits] [lldb] r211620 - Restore fixes reverted by r211607:

2014-06-24 Thread Ed Maste
Author: emaste Date: Tue Jun 24 14:16:18 2014 New Revision: 211620 URL: http://llvm.org/viewvc/llvm-project?rev=211620view=rev Log: Restore fixes reverted by r211607: r209631: Use MIUtilSystemLinux on FreeBSD as well We should later rename this file (probably MIUtilSystemPOSIX), but more

Re: [Lldb-commits] [lldb] r211607 - Added support for new MI commands and bug fixes. More details in MIReadme.txt.

2014-06-24 Thread Ed Maste
On 24 June 2014 12:35, Deepak Panickal dee...@codeplay.com wrote: Author: panickal Date: Tue Jun 24 11:35:50 2014 New Revision: 211607 URL: http://llvm.org/viewvc/llvm-project?rev=211607view=rev Log: Added support for new MI commands and bug fixes. More details in MIReadme.txt. This commit

[Lldb-commits] [lldb] r211621 - Restore r211547: Add newline on last line of a few files.

2014-06-24 Thread Ed Maste
Author: emaste Date: Tue Jun 24 14:18:28 2014 New Revision: 211621 URL: http://llvm.org/viewvc/llvm-project?rev=211621view=rev Log: Restore r211547: Add newline on last line of a few files. Modified: lldb/trunk/tools/lldb-mi/Driver.cpp lldb/trunk/tools/lldb-mi/MIUtilSingletonBase.h

Re: [Lldb-commits] [PATCH] Add API control of the signal disposition.

2014-06-24 Thread Zachary Turner
This breaks the windows build. The name of this file suggests that it's platform specific, but none of the code in particular that it's using is actually platform specific. Should this file be compiled on Windows or not? http://reviews.llvm.org/D4221

Re: [Lldb-commits] [PATCH] Add API control of the signal disposition.

2014-06-24 Thread Zachary Turner
Thanks. It looks like UnixSignals.cpp is compiled on Windows, therefore this should too. For whatever reason, the list of files to compile for the API are maintained in a different CMake location on Windows than on non-Windows. So when adding a file to API, you need to add it in two places.

Re: [Lldb-commits] [PATCH] Allow MachO JIT debugging

2014-06-24 Thread Keno Fischer
Was there anything else I should do here? On Thu, Jun 19, 2014 at 1:41 PM, Keno Fischer kfisc...@college.harvard.edu wrote: Slight adjustment to updateSectionLoadAddress to properly adjust the load address range of fake segments. http://reviews.llvm.org/D4006 Files:

[Lldb-commits] [lldb] r211635 - Fix up Windows build for the SBUnixSignals addition.

2014-06-24 Thread Todd Fiala
Author: tfiala Date: Tue Jun 24 16:38:31 2014 New Revision: 211635 URL: http://llvm.org/viewvc/llvm-project?rev=211635view=rev Log: Fix up Windows build for the SBUnixSignals addition. Change by Zachary Turner. Modified: lldb/trunk/source/API/CMakeLists.txt

[Lldb-commits] [lldb] r211636 - Rework fix in r201744. You really DO need to waitpid twice to get the

2014-06-24 Thread Jim Ingham
Author: jingham Date: Tue Jun 24 16:51:42 2014 New Revision: 211636 URL: http://llvm.org/viewvc/llvm-project?rev=211636view=rev Log: Rework fix in r201744. You really DO need to waitpid twice to get the process fully reaped. The race bad behavior was because we were letting the reaping thread

Re: [Lldb-commits] [PATCH] Allow MachO JIT debugging

2014-06-24 Thread Keno Fischer
Ok, great! I don't have commit access, so would you mind committing this? On Tue, Jun 24, 2014 at 5:50 PM, Greg Clayton gclay...@apple.com wrote: Looks good. On Jun 19, 2014, at 10:41 AM, Keno Fischer kfisc...@college.harvard.edu wrote: Slight adjustment to updateSectionLoadAddress to

[Lldb-commits] [lldb] r211638 - Patch from Keno Fischer to enable JITLoaderGDB with mach-o file support.

2014-06-24 Thread Greg Clayton
Author: gclayton Date: Tue Jun 24 17:22:43 2014 New Revision: 211638 URL: http://llvm.org/viewvc/llvm-project?rev=211638view=rev Log: Patch from Keno Fischer to enable JITLoaderGDB with mach-o file support. The patch is as is with the functionality left disabled for apple vendors because of

Re: [Lldb-commits] [PATCH] Allow MachO JIT debugging

2014-06-24 Thread Greg Clayton
% svn commit Sendinginclude/lldb/Core/Section.h Sendinglib/Makefile Sendingsource/Core/Section.cpp Sendingsource/Expression/IRExecutionUnit.cpp Sendingsource/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Sendingsource/Plugins/Makefile Sending

[Lldb-commits] [PATCH] Don't truncate the target triple when initializing clang

2014-06-24 Thread Zachary Turner
Hi tfiala, Don't truncate the target triple when initializing clang. Target triples support an optional 4th component, the environment. Clang on Windows uses this 4th component to make various decisions when looking for header file includes, so truncating it leads to crashes on Windows when

Re: [Lldb-commits] [PATCH] Add API control of the signal disposition.

2014-06-24 Thread Russell Harmon
It should be just as platform dependant as the UnixSignals object it relies on. I didn't originally write it with windows in mind. What's standard procedure here? Rollback? Or fix forward? Without looking at the code, how does Windows deal with the UnixSignals object? Is it just not built? On