Re: [Lldb-commits] [PATCH] Invalidate process uid/gid command options on Windows

2014-07-07 Thread jingham
If there's no target, then we should consult the current platform - if nobody set a platform then that will default to the host platform. Usually you get that from the target, so it would seem odd to pass that in separately, but maybe in this case that's okay to do. Otherwise whoever would be

Re: [Lldb-commits] [PATCH] Invalidate process uid/gid command options on Windows

2014-07-07 Thread Zachary Turner
I guess approaching the question from a different angle. Consider two scenarios: 1) You run platform process list while connected to a target. 2) You run platform process list while not connected to a target. In scenario #2, the only option is to display processes on the host. In scenario #1,

Re: [Lldb-commits] [PATCH] Allow specification of no source display on stop

2014-07-07 Thread Todd Fiala
I'll have a run through with it and then I'll submit it. Here are the tests that currently fail for me intermittently on Linux: TestConvenienceVariables.py TestFormatters.py TestLongjmp.py Test-rdar-9974002.py TestWatchpointMultipleThreads.py There might be one more in there, but those are the

Re: [Lldb-commits] [PATCH] Allow specification of no source display on stop

2014-07-07 Thread Todd Fiala
In fact enough talk about them being intermittent. I'll go ahead and disable them on Linux with bugs filed. We really should have a clean test run on Linux, and follow up on addressing those. On Mon, Jul 7, 2014 at 1:39 PM, Todd Fiala tfi...@google.com wrote: (There's also a

[Lldb-commits] [lldb] r212486 - Marked TestFormatters.py XFAIL on Linux per pr20230.

2014-07-07 Thread Todd Fiala
Author: tfiala Date: Mon Jul 7 15:58:38 2014 New Revision: 212486 URL: http://llvm.org/viewvc/llvm-project?rev=212486view=rev Log: Marked TestFormatters.py XFAIL on Linux per pr20230. See http://www.llvm.org/bugs/show_bug.cgi?id=20230 for details. Modified:

[Lldb-commits] [lldb] r212488 - Marked TestLongjmp.py tests XFAIL for Linux.

2014-07-07 Thread Todd Fiala
Author: tfiala Date: Mon Jul 7 16:07:41 2014 New Revision: 212488 URL: http://llvm.org/viewvc/llvm-project?rev=212488view=rev Log: Marked TestLongjmp.py tests XFAIL for Linux. See http://llvm.org/bugs/show_bug.cgi?id=20231 Modified: lldb/trunk/test/functionalities/longjmp/TestLongjmp.py

[Lldb-commits] [lldb] r212491 - Mark test_watchpoint_multiple_threads_with_dwarf as XFAIL on Linux/clang.

2014-07-07 Thread Todd Fiala
Author: tfiala Date: Mon Jul 7 16:28:37 2014 New Revision: 212491 URL: http://llvm.org/viewvc/llvm-project?rev=212491view=rev Log: Mark test_watchpoint_multiple_threads_with_dwarf as XFAIL on Linux/clang. See http://llvm.org/bugs/show_bug.cgi?id=20233 for details. Modified:

Re: [Lldb-commits] [PATCH] Implement platform process list for Windows

2014-07-07 Thread Greg Clayton
Looks good. On Jul 7, 2014, at 4:56 PM, Zachary Turner ztur...@google.com wrote: Hi tfiala, This patch implements basic functionality of the platform process list command for Windows. Currently this patch has the following known limitations: * Certain types of filtering are not

[Lldb-commits] [lldb] r212506 - If a hand-called function is interrupted by hitting a breakpoint, then

2014-07-07 Thread Jim Ingham
Author: jingham Date: Mon Jul 7 20:07:32 2014 New Revision: 212506 URL: http://llvm.org/viewvc/llvm-project?rev=212506view=rev Log: If a hand-called function is interrupted by hitting a breakpoint, then when you continue to finish off the function call, the expression result will be included as

[Lldb-commits] [lldb] r212507 - Add docs for the thread.completed-expression format entry.

2014-07-07 Thread Jim Ingham
Author: jingham Date: Mon Jul 7 20:10:49 2014 New Revision: 212507 URL: http://llvm.org/viewvc/llvm-project?rev=212507view=rev Log: Add docs for the thread.completed-expression format entry. Modified: lldb/trunk/www/formats.html Modified: lldb/trunk/www/formats.html URL:

Re: [Lldb-commits] [PATCH] lldb - __arm64__ vs __aarch64__ insanity

2014-07-07 Thread Paul Osmialowski
RNBDefs.h changed as requested. http://reviews.llvm.org/D4379 Files: source/Core/Error.cpp source/Host/common/Host.cpp source/Host/macosx/Host.mm source/Host/macosx/Symbols.cpp source/Interpreter/CommandInterpreter.cpp source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp