[Lldb-commits] [lldb] r213861 - Fix endian test for big-endian hosts

2014-07-24 Thread Ed Maste
Author: emaste Date: Thu Jul 24 08:28:16 2014 New Revision: 213861 URL: http://llvm.org/viewvc/llvm-project?rev=213861view=rev Log: Fix endian test for big-endian hosts The uint16_t cast truncated the magic value to 0x0304, making the first byte 0 (eByteOrderInvalid) on big endian hosts.

[Lldb-commits] [lldb] r213875 - We were turning off all these tests on OSX and FreeBSD because of a known (and fairly unimportant) bug.

2014-07-24 Thread Jim Ingham
Author: jingham Date: Thu Jul 24 11:56:19 2014 New Revision: 213875 URL: http://llvm.org/viewvc/llvm-project?rev=213875view=rev Log: We were turning off all these tests on OSX and FreeBSD because of a known (and fairly unimportant) bug. Keep a test for that bug, but let the useful parts of the

Re: [Lldb-commits] [PATCH] Fix supported Architectures for PlatformWindows

2014-07-24 Thread Zachary Turner
Remove i486 and i486sx, only support i386 and i686 http://reviews.llvm.org/D4658 Files: include/lldb/Core/ArchSpec.h source/Core/ArchSpec.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

Re: [Lldb-commits] [PATCH] Add kalimba architecture checking to TestImageListMultiArchitecture

2014-07-24 Thread Todd Fiala
Always happy to help get better code coverage in place. These tests are particularly nice since they run in everyone's test environment regardless of host. Those are the nicest tests :-) On Wed, Jul 23, 2014 at 10:02 PM, Matthew Gardiner m...@csr.com wrote: Todd Fiala wrote: And meant to

Re: [Lldb-commits] [PATCH] Improvement for lldb-gdb-remote.txt qHostInfo documentation

2014-07-24 Thread Todd Fiala
My pleasure :-) On Wed, Jul 23, 2014 at 10:03 PM, Matthew Gardiner m...@csr.com wrote: Todd Fiala wrote: Done: svn commit Sendingdocs/lldb-gdb-remote.txt Transmitting file data . Committed revision 213756. Thanks again! Matt Member of the CSR plc group of companies. CSR

Re: [Lldb-commits] [PATCH] Refactor Socket into a first class Host-object

2014-07-24 Thread Zachary Turner
Fixed a few bugs http://reviews.llvm.org/D4641 Files: include/lldb/Core/ConnectionFileDescriptor.h include/lldb/Host/Editline.h include/lldb/Host/File.h include/lldb/Host/IoObject.h include/lldb/Host/Socket.h source/Core/ConnectionFileDescriptor.cpp

Re: [Lldb-commits] [PATCH] Refactor Socket into a first class Host-object

2014-07-24 Thread Zachary Turner
Rebased against tip and fixed some comments. http://reviews.llvm.org/D4641 Files: include/lldb/Core/ConnectionFileDescriptor.h include/lldb/Host/Editline.h include/lldb/Host/File.h include/lldb/Host/IoObject.h include/lldb/Host/Socket.h source/Core/ConnectionFileDescriptor.cpp

Re: [Lldb-commits] [PATCH] Improvement for lldb-gdb-remote.txt qHostInfo documentation

2014-07-24 Thread Jason Molenda
IMO we should change the implementation and the documentation for qHostInfo triple to not specify/use hex encoded strings. debugserver doesn't send triple. I don't know about llgs or how much work it would be to change the kalimba gdbserver stub. On Jul 24, 2014, at 1:39 PM, Jason Molenda

[Lldb-commits] [lldb] r213904 - Fix configure/make builds on MacOSX.

2014-07-24 Thread Todd Fiala
Author: tfiala Date: Thu Jul 24 18:22:58 2014 New Revision: 213904 URL: http://llvm.org/viewvc/llvm-project?rev=213904view=rev Log: Fix configure/make builds on MacOSX. Change by Keno Fischer. Modified: lldb/trunk/source/Host/common/Host.cpp Modified: lldb/trunk/source/Host/common/Host.cpp

Re: [Lldb-commits] Possible UnwindAssembly-x86 Problem Fix

2014-07-24 Thread Jason Molenda
Yep. On Jul 24, 2014, at 5:28 PM, Todd Fiala tfi...@google.com wrote: Hey Jason - if Tong verifies this is all still good, is that essentially a LGTM from you? (i.e. is that something I can get checked in for him?) On Thu, Jul 24, 2014 at 5:16 PM, Jason Molenda jmole...@apple.com

Re: [Lldb-commits] Possible UnwindAssembly-x86 Problem Fix

2014-07-24 Thread Todd Fiala
Hey Jason - if Tong verifies this is all still good, is that essentially a LGTM from you? (i.e. is that something I can get checked in for him?) On Thu, Jul 24, 2014 at 5:16 PM, Jason Molenda jmole...@apple.com wrote: Good catch Tong. I don't think clang generates this instruction pattern

Re: [Lldb-commits] Possible UnwindAssembly-x86 Problem Fix

2014-07-24 Thread Todd Fiala
Hey Tong - I'll add that and do all the test runs. I'll get it checked in unless something breaks. -Todd On Thu, Jul 24, 2014 at 5:32 PM, Tong Shen endlessr...@google.com wrote: Hi Jason, I don't have any strong preference here, so let's do it the way you see fit :-) Your patch works

Re: [Lldb-commits] Possible UnwindAssembly-x86 Problem Fix

2014-07-24 Thread Tong Shen
Thanks Todd! On Thu, Jul 24, 2014 at 5:33 PM, Todd Fiala tfi...@google.com wrote: Hey Tong - I'll add that and do all the test runs. I'll get it checked in unless something breaks. -Todd On Thu, Jul 24, 2014 at 5:32 PM, Tong Shen endlessr...@google.com wrote: Hi Jason, I don't have

Re: [Lldb-commits] Possible UnwindAssembly-x86 Problem Fix

2014-07-24 Thread Todd Fiala
:-) On Thu, Jul 24, 2014 at 5:34 PM, Tong Shen endlessr...@google.com wrote: Thanks Todd! On Thu, Jul 24, 2014 at 5:33 PM, Todd Fiala tfi...@google.com wrote: Hey Tong - I'll add that and do all the test runs. I'll get it checked in unless something breaks. -Todd On Thu, Jul 24,

[Lldb-commits] [lldb] r213914 - Fix an x86 assembler stack unwind calculation for non-volatile registers.

2014-07-24 Thread Todd Fiala
Author: tfiala Date: Thu Jul 24 20:15:34 2014 New Revision: 213914 URL: http://llvm.org/viewvc/llvm-project?rev=213914view=rev Log: Fix an x86 assembler stack unwind calculation for non-volatile registers. This change has the practical effect of fixing some backtrace scenarios that would fail