Oh, by the way, you also have to add this API to the equivalent .i file
(./scripts/Python/interface/SBTarget.i) or it won't show up in Python.
Jim
On Sep 19, 2014, at 9:25 AM, jing...@apple.com wrote:
You can't do it this way, because it changes a public API, which we promised
not to do.
On Fri, 19 Sep 2014 18:25:54 +0200, jing...@apple.com wrote:
You can't do it this way, because it changes a public API, which we
promised not to do. You have to add an API instead. Given that, maybe
we want to add an enum to specify the textual match type, analogous to
the search type
I think the enum you added goes in lldb-enumerations.h not in SBTarget.h.
Also, I wouldn't use the regex match for the straight match, since that is much
less efficient than the ConstString ==, which is just a pointer compare. In
the fullness of time, we would retire the version that doesn't
Author: tfiala
Date: Fri Sep 19 13:27:45 2014
New Revision: 218133
URL: http://llvm.org/viewvc/llvm-project?rev=218133view=rev
Log:
Fix typo in Linux ASLR logging.
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp
On Fri, 19 Sep 2014 20:18:51 +0200, jing...@apple.com wrote:
I think the enum you added goes in lldb-enumerations.h not in
SBTarget.h.
Ah yes.
Also, I wouldn't use the regex match for the straight match, since that
is much less efficient than the ConstString ==, which is just a pointer
Author: carlokok
Date: Fri Sep 19 14:38:19 2014
New Revision: 218140
URL: http://llvm.org/viewvc/llvm-project?rev=218140view=rev
Log:
Adds two new functions to SBTarget FindGlobalVariables and FindGlobalFunctions
that lets you search by name, by regular expression and by starts with.
Modified:
Author: carlokok
Date: Fri Sep 19 15:12:24 2014
New Revision: 218147
URL: http://llvm.org/viewvc/llvm-project?rev=218147view=rev
Log:
Fix for 218140 for SBTarget.i, the added functions were in the wrong class
definition
Modified:
lldb/trunk/scripts/Python/interface/SBTarget.i
Modified:
Author: gclayton
Date: Fri Sep 19 15:11:50 2014
New Revision: 218145
URL: http://llvm.org/viewvc/llvm-project?rev=218145view=rev
Log:
Test suite runs better again after recent fixes that would select a platform if
a file a.out auto selected a different platform than the selected one.
Changes
Author: zturner
Date: Fri Sep 19 15:12:32 2014
New Revision: 218148
URL: http://llvm.org/viewvc/llvm-project?rev=218148view=rev
Log:
Make sure to #include atomic when using std::atomic.
Modified:
lldb/trunk/include/lldb/Core/Communication.h
Maybe this looks better?
http://reviews.llvm.org/D5374
Files:
source/Interpreter/CommandObject.cpp
Index: source/Interpreter/CommandObject.cpp
===
--- source/Interpreter/CommandObject.cpp
+++ source/Interpreter/CommandObject.cpp
Looks good to me! Anyone else?
On Sep 19, 2014, at 1:40 PM, Paul Osmialowski paw...@king.net.pl wrote:
Maybe this looks better?
http://reviews.llvm.org/D5374
Files:
source/Interpreter/CommandObject.cpp
D5374.13888.patch___
lldb-commits
Looks good to me! Anyone else?
http://reviews.llvm.org/D5374
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
This looks good to me.
http://reviews.llvm.org/D5374
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Yep good here too.
On Fri, Sep 19, 2014 at 2:55 PM, Ed Maste ema...@freebsd.org wrote:
This looks good to me.
http://reviews.llvm.org/D5374
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
Author: jingham
Date: Fri Sep 19 16:56:45 2014
New Revision: 218156
URL: http://llvm.org/viewvc/llvm-project?rev=218156view=rev
Log:
We had to squirrel away the dyld module before doing ResolveExecutableModule,
since
that would clear the module list, and then put it back by hand. But we forgot
+greg. Any chance you guys are willing to create Phabricator accounts?
Even if you don't use it to submit reviews, it's nice to just be able to
type your name into the website and have it include you in the original
email automatically.
On Fri, Sep 19, 2014 at 1:51 PM, Zachary Turner
Author: jingham
Date: Fri Sep 19 16:58:45 2014
New Revision: 218157
URL: http://llvm.org/viewvc/llvm-project?rev=218157view=rev
Log:
Fix a thinko in how the RemoteiOS Platform looked up files in the SDK other
platform locations. We didn't always do an exhaustive search through all the
platform
17 matches
Mail list logo
