Re: [Lldb-commits] [PATCH] test: ignore IOError in Base.deletePexpectChild and clean TestMySyntax test

Hello Abid, Cleanup didn't help and I got the error again: {code} == ERROR: test_lldbmi_eval (TestMiEvaluate.MiEvaluateTestCase) Test that 'lldb-mi --interpreter' works for evaluating.

Re: [Lldb-commits] [PATCH] test: ignore IOError in Base.deletePexpectChild and clean TestMySyntax test

Hello, One more test failed: {code} == ERROR: test_lldbmi_sourceoption (TestMiStartupOptions.MiStartupOptionsTestCase) Test that 'lldb-mi --interpreter' can execute a prepared file which passed via --source option.

Re: [Lldb-commits] [PATCH] UriParser - fixed potential buffer overrun

REPOSITORY rL LLVM Comment at: /Users/vharron/ll/svn/lldb/source/Utility/UriParser.cpp:42 @@ -42,1 +41,3 @@ +char* end = nullptr; int port_tmp = strtoul(port_buf, end, 10); +if (*end != 0 || port_tmp 65535) You may define port_tmp as auto instead

Re: [Lldb-commits] [PATCH] Add support for character option types

ping. Also +clayborg just in case he's also interested in this. http://reviews.llvm.org/D6887 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] minor refactoring to remove unneeded/unspecific header files

REPOSITORY rL LLVM http://reviews.llvm.org/D6919 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] UriParser - fixed potential buffer overrun

I would prefer this to use Args::StringToUInt32() instead of a manual call to strtoul() from #include lldb/Interpreter/Args.h (even though the correct usage of strtoul() is used here). This helps abstract us from the host we are running on in case there is no strtoul() and also leads me to the

[Lldb-commits] [lldb] r225651 - More [-Werror, -Winconsistent-missing-override] fixes.

Author: echristo Date: Mon Jan 12 13:09:48 2015 New Revision: 225651 URL: http://llvm.org/viewvc/llvm-project?rev=225651view=rev Log: More [-Werror,-Winconsistent-missing-override] fixes. Modified: lldb/trunk/include/lldb/Interpreter/CommandObjectRegexCommand.h Modified:

Re: [Lldb-commits] [PATCH] Add Socket::Get[Remote/Local]IpAddress and unit tests

The other option is to move all static Args::StringTo* calls into the Host layer at an appropriate place. Changes should be: - please use Args::StringTo calls instead of manual strtoul() calls so we have a common codebase and so people don't start using strtoul() on their own in other places

Re: [Lldb-commits] [PATCH] Add support for character option types

This seems fine to me. http://reviews.llvm.org/D6887 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Add support for character option types

REPOSITORY rL LLVM http://reviews.llvm.org/D6887 Files: lldb/trunk/include/lldb/Interpreter/Args.h lldb/trunk/include/lldb/Interpreter/OptionValue.h lldb/trunk/include/lldb/Interpreter/OptionValueChar.h lldb/trunk/include/lldb/Interpreter/OptionValues.h

[Lldb-commits] [PATCH] Fix XCode build on OSX - add OptionValueChar.cpp

Hi zturner, jingham, OptionValueChar.cpp doesn't exist in LLDB XCode project file that is causing OSX build to fail. http://reviews.llvm.org/D6941 Files: lldb.xcodeproj/project.pbxproj Index: lldb.xcodeproj/project.pbxproj ===

[Lldb-commits] [lldb] r225748 - Don't run functionalities/tty under sudo / as root.

Author: jmolenda Date: Mon Jan 12 18:54:59 2015 New Revision: 225748 URL: http://llvm.org/viewvc/llvm-project?rev=225748view=rev Log: Don't run functionalities/tty under sudo / as root. The terminal window will be opened under the ownership of the real userid and it won't be able to open the

[Lldb-commits] [PATCH] Add a global setting for the interpreter's escape-character

Hi clayborg, jingham, This enables Windows to specify paths with backslashes unquoted and fixes many tests as a result. We don't always have control over what type of slashes a path built in python has. For example if os.join() is used it will use backslashes. or if os.path.separator is

[Lldb-commits] [lldb] r225770 - Change the x86 assembly instruction unwind parser to

Author: jmolenda Date: Tue Jan 13 00:04:04 2015 New Revision: 225770 URL: http://llvm.org/viewvc/llvm-project?rev=225770view=rev Log: Change the x86 assembly instruction unwind parser to step through the complete function looking for any epilogue instructions. If we find an epilogue sequence,

[Lldb-commits] [lldb] r225771 - Add an additional check to UnwindAssembly_x86::AugmentUnwindPlanFromCallSite

Author: jmolenda Date: Tue Jan 13 00:07:07 2015 New Revision: 225771 URL: http://llvm.org/viewvc/llvm-project?rev=225771view=rev Log: Add an additional check to UnwindAssembly_x86::AugmentUnwindPlanFromCallSite which will verify if the eh_frame instructions include details about the prologue or

[Lldb-commits] [lldb] r225773 - Enhance the eh_frame unwind instruction augmenter so that

Author: jmolenda Date: Tue Jan 13 01:39:03 2015 New Revision: 225773 URL: http://llvm.org/viewvc/llvm-project?rev=225773view=rev Log: Enhance the eh_frame unwind instruction augmenter so that it will do the right thing on x86 routines with a mid-function epilogue sequence (where the unwind rules

Re: [Lldb-commits] [PATCH] test: ignore IOError in Base.deletePexpectChild and clean TestMySyntax test

It seems that your 2nd patch is needed. I will look at it tomorrow. Thanks, Abid From: Ilia K [mailto:ki.s...@gmail.com] Sent: 12 January 2015 13:27 To: Abid, Hafiz Cc: lldb-commits@cs.uiuc.edu Subject: Re: [Lldb-commits] [PATCH] test: ignore IOError in Base.deletePexpectChild and clean