Ah, thanks for the info. Feel free to fix the gdbremote_testcase.py however you
have to. My comments stand for the SP value in TestChangeValueAPI.py.
Repository:
rL LLVM
http://reviews.llvm.org/D10954
___
lldb-commits mailing list
On Tue, Apr 28, 2015 at 1:55 PM, Nico Weber tha...@chromium.org wrote:
Comment at: cmake/LLDBDependencies.cmake:100
@@ +99,3 @@
+if ( CMAKE_SYSTEM_NAME MATCHES Darwin )
+ set(LLDB_VERS_GENERATED_FILE ${LLDB_BINARY_DIR}/source/LLDB_vers.c)
+ add_custom_command(OUTPUT
Seems like StringExtractor.h wasn't actually needed in ProcessKDP.h so it
should have been removed from there instead of from the .cpp file.
Repository:
rL LLVM
http://reviews.llvm.org/D10995
___
lldb-commits mailing list
clayborg accepted this revision.
This revision is now accepted and ready to land.
So the reason we originally involved the platform is that you might want to
select a different platform (like a simulator platform) and have it create its
own NativeProcess (I concede that the NativeProcess is
Author: tberghammer
Date: Tue Jul 7 04:11:59 2015
New Revision: 241569
URL: http://llvm.org/viewvc/llvm-project?rev=241569view=rev
Log:
Leave OS as unspecified unknown if it isn't specified in the ELF file
This is the redone of r238623 what was reverted with the refactor
in r239148.
labath added a subscriber: labath.
Comment at: test/tools/lldb-server/gdbremote_testcase.py:1261-1266
@@ -1260,2 +1260,8 @@
self.assertTrue(state_reached)
+expected_step_count = 1
+arch = self.getArchitecture()
+
+#MIPS required 3 (ADDIU, SB, LD)
labath accepted this revision.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D10974
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
emaste closed this revision.
http://reviews.llvm.org/rL222372
http://reviews.llvm.org/D6240
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Greg, please respond. Again, the solution you proposed will not work, because
the language is unknown until the DWARF is read. This patch has minimal impact
on implementations for which this is not an issue, yet is critical, as it
allows us to support Delphi and C++ in the same binary.
ping?
http://reviews.llvm.org/D6240
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
ping?
http://reviews.llvm.org/D9104
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
http://reviews.llvm.org/rL222541
http://reviews.llvm.org/D6348
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
On Tue, Jul 7, 2015 at 11:25 PM, Nico Weber tha...@chromium.org wrote:
On Tue, Apr 28, 2015 at 1:55 PM, Nico Weber tha...@chromium.org wrote:
Comment at: cmake/LLDBDependencies.cmake:100
@@ +99,3 @@
+if ( CMAKE_SYSTEM_NAME MATCHES Darwin )
+ set(LLDB_VERS_GENERATED_FILE
I understand demangling just fine, I just don't like the way this patch adds
functions that shouldn't need to exist. No one should be removing a mangling
and replacing with another by patching up function names after they have been
demangled.
I don't know how you can claim we don't know the
Author: gclayton
Date: Tue Jul 7 16:27:08 2015
New Revision: 241628
URL: http://llvm.org/viewvc/llvm-project?rev=241628view=rev
Log:
Fix debugserver build after someone moved StrintExtractor.h.
Modified:
lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj
ovyalov added a reviewer: labath.
ovyalov added a subscriber: lldb-commits.
Ran 5K iterations in debug and release configurations - tests didn't stuck.
Let's give it a try to build bot.
http://reviews.llvm.org/D11013
Files:
test/functionalities/process_attach/TestProcessAttach.py
Index:
brucem added reviewers: labath, clayborg.
brucem added a subscriber: lldb-commits.
Fix StringExtractor.h issues.
* source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
(#include Utility/StringExtractor.h): Not needed, this is already
included by ProcessKDP.h
*
This doesn't address the issue with debugserver which may be a more
controversial fix.
http://reviews.llvm.org/D10995
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL241596: Fix StringExtractor.h issues. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D10995?vs=29180id=29182#toc
Repository:
rL LLVM
http://reviews.llvm.org/D10995
Files:
Author: brucem
Date: Tue Jul 7 10:19:03 2015
New Revision: 241596
URL: http://llvm.org/viewvc/llvm-project?rev=241596view=rev
Log:
Fix StringExtractor.h issues.
Summary:
Fix StringExtractor.h issues.
* source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
(#include Utility/StringExtractor.h):
clayborg accepted this revision.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D11018
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
Move ProcessKDP's StringExtractor include.
http://reviews.llvm.org/D11018
Files:
source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h
Index:
Author: brucem
Date: Tue Jul 7 18:59:01 2015
New Revision: 241649
URL: http://llvm.org/viewvc/llvm-project?rev=241649view=rev
Log:
Move ProcessKDP's StringExtractor include.
This can be in the cpp file rather than the header file, so moving
it there.
Summary: Move ProcessKDP's StringExtractor
chaoren accepted this revision.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11014
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL241649: Move ProcessKDP's StringExtractor include. (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D11018?vs=29223id=29224#toc
Repository:
rL LLVM
Author: spyffe
Date: Tue Jul 7 19:13:49 2015
New Revision: 241651
URL: http://llvm.org/viewvc/llvm-project?rev=241651view=rev
Log:
Fixed the C modules test case on Darwin by streamlining its code.
We don't need to do the fancy dance with checking whether the iterator
represents a #define -- in
Author: jingham
Date: Tue Jul 7 17:12:17 2015
New Revision: 241632
URL: http://llvm.org/viewvc/llvm-project?rev=241632view=rev
Log:
Add a version of SBTarget::EvaluateExpression that doesn't require
an options (and makes an appropriate defaulted option for you.)
rdar://problem/20639202
Author: jingham
Date: Tue Jul 7 19:06:30 2015
New Revision: 241650
URL: http://llvm.org/viewvc/llvm-project?rev=241650view=rev
Log:
Don't select a thread that stopped for a signal that was
not set to stop - there must be some other thread that
stopped for a more interesting reason.
Friendly ping.
http://reviews.llvm.org/D10882
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: labath
Date: Tue Jul 7 07:08:09 2015
New Revision: 241575
URL: http://llvm.org/viewvc/llvm-project?rev=241575view=rev
Log:
LLDB standalone build: check if Clang was built independently from LLVM
This is fix for bug 23704: LLDB standalone build always include
ClangConfig.cmake even if
I have made changes to lldb to follow the recent interface changes of
clang. lldb now (at least) compiles, but I have very little knowledge
of this part of code, so I would appreciate it if someone could review
and/or fix this.
On 7 July 2015 at 11:11, Pavel Labath lab...@google.com wrote:
Author: jingham
Date: Tue Jul 7 19:59:59 2015
New Revision: 241652
URL: http://llvm.org/viewvc/llvm-project?rev=241652view=rev
Log:
Make command files specified to the driver actually print their
results if the -Q option is not provided. Also took out the quietly
option from AddInitialCommand,
Thank you very much for your reply.
Consider the following.
Suppose we have the following source written in Delphi that we want to debug
(translated to C++ here for the purposes of explaination):
#include stdio.h
namespace ns {
int func(int i) {
return ++i;
}
}
int
I understand demangling just fine, I just don't like the way this patch adds
functions that shouldn't need to exist. No one should be removing a mangling
and replacing with another by patching up function names after they have been
demangled.
I wish there were another way, alas lldb's
Author: brucem
Date: Tue Jul 7 09:04:40 2015
New Revision: 241585
URL: http://llvm.org/viewvc/llvm-project?rev=241585view=rev
Log:
[lldb-mi] Fix typos
Modified:
lldb/trunk/tools/lldb-mi/MICmdArgSet.h
lldb/trunk/tools/lldb-mi/MICmdBase.cpp
lldb/trunk/tools/lldb-mi/MICmdBase.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL241586: [lldb-mi] Fix typo in variable name. (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D10992?vs=29170id=29171#toc
Repository:
rL LLVM
http://reviews.llvm.org/D10992
Author: brucem
Date: Tue Jul 7 09:52:59 2015
New Revision: 241590
URL: http://llvm.org/viewvc/llvm-project?rev=241590view=rev
Log:
cmake no longer needs to deal with -std=c++11 checks.
LLVM requires and handles this now and has the correct compiler
version checks. This block of code for cmake
brucem added reviewers: abidh, ki.stfu.
brucem added a subscriber: lldb-commits.
[lldb-mi] Spell resource string name correctly.
http://reviews.llvm.org/D10993
Files:
tools/lldb-mi/MICmnLLDBDebugger.cpp
tools/lldb-mi/MICmnResources.cpp
tools/lldb-mi/MICmnResources.h
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL241591: [lldb-mi] Spell resource string name correctly.
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D10993?vs=29173id=29178#toc
Repository:
rL LLVM
Author: brucem
Date: Tue Jul 7 09:54:07 2015
New Revision: 241591
URL: http://llvm.org/viewvc/llvm-project?rev=241591view=rev
Log:
[lldb-mi] Spell resource string name correctly.
Broardcaster - Broadcaster
Summary: [lldb-mi] Spell resource string name correctly.
Reviewers: abidh, ki.stfu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL241590: cmake no longer needs to deal with -std=c++11
checks. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D10994?vs=29174id=29177#toc
Repository:
rL LLVM
41 matches
Mail list logo
