dawn created this revision.
dawn added reviewers: clayborg, spyffe, zturner.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
The main purpose of this patch is to be able to get the frame's context
(instead of just the target's) when evaluating, so
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will defer to Sean Callanan.
Repository:
rL LLVM
http://reviews.llvm.org/D11102
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
This broke the build on OSX Mavericks (appears to work fine on Yosemite).
After this commit, the lldb build now fails with:
...
../tools/lldb/tools/debugserver/source/MacOSX/MachTask.mm:452:41:
dawn added a subscriber: lldb-commits.
Users:
zturner (Author)
dawn (Auditor)
http://reviews.llvm.org/rL238467
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
dawn added a subscriber: lldb-commits.
http://reviews.llvm.org/rL240728
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
dawn raised a concern with this commit.
dawn added a comment.
This is still an issue. We are still seeing a drop of ~550 in the total number
of tests run since this commit. Please have a look? Thanks.
Users:
zturner (Author)
dawn (Auditor)
http://reviews.llvm.org/rL238467
chaoren added a comment.
It would be nice from the standpoint that you might be able to grab a copy of
them and modify them before any processes are launched, but I don't see us
doing any of this anywhere so I would rather avoid it until we do.
We do this in the gdb remote tests. I added
Author: spyffe
Date: Fri Jul 10 12:34:23 2015
New Revision: 241917
URL: http://llvm.org/viewvc/llvm-project?rev=241917view=rev
Log:
Fixed a problem where variables in modules were not appropriately discovered by
the expression parser.
rdar://problem/21395220
Modified:
Author: gclayton
Date: Fri Jul 10 13:04:46 2015
New Revision: 241919
URL: http://llvm.org/viewvc/llvm-project?rev=241919view=rev
Log:
Don't try to make a pseudo terminal if we are launching in a separate terminal,
it causes a deadlock when debugging because we create a PTY and yet it isn't
chaoren added inline comments.
Comment at: include/lldb/API/SBUnixSignals.h:68
@@ -67,2 +67,3 @@
friend class SBProcess;
+SBUnixSignals(const lldb::ProcessSP process_sp);
labath wrote:
You are changing the public API here. We are maintaining binary
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So what is the overall goal of this patch? I am assuming the jist of this patch
is to just get the JSON packet to get unix signals from the remote GDB server.
The following
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I am fine with this part of the patch since it doesn't introduce any changes
and most of the threading issues seem to be with the ProcessMonitor if I
understood your comments correctly.
Note, there is a document that describes the rules for coding the SB API's:
http://lldb.llvm.org/SB-api-coding-rules.html
if there's something there that isn't clear, feel free to clarify the text
there...
Jim
On Jul 10, 2015, at 9:45 AM, Greg Clayton clayb...@gmail.com wrote:
A quick
Author: jmolenda
Date: Fri Jul 10 18:15:22 2015
New Revision: 241964
URL: http://llvm.org/viewvc/llvm-project?rev=241964view=rev
Log:
Add a another packet to the gdb-remote protocol,
jGetLoadedDynamicLibrariesInfos. This packet is similar to
qXfer:libraries:read except that lldb supplies the
jingham added a subscriber: jingham.
jingham added a comment.
Note, there is a document that describes the rules for coding the SB API's:
http://lldb.llvm.org/SB-api-coding-rules.html
if there's something there that isn't clear, feel free to clarify the text
there...
Jim
15 matches
Mail list logo
