Author: ewancrawford
Date: Fri Jul 24 05:01:11 2015
New Revision: 243104
URL: http://llvm.org/viewvc/llvm-project?rev=243104view=rev
Log:
Initialize variable to prevent garbage values (RenderScriptRuntime)
The kernels_found variable is not initialized, so if it is not assigned true on
line 823,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL243104: Initialize variable to prevent garbage values
(RenderScriptRuntime) (authored by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D11323?vs=30064id=30567#toc
Repository:
rL
neilparikh added a comment.
That site says that commit access is granted after a few patches. This is my
first patch, so it seems like I need to get someone else commit it for me
(based on how I interpreted that page). If that's the case, could you commit
this?
Repository:
rL LLVM
dawn updated this revision to Diff 30600.
dawn added a comment.
Changed test to use SB APIs.
Repository:
rL LLVM
http://reviews.llvm.org/D11447
Files:
source/Commands/CommandObjectExpression.cpp
source/Commands/CommandObjectExpression.h
test/expression_command/options/Makefile
dawn updated this revision to Diff 30609.
dawn added a comment.
Comment about ::func syntax not working in lldb added as requested. Please
accept this patch - it fixes namespace tokens used in lldb-mi breakpoints like
-break-insert ns::func. Patches to lldb and other issues are not intended
dawn updated this revision to Diff 30602.
Repository:
rL LLVM
http://reviews.llvm.org/D11482
Files:
include/lldb/Target/Target.h
source/Commands/CommandObjectExpression.cpp
source/Target/Target.cpp
test/expression_command/options/main.cpp
Author: gclayton
Date: Fri Jul 24 11:55:00 2015
New Revision: 243118
URL: http://llvm.org/viewvc/llvm-project?rev=243118view=rev
Log:
Bind to the loopback when we are expecting a connection from 127.0.0.1 so we
don't set off firewall protections.
rdar://problem/17897318
Modified:
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Please use SB API calls for expression evaluation instead of self.expect calls.
Comment at: test/expression_command/options/TestExprOptions.py:57-87
@@ +56,33
On Jul 24, 2015, at 10:19 AM, Zachary Turner ztur...@google.com wrote:
zturner added a comment.
Hi Greg,
I wonder if this has something to do with the fact that the SWIG generation
shell script is one of the build phases of LLDB.Framework as you mentioned
once before here:
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I think it is fine to add support for looking at the target.language and using
it if set, but I don't think we need a target.language-follows-frame setting
at all. We should
jasonmolenda closed this revision.
jasonmolenda added a comment.
Sendingsource/Host/common/Socket.cpp
Transmitting file data .
Committed revision 243175.
Repository:
rL LLVM
http://reviews.llvm.org/D11497
___
lldb-commits mailing list
paulmaybee updated this revision to Diff 30590.
paulmaybee added a comment.
Add test case
http://reviews.llvm.org/D11488
Files:
test/tools/lldb-mi/variable/TestMiGdbSetShowPrint.py
test/tools/lldb-mi/variable/main.cpp
tools/lldb-mi/MICmnLLDBUtilSBValue.cpp
granata.enrico added a subscriber: granata.enrico.
granata.enrico added a comment.
I am assuming that your intent is:
int x = 1;
int y = 1;
(lldb) frame variable y
(int) y = 0x123456 (y = 1)
If so, two things:
a) a much better way would be to make FormatManager::ShouldPrintAsOneLiner()
decide
Author: dperchik
Date: Fri Jul 24 19:19:39 2015
New Revision: 243187
URL: http://llvm.org/viewvc/llvm-project?rev=243187view=rev
Log:
Specify a language to use when parsing expressions.
This patch adds the option -l/--language to the expression command, for
use when setting the language options
This revision was automatically updated to reflect the committed changes.
Closed by commit rL243187: Specify a language to use when parsing expressions.
(authored by dperchik).
Changed prior to commit:
http://reviews.llvm.org/D11447?vs=30600id=30626#toc
Repository:
rL LLVM
Author: jmolenda
Date: Fri Jul 24 21:39:42 2015
New Revision: 243200
URL: http://llvm.org/viewvc/llvm-project?rev=243200view=rev
Log:
Add some initial logging for when lldb is searching for binaries,
dSYMs, or reading binaries out of memory to the 'Host' log channel.
There's more to be done here,
dawn created this revision.
dawn added reviewers: abidh, brucem, ki.stfu.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
Given eBreakPoint_ByFileFn, code previously was calling:
sbTarget.BreakpointCreateByName(strFileFn.c_str(), fileName.c_str());
Author: jingham
Date: Fri Jul 24 19:52:38 2015
New Revision: 243193
URL: http://llvm.org/viewvc/llvm-project?rev=243193view=rev
Log:
Shorten the lldb timeout, we were seeing occasional failure because
lldb didn't wake up before the target function got a chance to complete.
dawn added a comment.
Thank you for your review. I was afraid you might not go for it since you
objected to my original frame-based patch for breakpoints, but I had hoped that
by having it in an option you would be OK with it. Our users (with mixed Pascal
and C++ code) really want this so
dawn added a comment.
PS: I hope you won't return ObjC++ if language is unknown for any of the code
you write - see inline comment.
PPS: Many thanks again for all your reviews!!
Comment at: source/Target/Target.cpp:2158-2178
@@ -2136,1 +2157,23 @@
+// Return the language
20 matches
Mail list logo