Re: [Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

2014-09-12 Thread Alexey Samsonov
Getting closer. Comment at: lib/asan/asan_debugging.cc:35 @@ +34,3 @@ + descr-name[0] = 0; + internal_strncat(descr-name, vars[i].name_pos, + Min(descr-name_size, vars[i].name_len)); Why not internal_strncpy(descr-name,

Re: [Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

2014-09-12 Thread Alexey Samsonov
! In D4527#31, @kubabrecka wrote: Getting closer. Thanks for the patience :) Why not internal_strncpy(descr-name, vars[i].name_pos, Min(descr-name_size - 1, vars[i].name_len)) ? Because that would not write \0 after the string (we're copying just a part of the string pointed to by

Re: [Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

2014-09-11 Thread Alexey Samsonov
Comment at: lib/asan/asan_debugging.cc:38 @@ +37,3 @@ +uptr var_name_len = vars[i].name_len; +if (vars[i].name_len name_size - 1) var_name_len = name_size - 1; +memcpy(name, vars[i].name_pos, var_name_len); internal_strncpy?

Re: [Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

2014-09-08 Thread Alexey Samsonov
Comment at: lib/asan/asan_globals.cc:85 @@ -84,2 +84,3 @@ -bool DescribeAddressIfGlobal(uptr addr, uptr size) { +bool DescribeOrGetInfoIfGlobal(uptr addr, uptr size, bool only_get_info, + char *name, uptr name_size, uptr *region_address,