Closed by commit rL222511 (authored by @sbest).
REPOSITORY
rL LLVM
http://reviews.llvm.org/D5837
Files:
lldb/trunk/test/api/multithreaded/TestMultithreaded.py
lldb/trunk/test/api/multithreaded/test_listener_event_description.cpp
Index:
Author: sbest
Date: Fri Nov 21 00:49:39 2014
New Revision: 222511
URL: http://llvm.org/viewvc/llvm-project?rev=222511view=rev
Log:
fix Bug21211 : reworked
test/api/multithreaded/test_listener_event_description.cpp to work properly on
Linux/FreeBSD
Issue D5632 fixed an issue where linux would
I can confirm the two issues you cite also started failing on linux
around the time of this changes. Greg's checkin yesterday fixed
TestCommandRegex, but TestGlobalVariables is still failing.
On 11/17/2014 11:46 AM, Ed Maste wrote:
On 17 November 2014 14:07, Kate Stone
Author: sbest
Date: Fri Nov 14 13:41:33 2014
New Revision: 222031
URL: http://llvm.org/viewvc/llvm-project?rev=222031view=rev
Log:
add Makefile rule for test program CREATE_STD_THREADS
Effectively removes -lpthreads from linux/gcc build of test programs in
test/api/multithreaded. This was done
Closed by commit rL222031 (authored by @sbest).
REPOSITORY
rL LLVM
http://reviews.llvm.org/D5838
Files:
lldb/trunk/test/api/multithreaded/Makefile
lldb/trunk/test/make/Makefile.rules
Index: lldb/trunk/test/api/multithreaded/Makefile
friendly ping. I was waiting until the other change (D5838 ENABLE_STD_THREADS)
landed and I could run the tests in api/multithreaded again. This is a rework
of the test program logic to accommodate the fact that OSx and linux broadcast
a different sequence of public events due to their
I have added another flag to test/Makefile.rules ENABLE_STD_THREADS and used it
the api/Multithreaded unit tests. This can be used to selectively omit
'-lpthreads' option for certain systems. All platforms except linux/gcc should
behave as before.
I have also made a Bugzilla report for
Author: sbest
Date: Tue Nov 11 11:34:58 2014
New Revision: 221692
URL: http://llvm.org/viewvc/llvm-project?rev=221692view=rev
Log:
Substitute cc with c++ when compiling c++ test files for Siva Chandra :
http://reviews.llvm.org/D6199
Modified:
lldb/trunk/test/make/Makefile.rules
Modified:
Author: sbest
Date: Tue Nov 11 11:45:00 2014
New Revision: 221694
URL: http://llvm.org/viewvc/llvm-project?rev=221694view=rev
Log:
Add -std=c99 for building the test case of TestValueVarUpdate - for Siva
Chandra : http://reviews.llvm.org/D6201
Modified:
Author: sbest
Date: Mon Nov 10 09:06:15 2014
New Revision: 221593
URL: http://llvm.org/viewvc/llvm-project?rev=221593view=rev
Log:
LLGS Android target support (r221570) missed adding some files:
http://reviews.llvm.org/D6166
Added:
lldb/trunk/cmake/
Hi granata.enrico,
R220718 changed the path libtest.py goes looking for the file LLDB.h. This
will cause all unit tests decorated with @skipIfNoSBHeaders to skip the test
on linux (and I suspect all non-Apple platforms).
http://reviews.llvm.org/D6177
Files:
test/lldbtest.py
Index:
Author: sbest
Date: Fri Nov 7 19:41:49 2014
New Revision: 221570
URL: http://llvm.org/viewvc/llvm-project?rev=221570view=rev
Log:
LLGS Android target support - for Andy Chien : http://reviews.llvm.org/D6166
Modified:
lldb/trunk/CMakeLists.txt
Author: sbest
Date: Thu Nov 6 11:52:15 2014
New Revision: 221467
URL: http://llvm.org/viewvc/llvm-project?rev=221467view=rev
Log:
fixed minor code indenting http://reviews.llvm.org/D6127
Modified:
lldb/trunk/test/lldbtest.py
Modified: lldb/trunk/test/lldbtest.py
URL:
Builds and runs fine on OSX/clang as well as Linux/gcc. I will go ahead
and commit.
On 11/4/2014 1:14 PM, Enrico Granata wrote:
Did you check if this compiles with both GCC and clang?
If it compiles with both, I have no objection to it
It's unfortunate to hit such GCC limitations every so
Author: sbest
Date: Tue Nov 4 18:58:55 2014
New Revision: 221324
URL: http://llvm.org/viewvc/llvm-project?rev=221324view=rev
Log:
for Oleksiy Vyalov - Redirect stdin, stdout and stderr to /dev/null when
launching LLGS process. Differential Revision: http://reviews.llvm.org/D6105
Modified:
Author: sbest
Date: Fri Oct 31 13:18:23 2014
New Revision: 220983
URL: http://llvm.org/viewvc/llvm-project?rev=220983view=rev
Log:
commit on behalf of Oleksiy Vyalov Fix junk content handling within
GDBRemoteCOmmunication::CheckForPacket 1. Avoid removing of an extra symbol
from m_bytes. 2.
R220956 broke lldb TOT. In the file clang/include/clang/AST/Decl.h, there were
some typedef's inside VarDecl, FunctionDecl classes mapping clang::StorageClass
to StorageClass. R220956 removed these typedefs.
In ClangASTContext.cpp, there were a few places using the old typedefs so I
switched
Hey Oleksiy, can you rebase the patch for me, I got HUNK Failed when applying.
It could be related to the whitespace stripping you did for Greg. Also, I
notice something weird with the block of code you wrapped with the while()
loop. It appears to be indented only 2 spaces instead of 4.
Author: sbest
Date: Wed Oct 22 14:29:00 2014
New Revision: 220406
URL: http://llvm.org/viewvc/llvm-project?rev=220406view=rev
Log:
Sort unit test failures by name - submitted for Vince Harron
http://reviews.llvm.org/D5904
Modified:
lldb/trunk/test/dosep.py
Modified:
Hi emaste,
Issue D5632 fixed an issue where linux would dump spurious output to tty on
startup (due to a broadcast stop event). After the checkin, it was noticed on
FreeBSD a unit test was now failing. On closer investigation I found the test
was using the C++ API to launch an inferior while
This flag triggers a '-lpthead' during the linking stage. Technically this is
not needed since the multithreading is handled by std library, triggered by
'-std=c++11' in build command line.
The **real** reason I want to remove the '-lpthread' is it was causing a
(linux/gcc built) test program
Author: sbest
Date: Tue Oct 7 20:50:37 2014
New Revision: 219269
URL: http://llvm.org/viewvc/llvm-project?rev=219269view=rev
Log:
Minor comment change to test out svn access
Modified:
lldb/trunk/source/Target/Process.cpp
Modified: lldb/trunk/source/Target/Process.cpp
URL:
Hi tfiala, clayborg,
I was tracking a problem where llgs on linux would not pick up any environment
variables. On OSX there is a virtual function PlatformDarwin::GetEnvironment()
which correctly sets up the list of environment variables. On linux llgs it
defaults to a base class default
There are several places where multiple threads are accessing the same
variables simultaneously without any kind of protection. I propose using
std::atomic to make it safer. I did a special build of lldb, using the
google tool 'thread sanitizer' which identified many cases of multiple threads
in such a
situation the main thread would be unnecessarily blocked.
What are your thoughts?
Matt
Shawn Best wrote:
Thanks for the feedback Greg. I have attached a revised patch based on
your suggestions.
- renamed m_pushed_IOHandler to m_iohandler_sync
- got rid of method
may need to add this
kind of logic piece-meal. It's not great, but with my limited view
of lldb's architecture, I can't currently think of a better way.
Matt
Shawn Best wrote:
Thanks for the feedback Greg. I have attached a revised patch
based on your suggestions.
- renamed
at
that.
Greg
On Jul 30, 2014, at 4:03 PM, Shawn Best sb...@blueshiftinc.com wrote:
I have reworked the patch to use std::condition_variable. This
particular sync mechanism was new to me, I hope I used it correctly. Is it
portable across all target platforms/compilers? I tested on linux and OSX
oops, with the attachment this time.
On Thu, Jul 31, 2014 at 2:56 PM, Shawn Best sb...@blueshiftinc.com wrote:
Thanks everyone for the feedback. I have reworked the patch to use
Predicate bool, it reads much cleaner now.
Shawn.
On Wed, Jul 30, 2014 at 6:34 PM, Greg Clayton gclay
made.
On Tue, Jul 29, 2014 at 9:58 PM, Matthew Gardiner m...@csr.com wrote:
Cool, let us know how you get on!
Matt
Shawn Best wrote:
Thanks for the feedback guys.
Studying the code, I had figured going with a straight int would in
practice be most efficient and not run into multi-threaded
29 matches
Mail list logo
