Re: [Lldb-commits] [PATCH] Add a --all command option to target delete

2015-03-26 Thread jingham
On Mar 25, 2015, at 6:06 PM, Zachary Turner ztur...@google.com wrote: Ironically even though I've been staring at this problem for 2 days I think I actually figured this out shortly after my last email. TestBase.tearDown() already deletes all the targets but it was calling Base.tearDown

Re: [Lldb-commits] [PATCH] Add a --all command option to target delete

2015-03-25 Thread Jim Ingham
I think it is worth mentioning in the help that if you do clean then you will need to reparse all shared modules the next time you debug. This can be a significant hiccup when you next debug... Can't think of a succinct way to say this off the top of my head, though... I try to use boolean

Re: [Lldb-commits] [PATCH] Add a --all command option to target delete

2015-03-25 Thread Zachary Turner
Seems reasonable, I can add something to the help. What do you think about also changing the semantics of --clean to clear the module list regardless of if the modules are orphaned? I've spent the past 2 days trying to track down a refcounting bug related to the shared module list that only

Re: [Lldb-commits] [PATCH] Add a --all command option to target delete

2015-03-25 Thread jingham
On Mar 25, 2015, at 5:18 PM, Zachary Turner ztur...@google.com wrote: Seems reasonable, I can add something to the help. What do you think about also changing the semantics of --clean to clear the module list regardless of if the modules are orphaned? I've spent the past 2 days trying