Re: [Lldb-commits] [PATCH] Improvement for lldb-gdb-remote.txt qHostInfo documentation

2014-07-29 Thread Matthew Gardiner
Guys, I'm going to limit the scope of my current work to just fixing the triple (i.e. change it to plaintext string encoding, and the revert documentation). I'm unclear of the intended encoding of the other items we'd mentioned. I'll come back to them later. Matt Todd Fiala wrote: On

Re: [Lldb-commits] [PATCH] Improvement for lldb-gdb-remote.txt qHostInfo documentation

2014-07-25 Thread Jason Molenda
Hi Matthew, If your stub implementation is not locked into hex encoding this triple string, let's change the lldb / stub implementation and the documentation. It's a mistake and I'd hate to propagate it further. Yeah, the - and + characters are used for ACK / NACK when a packet consists only

Re: [Lldb-commits] [PATCH] Improvement for lldb-gdb-remote.txt qHostInfo documentation

2014-07-25 Thread Matthew Gardiner
Hi Jason, Indeed my stub implementation does not rely on the hex/otherwise encoding of the triple. I'm happy to revert the patch and change the implementation in the GDBRemote code (probably not till next week, though). My main regret is not floating my patch on lldb-dev first, but I assumed

Re: [Lldb-commits] [PATCH] Improvement for lldb-gdb-remote.txt qHostInfo documentation

2014-07-25 Thread Todd Fiala
Hey Jason, I don’t know about llgs or how much work it would be to change the kalimba gdbserver stub. Currently GDBRemoteCommunicationServer, used by both llgs and lldb-platform, does send the triple as hex encoded via this code: response.PutCString(triple:);

Re: [Lldb-commits] [PATCH] Improvement for lldb-gdb-remote.txt qHostInfo documentation

2014-07-25 Thread Todd Fiala
Cool - sounds all good to me since we don't have a backwards compatibility problem. Now would be the time to do it :-) -Todd On Fri, Jul 25, 2014 at 12:40 PM, Jason Molenda ja...@molenda.com wrote: On Jul 25, 2014, at 7:08 AM, Todd Fiala tfi...@google.com wrote: Hey Jason, I don’t

Re: [Lldb-commits] [PATCH] Improvement for lldb-gdb-remote.txt qHostInfo documentation

2014-07-24 Thread Todd Fiala
My pleasure :-) On Wed, Jul 23, 2014 at 10:03 PM, Matthew Gardiner m...@csr.com wrote: Todd Fiala wrote: Done: svn commit Sendingdocs/lldb-gdb-remote.txt Transmitting file data . Committed revision 213756. Thanks again! Matt Member of the CSR plc group of companies. CSR

Re: [Lldb-commits] [PATCH] Improvement for lldb-gdb-remote.txt qHostInfo documentation

2014-07-24 Thread Jason Molenda
IMO we should change the implementation and the documentation for qHostInfo triple to not specify/use hex encoded strings. debugserver doesn't send triple. I don't know about llgs or how much work it would be to change the kalimba gdbserver stub. On Jul 24, 2014, at 1:39 PM, Jason Molenda

[Lldb-commits] [PATCH] Improvement for lldb-gdb-remote.txt qHostInfo documentation

2014-07-23 Thread Matthew Gardiner
Folks, When I first implemented the qHostInfo for the kalimba gdbserver stub, I sent the triple string as kalimba-csr-unknown. However the receiving code (GDBRemoteCommunicationClient) expects the string to be encoded as hex bytes, since '-' are a reserved GDB-RSP control character. The

Re: [Lldb-commits] [PATCH] Improvement for lldb-gdb-remote.txt qHostInfo documentation

2014-07-23 Thread Todd Fiala
Done: svn commit Sendingdocs/lldb-gdb-remote.txt Transmitting file data . Committed revision 213756. On Wed, Jul 23, 2014 at 6:23 AM, Matthew Gardiner m...@csr.com wrote: Folks, When I first implemented the qHostInfo for the kalimba gdbserver stub, I sent the triple string as

Re: [Lldb-commits] [PATCH] Improvement for lldb-gdb-remote.txt qHostInfo documentation

2014-07-23 Thread Matthew Gardiner
Todd Fiala wrote: Done: svn commit Sendingdocs/lldb-gdb-remote.txt Transmitting file data . Committed revision 213756. Thanks again! Matt Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill