Re: [Lldb-commits] [PATCH] Use SmallPtrSet in ClusterManager

2014-05-16 Thread Scott Knight
This did not ever get reviewed. I wasn't sure about the process after submitting the patch to phabricator. I have not run tests yet because I wasn't clear on that process either. The lldb website mentions using make to run tests but that's under the building on linux/freebsd section. Since I'm

Re: [Lldb-commits] [PATCH] Use SmallPtrSet in ClusterManager

2014-05-16 Thread Scott Knight
I did go ahead and run dotest.py this morning both before and after applying the patch and it seems to have the same 10 failures before and after like you mentioned. Another set of eyes checking the test results would be great though. http://reviews.llvm.org/D3616

Re: [Lldb-commits] [PATCH] Use SmallPtrSet in ClusterManager

2014-05-16 Thread Scott Knight
I do not have commit access so if someone who does could commit that would be great. Thanks, Scott Knight On May 16, 2014 3:26 PM, jing...@apple.com wrote: I got the same result. This patch is much more likely to cause crashes than failures if it was wrong, and I didn't see that either. And