LGTM
http://reviews.llvm.org/D5838
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Closed by commit rL222031 (authored by @sbest).
REPOSITORY
rL LLVM
http://reviews.llvm.org/D5838
Files:
lldb/trunk/test/api/multithreaded/Makefile
lldb/trunk/test/make/Makefile.rules
Index: lldb/trunk/test/api/multithreaded/Makefile
I have added another flag to test/Makefile.rules ENABLE_STD_THREADS and used it
the api/Multithreaded unit tests. This can be used to selectively omit
'-lpthreads' option for certain systems. All platforms except linux/gcc should
behave as before.
I have also made a Bugzilla report for
On FreeBSD the test fails to link without `-lpthread`:
```
os command: gmake clean
LD_EXTRAS='-L/tank/emaste/src/llvm/build-nodebug/bin/../lib/python2.7/site-packages/../..
-llldb' EXE='test_listener_event_description' CFLAGS_EXTRAS='-std=c++11
-stdlib=libc++
What do you think about an ENABLE_STD_THREADS := YES for these
That seems like a reasonable way to go. And we just work out in the
Makefile.rules what that needs to translate into.
On Fri, Oct 17, 2014 at 5:53 AM, Ed Maste ema...@freebsd.org wrote:
On FreeBSD the test fails to link without
This flag triggers a '-lpthead' during the linking stage. Technically this is
not needed since the multithreading is handled by std library, triggered by
'-std=c++11' in build command line.
The **real** reason I want to remove the '-lpthread' is it was causing a
(linux/gcc built) test program
