jaydeep added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1463-1465
@@ +1462,5 @@
+
+// If we don't get a response for $qC, check if $qfThreadID gives us a
result.
+if (m_curr_pid == LLDB_INVALID_PROCESS_ID && o
bhushan created this revision.
bhushan added a reviewer: clayborg.
bhushan added subscribers: lldb-commits, jaydeep, sagar, nitesh.jain,
mohit.bhakkad.
bhushan set the repository for this revision to rL LLVM.
This patch adds support of floating point and aggregate return types in
GetReturnValueO
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244573: Add size field to library load event (MI) (authored
by ki.stfu).
Changed prior to commit:
http://reviews.llvm.org/D11574?vs=31038&id=31772#toc
Repository:
rL LLVM
http://reviews.llvm.org/D11
Author: ki.stfu
Date: Tue Aug 11 01:07:14 2015
New Revision: 244573
URL: http://llvm.org/viewvc/llvm-project?rev=244573&view=rev
Log:
Add size field to library load event (MI)
Summary:
(This revision supersedes the abandon: http://reviews.llvm.org/D9716)
Size field is used to let the debugger att
jaydeep added a comment.
Could you please find some time to review this?
Thanks.
Repository:
rL LLVM
http://reviews.llvm.org/D11672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
jaydeep added a comment.
Could you please find some time to review this?
Thanks.
Repository:
rL LLVM
http://reviews.llvm.org/D11747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
I wouldn't be surprised if most of this is similar to the problem I emailed
yesterday ("TOT svn lldb crashes trying to print argc on TOT lldb, maybe
fallout from r244308 - [LLDB][MIPS] Fix offsets of all register sets and add
MSA regset and FRE=1 mode support") where lldb could hit an llvm APInt
ki.stfu added a comment.
In http://reviews.llvm.org/D11574#220627, @paulmaybee wrote:
> Can you please check in in for me. Thanks.
Ok, tomorrow.
http://reviews.llvm.org/D11574
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
chaoren updated this revision to Diff 31708.
chaoren added a comment.
Accidentally removed timed_out tests from failed tests.
http://reviews.llvm.org/D11910
Files:
test/dosep.py
Index: test/dosep.py
===
--- test/dosep.py
+++ tes
sas added a subscriber: sas.
sas accepted this revision.
sas added a reviewer: sas.
sas added a comment.
This revision is now accepted and ready to land.
Looks pretty good.
http://reviews.llvm.org/D11384
___
lldb-commits mailing list
lldb-commits@li
chaoren updated this revision to Diff 31703.
chaoren added a comment.
Rebase on top of http://reviews.llvm.org/rL244469.
http://reviews.llvm.org/D11843
Files:
test/dosep.py
Index: test/dosep.py
===
--- test/dosep.py
+++ test/dos
zturner added a comment.
lgtm
http://reviews.llvm.org/D11910
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
lgtm
On Mon, Aug 10, 2015 at 9:50 AM Chaoren Lin wrote:
> chaoren created this revision.
> chaoren added a reviewer: zturner.
> chaoren added a subscriber: lldb-commits.
>
> http://reviews.llvm.org/D11909
>
> Files:
> test/dosep.py
>
> Index: test/dosep.py
> ===
Author: zturner
Date: Mon Aug 10 12:46:11 2015
New Revision: 244469
URL: http://llvm.org/viewvc/llvm-project?rev=244469&view=rev
Log:
Allow dosep.py to print dotest.py output on success.
Previously all test output was reported by each individual
instance of dotest.py. After a recent patch, dosep
chaoren added a comment.
Zach, there were two more comments since the LGTM.
Comment at: test/dosep.py:1
@@ -1,2 +1,2 @@
-#!/usr/bin/env python
+#!/usr/bin/env python
chaoren wrote:
> I think you added a character here. Could you please double check
> before
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
http://reviews.llvm.org/D11846
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will defer to Tamas Berghammer since I have no expertise is arm64 watchpoints.
http://reviews.llvm.org/D11899
___
lldb-commits mailing list
lldb
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Init "watch_flags" to zero and this is good to go.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2230
@@ -2229,2 +2229,3 @@
zturner added a comment.
Chaoren, am I still missing any requested changes or is this good to go? I'm
not sure if some of your original concerns still stand after the latest
discussion.
http://reviews.llvm.org/D11816
___
lldb-commits mailing list
chaoren updated this revision to Diff 31683.
chaoren added a comment.
Rebase on top of http://reviews.llvm.org/D11910.
http://reviews.llvm.org/D11846
Files:
test/dosep.py
Index: test/dosep.py
===
--- test/dosep.py
+++ test/dosep
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will let Jim and Sean handle this one.
http://reviews.llvm.org/D11102
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as the code is using the LLDB coding style which I believe
has been addressed.
http://reviews.llvm.org/D10216
___
lldb-co
chaoren created this revision.
chaoren added a reviewer: zturner.
chaoren added a subscriber: lldb-commits.
http://reviews.llvm.org/D11910
Files:
test/dosep.py
Index: test/dosep.py
===
--- test/dosep.py
+++ test/dosep.py
@@ -153,1
chaoren created this revision.
chaoren added a reviewer: zturner.
chaoren added a subscriber: lldb-commits.
http://reviews.llvm.org/D11909
Files:
test/dosep.py
Index: test/dosep.py
===
--- test/dosep.py
+++ test/dosep.py
@@ -444,1
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D11641
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
On 7 August 2015 at 02:39, Sagar Thakur via lldb-commits
wrote:
>
> Author: slthakur
> Date: Fri Aug 7 01:39:38 2015
> New Revision: 244308
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244308&view=rev
> Log:
> [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1
> mode
paulmaybee added a comment.
Can you please check in in for me. Thanks.
http://reviews.llvm.org/D11574
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
On 7 August 2015 at 02:39, Sagar Thakur via lldb-commits
wrote:
>
> Author: slthakur
> Date: Fri Aug 7 01:39:38 2015
> New Revision: 244308
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244308&view=rev
> Log:
> [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1
> mode
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I don't see how passing the target architecture's OS helps here since you
aren't checking it for linux or any of the other OS's where pid == tid. This
arch is likely to be unset
On 10 August 2015 at 05:13, wrote:
>
>
> Hi Ed,
>
> We do not require to handle e_void case in GetData() as we have already
> checked if bytes_size greater than zero.
>>
>> 136bool
>> 137Scalar::GetData (DataExtractor &data, size_t limit_byte_size)
>> const
>> 138{
>>
lgtm
On Mon, Aug 10, 2015 at 2:15 AM Keno Fischer
wrote:
> loladiro created this revision.
> loladiro added a reviewer: zturner.
> loladiro added a subscriber: lldb-commits.
> loladiro set the repository for this revision to rL LLVM.
>
> We get an assertion otherwise because the None Interpreter
tberghammer added a comment.
Generally looks good to me. I am happy to push the 2 cleanup change to a
separate CL but please check that the read/write flag calculation is correct.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:514-519
@@ -507,8 +
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2230
@@ -2229,2 +2229,3 @@
bool want_hardware = false;
+uint32_t wa
omjavaid created this revision.
omjavaid added reviewers: tberghammer, clayborg.
omjavaid added a subscriber: lldb-commits.
LLGS was forcing lldb to use only write or read+write type watchpoints.
This patch fixes this behavior to enable read, write and read+write types of
watchpoints.
Note: On
omjavaid created this revision.
omjavaid added reviewers: tberghammer, clayborg.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
There were some bugs that needed to be fixed in watchpoint handling code on
arm64.
Watchpoints were being written to all watch
tberghammer added a comment.
Friendly ping
http://reviews.llvm.org/D11384
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Hi Ed,
We do not require to handle e_void case in GetData() as we have already
checked if bytes_size greater than zero.
136bool
137Scalar::GetData (DataExtractor &data, size_t
limit_byte_size) const
138{
139size_t byte_size = GetByteSize();
140
loladiro created this revision.
loladiro added a reviewer: zturner.
loladiro added a subscriber: lldb-commits.
loladiro set the repository for this revision to rL LLVM.
We get an assertion otherwise because the None Interpreter cannot be found
Repository:
rL LLVM
http://reviews.llvm.org/D11898
Hi Jason,
The function sext() for sign extending APInt values requires the new bit
width to be greater than the current bit width. That is the reason I was
just creating a new APInt instead of using sext function in cases where
we need to promote to a type which has same bit width. I will do t
Author: jmolenda
Date: Mon Aug 10 02:55:25 2015
New Revision: 244436
URL: http://llvm.org/viewvc/llvm-project?rev=244436&view=rev
Log:
Feedback from Jim: Change the "optimized code" warning to be entirely
contained within Process so that we won't be duplicating the warning
message if other parts o
( Resending with correct lldb-commits email address Cc:'ed )
Hi Sagar, I noticed this weekend that given an input program like
int foo (int in) { return in + 5;}
int main (int argc, char**argv) { return foo(argc); }
if I put a breakpoint on foo() on an x86 system (compiled with clang, on a
mac
41 matches
Mail list logo
