jaydeep updated this revision to Diff 34292.
jaydeep added a comment.
In this patch:
- Removed MIPS comment from generic code
- Used Target::GetOpcodeLoadAddress to fixup the PC
Regarding change in FormatEntity.cpp:
We still need to do this. The bit #0 of ‘addr’ has already been striped and
th
Author: jmolenda
Date: Tue Sep 8 22:36:24 2015
New Revision: 247121
URL: http://llvm.org/viewvc/llvm-project?rev=247121&view=rev
Log:
When lldb gets the register definitions from the response of a
qXfer:features:read:target.xml packet, or via the
plugin.process.gdb-remote.target-definition-file s
Author: jmolenda
Date: Tue Sep 8 22:24:52 2015
New Revision: 247120
URL: http://llvm.org/viewvc/llvm-project?rev=247120&view=rev
Log:
A change I'm open to reverting if there is disagreement:
When lldb receives a gdb-remote protocol packet that has
nonprintable characters, it will print the packet
sas closed this revision.
sas added a comment.
Committed as r247116.
Repository:
rL LLVM
http://reviews.llvm.org/D12615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Tue Sep 8 20:22:05 2015
New Revision: 247116
URL: http://llvm.org/viewvc/llvm-project?rev=247116&view=rev
Log:
Teach utilsOsType about NetBSD
Summary: NetBSD is a free, fast, secure, and highly portable Unix-like Open
Source operating system.
Reviewers: joerg, sas
Subscriber
sas added a comment.
I suppose you'll want this to go in as well so I'll just do it along with the
rest.
Repository:
rL LLVM
http://reviews.llvm.org/D12615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
sas closed this revision.
sas added a comment.
Committed as r247115.
Repository:
rL LLVM
http://reviews.llvm.org/D12661
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Tue Sep 8 20:19:05 2015
New Revision: 247115
URL: http://llvm.org/viewvc/llvm-project?rev=247115&view=rev
Log:
NetBSD doesn't provide struct statfs, make use of struct statvfs
Reviewers: joerg, sas
Subscribers: labath, lldb-commits
Differential Revision: http://reviews.llvm.o
sas closed this revision.
sas added a comment.
Committed as r247114.
Repository:
rL LLVM
http://reviews.llvm.org/D12662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Tue Sep 8 20:17:24 2015
New Revision: 247114
URL: http://llvm.org/viewvc/llvm-project?rev=247114&view=rev
Log:
Prevent from a redefinition of _GLIBCXX_USE_NANOSLEEP
Summary: Build warning caught on NetBSD.
Reviewers: joerg, sas
Subscribers: lldb-commits
Differential Revision
Author: enrico
Date: Tue Sep 8 20:10:46 2015
New Revision: 247112
URL: http://llvm.org/viewvc/llvm-project?rev=247112&view=rev
Log:
Data formatter candidate matches can be generated in a number of ways;
language-based dynamic type discovery being one of them (for instance, this is
what takes an
jingham added a subscriber: jingham.
jingham added a reviewer: spyffe.
jingham added a comment.
Sean should take a look at this as well, since it directly affects how the
expression parser lookup works.
http://reviews.llvm.org/D12658
___
lldb-commi
Author: brucem
Date: Tue Sep 8 19:56:25 2015
New Revision: 247111
URL: http://llvm.org/viewvc/llvm-project?rev=247111&view=rev
Log:
Fix log message warning in SBThread.
Summary:
The format string was not set up correctly as it was missing the %.
This resulted in a warning (correctly) that the da
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247111: Fix log message warning in SBThread. (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D12714?vs=34282&id=34288#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12714
F
sas added a subscriber: sas.
sas accepted this revision.
sas added a reviewer: sas.
sas added a comment.
This revision is now accepted and ready to land.
Nice commit summary ;)
Repository:
rL LLVM
http://reviews.llvm.org/D12615
___
lldb-commits m
brucem created this revision.
brucem added reviewers: clayborg, jingham.
brucem added a subscriber: lldb-commits.
The format string was not set up correctly as it was missing the %.
This resulted in a warning (correctly) that the data arguments were
not all used.
http://reviews.llvm.org/D12714
F
Author: tfiala
Date: Tue Sep 8 18:22:19 2015
New Revision: 247101
URL: http://llvm.org/viewvc/llvm-project?rev=247101&view=rev
Log:
Fix regressions in dotest.py when passing filters or directories.
See https://llvm.org/bugs/show_bug.cgi?id=24708 for details.
Using '-f FILTER' or unnamed argument
tfiala added a comment.
> On OS X there was at least one test that would hang each run, so I didn't get
> any kind of real timing numbers there since everything was always maxed out
> by the hanging test.
Well wonders abound. On my OS X setup, I am not seeing the hanging tests with
TOT from
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
I reverted the CL because it was causing
TestRegisters.test_fp_special_purpose_register_read to fail on OSX:
- stop reason = EXC_BREAKPOINT
- "register read ftag" yields 0x80 instead of expected 0x8000
http://reviews.llvm.org/D126
Author: ovyalov
Date: Tue Sep 8 17:41:13 2015
New Revision: 247090
URL: http://llvm.org/viewvc/llvm-project?rev=247090&view=rev
Log:
Reverting r247000 since it's causing
TestRegisters.test_fp_special_purpose_register_read to fail on OSX.
Modified:
lldb/trunk/test/functionalities/register/T
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
I'm fine with this change. On x86, where the CALL instruction pushes the
return address on the stack, you can't have two stack frames with the CFA. If
we have a loop, I don't thi
Author: spyffe
Date: Tue Sep 8 17:23:39 2015
New Revision: 247085
URL: http://llvm.org/viewvc/llvm-project?rev=247085&view=rev
Log:
ExpressionVariable now uses llvm::cast() instead of As...() for RTTI.
As part of our overall switch from hand-rolling RTTI to using LLVM-compatible
methods, I've don
tfiala closed this revision.
tfiala added a comment.
Committed here:
Sendingtest/dosep.py
Sendingtest/dotest.py
Sendingtest/dotest_args.py
Transmitting file data ...
Committed revision 247084.
http://reviews.llvm.org/D12651
__
Author: tfiala
Date: Tue Sep 8 17:22:33 2015
New Revision: 247084
URL: http://llvm.org/viewvc/llvm-project?rev=247084&view=rev
Log:
dotest.py ctrl-c support, addition of --test-runner-name option.
See http://reviews.llvm.org/D12651 for more details.
For the parallel test runner, -v now also imp
Author: enrico
Date: Tue Sep 8 17:09:19 2015
New Revision: 247082
URL: http://llvm.org/viewvc/llvm-project?rev=247082&view=rev
Log:
Implement a Target::GetTypeSystemForLanguage API, as well as provide helpers on
the TypeSystem to get numeric types of specific sizes and signedness
Modified:
krytarowski added a comment.
Thank you. Place commit.
Repository:
rL LLVM
http://reviews.llvm.org/D12661
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
Thank you. Place commit.
Repository:
rL LLVM
http://reviews.llvm.org/D12662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski updated this revision to Diff 34265.
krytarowski added a comment.
abc order
Repository:
rL LLVM
http://reviews.llvm.org/D12615
Files:
scripts/utilsOsType.py
Index: scripts/utilsOsType.py
===
--- scripts/utilsOsTyp
tfiala added a comment.
In http://reviews.llvm.org/D12651#241903, @zturner wrote:
> Cool, lgtm as well. Sorry for the holdup
Absolutely no worries. Thanks for checking, Zachary!
It would also be good if we could get either the --test-runner-name with
"threading" or "mulltiprocessing" workin
zturner added a comment.
Cool, lgtm as well. Sorry for the holdup
http://reviews.llvm.org/D12651
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Cool, lgtm as well. Sorry for the holdup
On Tue, Sep 8, 2015 at 1:58 PM Adrian McCarthy wrote:
> amccarth added a comment.
>
> It seems to be general flakiness. In three runs without the patch, I got
> the lower numbers every time. In three runs with the patch, I got higher
> numbers twice an
dawn retitled this revision from "[LLDB-MI] Fix -data-info-line when Windows
filenames are used." to "[LLDB-MI] Fix -data-info-line and -symbol-list-lines
when Windows filenames are used.".
dawn updated the summary for this revision.
dawn updated this revision to Diff 34255.
dawn added a comment.
amccarth added a comment.
It seems to be general flakiness. In three runs without the patch, I got the
lower numbers every time. In three runs with the patch, I got higher numbers
twice and the lower numbers once.
I have no objection to this patch based on this.
http://reviews.llvm.org/D126
tfiala added a comment.
In http://reviews.llvm.org/D12651#241810, @zturner wrote:
> Can you confirm with 2 runs before and 2 runs after the patch that you see
> the same results every time?
>
> Todd, can you think of a reason why this might happen?
Hmm, I vaguely recall finding what looked lik
amccarth added a comment.
I'm re-running the tests now, but I agree this is probably not worth holding up
this patch.
http://reviews.llvm.org/D12651
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Can you confirm with 2 runs before and 2 runs after the patch that you see
the same results every time?
Todd, can you think of a reason why this might happen? I don't think it's
worth holding the patch up too long over this because I want to see the
other improvements come through, but if you can
zturner added a comment.
Can you confirm with 2 runs before and 2 runs after the patch that you see
the same results every time?
Todd, can you think of a reason why this might happen? I don't think it's
worth holding the patch up too long over this because I want to see the
other improvements co
amccarth added a comment.
Ninja check-lldb works.
But...
Before the patch, there are 53 failing test suites and 71 failing test cases.
After the patch there are 54 failing test suites and 74 failing test cases.
Diffing the list of failed suites at the end of the output shows only one
differenc
emaste added a subscriber: emaste.
Comment at: scripts/utilsOsType.py:33
@@ -32,2 +32,3 @@
"FreeBSD",
+"NetBSD",
"Linux",
Please keep these in alpha order (other than Unknown at the top)
Repository:
rL LLVM
h
zturner added a comment.
If the patch is busted, pretty much every test should start failing. As
long as ninja check-lldb actually runs, completes, and behaves pretty much
the same way as before, that's pretty much all that needs to be verified.
Ctrl+C shouldn't behave any differently with this
If the patch is busted, pretty much every test should start failing. As
long as ninja check-lldb actually runs, completes, and behaves pretty much
the same way as before, that's pretty much all that needs to be verified.
Ctrl+C shouldn't behave any differently with this patch, the idea was to
ref
amccarth added a subscriber: amccarth.
amccarth added a comment.
After applying the patch, I get three additional test case failures on Windows.
I'm trying to figure out now which ones.
Is there something specific I'm supposed to be trying, with regard to Ctrl+C
itself.
http://reviews.llvm.o
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jingham
Date: Tue Sep 8 13:40:59 2015
New Revision: 247046
URL: http://llvm.org/viewvc/llvm-project?rev=247046&view=rev
Log:
SBThread::StepOutOfFrame should check that the SBStackFrame it gets passed
is valid, and that its thread is the same as this SBThread.
Modified:
lldb/trunk/sou
Author: gclayton
Date: Tue Sep 8 13:15:05 2015
New Revision: 247041
URL: http://llvm.org/viewvc/llvm-project?rev=247041&view=rev
Log:
Use LLVM casting for TypeSystem so you can cast it to subclasses.
This will keep our code cleaner and it removes the need for intrusive additions
to TypeSystem l
sas closed this revision.
sas added a comment.
Committed as r247034.
Repository:
rL LLVM
http://reviews.llvm.org/D12654
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Tue Sep 8 12:47:17 2015
New Revision: 247034
URL: http://llvm.org/viewvc/llvm-project?rev=247034&view=rev
Log:
Add missing include for va_list in MIUtilString.h
Summary: Problem was caught on NetBSD.
Reviewers: joerg, sas
Subscribers: lldb-commits
Differential Revision: http
On 8 September 2015 at 12:35, Ed Maste via lldb-commits
wrote:
> Author: emaste
> Date: Tue Sep 8 11:35:28 2015
> New Revision: 247024
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247024&view=rev
> Log:
> Revert "Enable
> StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_wi
tberghammer created this revision.
tberghammer added a reviewer: jasonmolenda.
tberghammer added a subscriber: lldb-commits.
Change the looping stack detection code
In some special case (e.g. signal handlers, hand written assembly) it is
valid to have 2 stack frame with the same CFA value. This C
Author: emaste
Date: Tue Sep 8 11:35:28 2015
New Revision: 247024
URL: http://llvm.org/viewvc/llvm-project?rev=247024&view=rev
Log:
Revert "Enable
StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf
on FreeBSD"
And update the comment describing the reason this test i
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Core/Debugger.cpp
Users:
ovyalov (Author)
http://reviews.llvm.org/rL247023
http://reviews.llvm.org/D12683
___
lldb-commits mailing list
lldb-commits@lists.llvm.
Author: ovyalov
Date: Tue Sep 8 11:26:32 2015
New Revision: 247023
URL: http://llvm.org/viewvc/llvm-project?rev=247023&view=rev
Log:
Fix debugger shutdown when Python interpreter is loaded.
http://reviews.llvm.org/D12683
Modified:
lldb/trunk/source/Core/Debugger.cpp
Modified: lldb/trunk/s
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Open issues:
- In FormatEntity.cpp we probably don't need any changes to DumpAddress()
- Remove MIPS comment from generic code and let the
"Target::GetOpcodeLoadAddress (...) con
Author: tberghammer
Date: Tue Sep 8 11:22:23 2015
New Revision: 247022
URL: http://llvm.org/viewvc/llvm-project?rev=247022&view=rev
Log:
Fix assertion failure caused by a bug in 128bit register handling in
RegisterValue
Modified:
lldb/trunk/include/lldb/Core/RegisterValue.h
lldb/trunk/s
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D12683
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg added a comment.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D12667
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
One minor IsValid() fix in DWARFDIE to avoid crashes and this is good to go.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp:28-35
@@ -27,1 +27,10 @@
aprantl accepted this revision.
aprantl added a comment.
Thanks, yes, this check looks like it serves no purpose.
http://reviews.llvm.org/D12674
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: emaste
Date: Tue Sep 8 08:33:21 2015
New Revision: 247013
URL: http://llvm.org/viewvc/llvm-project?rev=247013&view=rev
Log:
Enable
StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf
on FreeBSD
This test passes locally but was disabled due to pexpect issues o
Author: emaste
Date: Tue Sep 8 08:27:27 2015
New Revision: 247012
URL: http://llvm.org/viewvc/llvm-project?rev=247012&view=rev
Log:
Remove expectedFailureFreeBSD from passing
PluginCommandTestCase::test_load_plugin
This test was failing due to a libc++ vs libsdc++ conflict which should
be fixed
Author: emaste
Date: Tue Sep 8 08:05:15 2015
New Revision: 247009
URL: http://llvm.org/viewvc/llvm-project?rev=247009&view=rev
Log:
Exception registers aren't supported outside of Darwin
Apply test update from r234992 to FreeBSD
Modified:
lldb/trunk/test/python_api/lldbutil/iter/TestRegiste
jeremi.piotrowski added a comment.
I do not have commit access, so if you could do it for me that would be great.
http://reviews.llvm.org/D12672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
abhishek.aggarwal closed this revision.
abhishek.aggarwal added a comment.
Couldn't land this patch by arc due to merge conflicts. Hence merging it
manually and closing this revision.
http://reviews.llvm.org/D12677
___
lldb-commits mailing list
lld
Author: abhishek
Date: Tue Sep 8 05:19:37 2015
New Revision: 247000
URL: http://llvm.org/viewvc/llvm-project?rev=247000&view=rev
Log:
Bug 24733: TestRegisters.py for Clang inferiors
Summary:
- Bug 24457 can now be tested for inferiors compiled
by clang compiler also.
- A generic
jaydeep updated this revision to Diff 34199.
jaydeep added a comment.
In this patch:
The bit #0 has been cleared from addresses in the line tables. However we are
relying upon ArchSpec instead of Target while clearing this bit in
ParseDWARFLineTableCallback because SymbolContext may not have a
65 matches
Mail list logo
