Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

ki.stfu requested changes to this revision. This revision now requires changes to proceed. Comment at: test/tools/lldb-mi/symbol/main.cpp:12 @@ +11,3 @@ +// included in -symbol-list-lines main.cpp, by checking that all the lines +// are between 20 and 29. +// line 13

[Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

tfiala created this revision. tfiala added reviewers: labath, clayborg, emaste. tfiala added a subscriber: lldb-commits. Addresses: * https://llvm.org/bugs/show_bug.cgi?id=24831: cmake + ninja: 'ninja lldb' misses lib/python2.7 build dependency on Linux *

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

tfiala added a comment. @emaste, I'm adding you because I have no idea what the state of the *BSD world is with regards to lldb-server. It looks like you might still use the native process bits so lldb-server might not be interesting over there. If it is, we can extend the "always add the

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, thanks for fixing this. Comment at: tools/driver/CMakeLists.txt:13 @@ +12,3 @@ + add_dependencies(lldb lldb-server) +endif() + We should

Re: [Lldb-commits] [PATCH] D5871: Add an OperatingSystem plugin to support goroutines

brucem added a subscriber: brucem. Comment at: test/lang/go/goroutines/TestGoroutines.py:14 @@ +13,3 @@ +@python_api_test +@skipIfRemote # Not remote test suit ready +@skipUnlessGoInstalled Minor typo: should be "suite" Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D12876: [MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

labath added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3579 @@ +3578,3 @@ +*/ +if (!response.IsNormalResponse() && thread_ids.size() == 0 && IsConnected()) +{ jaydeep wrote: > labath

Re: [Lldb-commits] [PATCH] D12880: Add support for the DWARFLocationList used by split-dwarf

tberghammer marked an inline comment as done. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:36-228 @@ -37,1 +35,195 @@ +static int +print_dwarf_exp_op (Stream , +const DWARFDataExtractor& data, +lldb::offset_t

[Lldb-commits] [lldb] r247782 - Add names to RenderScript kernel breakpoints.

Author: ewancrawford Date: Wed Sep 16 05:02:57 2015 New Revision: 247782 URL: http://llvm.org/viewvc/llvm-project?rev=247782=rev Log: Add names to RenderScript kernel breakpoints. Use Breakpoint::AddName to mark all RenderScript kernel breakpoints with the name 'RenderScriptKernel'. Also update

Re: [Lldb-commits] [PATCH] D12880: Add support for the DWARFLocationList used by split-dwarf

This revision was automatically updated to reflect the committed changes. tberghammer marked an inline comment as done. Closed by commit rL247789: Add support for the DWARFLocationList used by split-dwarf (authored by tberghammer). Changed prior to commit:

[Lldb-commits] [PATCH] D12900: Fix link failures when BUILD_SHARED_LIBS=ON.

dsanders created this revision. dsanders added a subscriber: lldb-commits. http://reviews.llvm.org/D12900 Files: tools/lldb-server/CMakeLists.txt Index: tools/lldb-server/CMakeLists.txt === --- tools/lldb-server/CMakeLists.txt

[Lldb-commits] [lldb] r247789 - Add support for the DWARFLocationList used by split-dwarf

Author: tberghammer Date: Wed Sep 16 07:37:06 2015 New Revision: 247789 URL: http://llvm.org/viewvc/llvm-project?rev=247789=rev Log: Add support for the DWARFLocationList used by split-dwarf Split-dwarf uses a different header format to specify the address range for the elements of the location

[Lldb-commits] [lldb] r247788 - Fix prologue end handling when code compiled by gcc

Author: tberghammer Date: Wed Sep 16 07:36:37 2015 New Revision: 247788 URL: http://llvm.org/viewvc/llvm-project?rev=247788=rev Log: Fix prologue end handling when code compiled by gcc GCC don't use the is_prologue_end flag to mark the first instruction after the prologue. Instead of it it is

Re: [Lldb-commits] [PATCH] D12757: Fix prologue end handling when code compiled by gcc

This revision was automatically updated to reflect the committed changes. Closed by commit rL247788: Fix prologue end handling when code compiled by gcc (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D12757?vs=34435=34886#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D12876: [MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

labath added a subscriber: labath. labath added a comment. Hi, this commit has caused failure on all remote tests using lldb-server. I have reverted it while I investigate what is happening. Repository: rL LLVM http://reviews.llvm.org/D12876

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

tfiala added a comment. > (These have already diverged as you are only doing this for Linux, but > lldb-server is built on FreeBSD as well.) Hi Bruce, My primary goal was to make sure 'ninja lldb' builds the parts that are necessary for lldb to run and be tested. Linux cannot debug a local

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

tfiala added a comment. > Okay I'll make an adjustment to turn it on for Darwin and setting it based on > a flag. I'm going to do it slightly differently --- I'll set a flag in the modules config that indicates if lldb *wants* lldb-server. The logic on whether to build it or not should, as

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

tfiala added a comment. In http://reviews.llvm.org/D12899#247098, @tfiala wrote: > Adjustments to set indirect variable for whether lldb can use lldb-server. > If so, then we'll add the dependency for lldb-server on lldb at the time we > declare the lldb target. Also adds lldb-server

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

tfiala added a comment. > Yeah... it is starting to get a bit over-engineered. :) It's all good :-) http://reviews.llvm.org/D12899 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

tfiala marked 5 inline comments as done. tfiala added a comment. I think this covers everything. http://reviews.llvm.org/D12899 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

tfiala updated this revision to Diff 34894. tfiala added a comment. Adds an orthogonal can-use-debugserver flag. Flips it on for Darwin. I'm okay with the Darwin cmake build building both of those for the lldb target since I want the consistency checks between the two running on Darwin.

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

tfiala added a comment. I'll check this in if I don't hear boo in the next few minutes... http://reviews.llvm.org/D12899 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

tfiala added a comment. In http://reviews.llvm.org/D12899#247092, @emaste wrote: > In http://reviews.llvm.org/D12899#246881, @tfiala wrote: > > > @emaste, I'm adding you because I have no idea what the state of the *BSD > > world is with regards to lldb-server. It looks like you might still

[Lldb-commits] [lldb] r247810 - cmake fixes for lldb target.

Author: tfiala Date: Wed Sep 16 10:34:06 2015 New Revision: 247810 URL: http://llvm.org/viewvc/llvm-project?rev=247810=rev Log: cmake fixes for lldb target. ninja lldb now does the following: * forces the python post-build step to fire, which sets up the python lldb module properly. * on Darwin

Re: [Lldb-commits] [PATCH] D12757: Fix prologue end handling when code compiled by gcc

jingham added a subscriber: jingham. jingham added a comment. The point of the file name check is to catch the case where you had nested inlines that share the same address, and the compiler (errantly, but...) decided to emit duplicate entries at the same address for the two levels of

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

zturner added a comment. Instead of test/functionalities/minidump, I would probably call this test/functionalities/core-file/windows. I'm using core-file instead of minidump because it's the most generic term that will make sense on all platforms, and other platforms will essentially want to

[Lldb-commits] [lldb] r247829 - Add first tests for mini-dump debugging.

Author: amccarth Date: Wed Sep 16 13:17:11 2015 New Revision: 247829 URL: http://llvm.org/viewvc/llvm-project?rev=247829=rev Log: Add first tests for mini-dump debugging. Differential Revision: http://reviews.llvm.org/D12888 Added: lldb/trunk/test/functionalities/postmortem/

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

amccarth added a comment. In http://reviews.llvm.org/D12888#247212, @zturner wrote: > In http://reviews.llvm.org/D12888#247195, @amccarth wrote: > > > > Instead of test/functionalities/minidump, I would probably call this > > > test/functionalities/core-file/windows. > > > > > > Hmm... > > > >

[Lldb-commits] [lldb] r247823 - Add newline at end of file to avoid compiler warning.

Author: gclayton Date: Wed Sep 16 13:05:08 2015 New Revision: 247823 URL: http://llvm.org/viewvc/llvm-project?rev=247823=rev Log: Add newline at end of file to avoid compiler warning. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp Modified:

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

looks fine. On Wed, Sep 16, 2015 at 11:02 AM Adrian McCarthy wrote: > amccarth updated this revision to Diff 34906. > amccarth added a comment. > > Addressed earlier comments and moved to functionalities\postmortem\minidump > > > http://reviews.llvm.org/D12888 > > Files: >

Re: [Lldb-commits] [lldb] r247764 - Fix MacOSX since "imported" and "Imported::imported" are ambiguous. Test that we can read the global when specified with the global namespace and test that we can r

On 16 September 2015 at 00:42, Greg Clayton via lldb-commits wrote: > Author: gclayton > Date: Tue Sep 15 19:42:50 2015 > New Revision: 247764 > > URL: http://llvm.org/viewvc/llvm-project?rev=247764=rev > Log: > Fix MacOSX since "imported" and "Imported::imported" are

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

amccarth updated this revision to Diff 34906. amccarth added a comment. Addressed earlier comments and moved to functionalities\postmortem\minidump http://reviews.llvm.org/D12888 Files: test/functionalities/postmortem/minidump/TestMiniDump.py

Re: [Lldb-commits] [PATCH] D5871: Add an OperatingSystem plugin to support goroutines

ribrdb updated this revision to Diff 34914. ribrdb added a comment. > I am confused as to why we need to do this. If you have a memory thread, it > might be backed by a real thread, or it might not. If it is backed by a > real thread, we should be asking the real thread why it really

[Lldb-commits] [lldb] r247830 - Remove XFAIL from TestCppNsImport.

Author: zturner Date: Wed Sep 16 13:19:06 2015 New Revision: 247830 URL: http://llvm.org/viewvc/llvm-project?rev=247830=rev Log: Remove XFAIL from TestCppNsImport. This test seems to be working now, probably due to r244764. Modified: lldb/trunk/test/lang/cpp/nsimport/TestCppNsImport.py

Re: [Lldb-commits] [PATCH] D12897: Add using directives to the clang::DeclContext and fix decls for variables inside namespaces

paulherman updated this revision to Diff 34911. paulherman added a comment. Add using directives to the clang::DeclContext and fix decls for variables inside namespaces Rebased the patch. http://reviews.llvm.org/D12897 Files: include/lldb/Symbol/SymbolFile.h

[Lldb-commits] [PATCH] D12909: Fix Makefile for Windows to Android tests.

chaoren created this revision. chaoren added a reviewer: zturner. chaoren added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. http://reviews.llvm.org/D12909 Files: test/make/Makefile.rules Index: test/make/Makefile.rules

[Lldb-commits] [lldb] r247826 - Silence compiler warnings about unhandled switch cases.

Author: zturner Date: Wed Sep 16 13:08:45 2015 New Revision: 247826 URL: http://llvm.org/viewvc/llvm-project?rev=247826=rev Log: Silence compiler warnings about unhandled switch cases. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified:

[Lldb-commits] [lldb] r247822 - Decorate flaky FreeBSD test

Author: emaste Date: Wed Sep 16 13:00:09 2015 New Revision: 247822 URL: http://llvm.org/viewvc/llvm-project?rev=247822=rev Log: Decorate flaky FreeBSD test ExprCommandWithTimeoutsTestCase::expectedFailureFreeBSD had an expectedFailureFreeBSD decorator, removed in r247799. It had been flakey on

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

dawn marked 3 inline comments as done. dawn added a comment. Ilia, thank you for your review - I think I understand what you are asking for now. Repository: rL LLVM http://reviews.llvm.org/D12115 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

dawn updated this revision to Diff 34928. dawn added a comment. Tests changed as requested by Ilia. Ok to commit? Repository: rL LLVM http://reviews.llvm.org/D12115 Files: test/tools/lldb-mi/symbol/Makefile test/tools/lldb-mi/symbol/TestMiSymbol.py test/tools/lldb-mi/symbol/main.cpp

[Lldb-commits] [lldb] r247855 - XFAIL TestCppNsImport for gcc-4.9.

Author: chaoren Date: Wed Sep 16 16:32:48 2015 New Revision: 247855 URL: http://llvm.org/viewvc/llvm-project?rev=247855=rev Log: XFAIL TestCppNsImport for gcc-4.9. Works for gcc-4.8. A bug in gcc perhaps. Modified: lldb/trunk/test/lang/cpp/nsimport/TestCppNsImport.py Modified:

[Lldb-commits] [lldb] r247841 - Fix log disable command in ProcessWindowsLog.

Author: zturner Date: Wed Sep 16 15:13:53 2015 New Revision: 247841 URL: http://llvm.org/viewvc/llvm-project?rev=247841=rev Log: Fix log disable command in ProcessWindowsLog. The implications of this bug where that "log disable windows" would not actually disable the log, and worse it would lock

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

sivachandra added a comment. Ping. Any suggestion on how to take this forward? http://reviews.llvm.org/D12809 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r247825 - Last set of XFAILs for Windows.

Author: zturner Date: Wed Sep 16 13:08:33 2015 New Revision: 247825 URL: http://llvm.org/viewvc/llvm-project?rev=247825=rev Log: Last set of XFAILs for Windows. Modified: lldb/trunk/test/api/multiple-debuggers/TestMultipleDebuggers.py lldb/trunk/test/expression_command/test/TestExprs.py

[Lldb-commits] [lldb] r247831 - Move hardcoded formatters from the FormatManager to the Language plugins

Author: enrico Date: Wed Sep 16 13:28:11 2015 New Revision: 247831 URL: http://llvm.org/viewvc/llvm-project?rev=247831=rev Log: Move hardcoded formatters from the FormatManager to the Language plugins Modified: lldb/trunk/include/lldb/DataFormatters/FormatClasses.h

Re: [Lldb-commits] [PATCH] D12897: Add using directives to the clang::DeclContext and fix decls for variables inside namespaces

clayborg added a comment. If you can explain the need for ParseDeclsForContext() as mentioned in the inlined comment that would help me understand this change better. Also, Sean suggested that we might be able to fix all of this in another way that might make it easier on everyone: don't do

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

amccarth marked 2 inline comments as done. amccarth added a comment. > Instead of test/functionalities/minidump, I would probably call this > test/functionalities/core-file/windows. Hmm... There is talk of (eventually) debugging minidumps on other platforms. Also some crash capture tools

Re: [Lldb-commits] [PATCH] D12897: Add using directives to the clang::DeclContext and fix decls for variables inside namespaces

paulherman added a comment. The need for ParseDeclsInContext is to get a list of namespaces that are contained within a using-directive. This does not actually parse anything but DW_TAG_imported_namespace and DW_TAG_imported_decl. The actual contents of the namespace are parsed only when the

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

zturner added a comment. In http://reviews.llvm.org/D12888#247195, @amccarth wrote: > > Instead of test/functionalities/minidump, I would probably call this > > test/functionalities/core-file/windows. > > > Hmm... > > There is talk of (eventually) debugging minidumps on other platforms. Also

Re: [Lldb-commits] [PATCH] D12876: [MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

clayborg added a comment. If "qfThreadInfo" responds with OK, it seems to imply "this is a supported packet, but I have no threads to report". So it seems like we should assume that there are no threads in this case. If we got $#00 back, then it would mean that qfThreadInfo ins't supported. So