Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

labath added inline comments. Comment at: source/Target/Process.cpp:3934 @@ +3933,3 @@ + +ListenerSP listener_sp (new Listener("lldb.Process.HaltForDestroyOrDetach.hijack")); +HijackProcessEvents(listener_sp.get()); ki.stfu wrote: > btw:

Re: [Lldb-commits] [PATCH] D13056: Fix race condition during process detach

This revision was automatically updated to reflect the committed changes. Closed by commit rL248371: Fix race condition during process detach (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13056?vs=35372=35476#toc Repository: rL LLVM http://reviews.llvm.org/D13056

[Lldb-commits] [lldb] r248371 - Fix race condition during process detach

Author: labath Date: Wed Sep 23 05:16:57 2015 New Revision: 248371 URL: http://llvm.org/viewvc/llvm-project?rev=248371=rev Log: Fix race condition during process detach Summary: The following situation occured in TestAttachResume: The inferior was stoped at a breakpoint and we did a continue,

Re: [Lldb-commits] [PATCH] D13096: Handle OMPArraySection in ClangASTContext::GetEncoding

emaste added a comment. Oh, it seems there are more new types added after I first made this change: ../tools/lldb/source/Symbol/ClangASTContext.cpp:4445:21: warning: 10 enumeration values not handled in switch: 'OCLImage2dDepth', 'OCLImage2dArrayDepth', 'OCLImage2dMSAA'... [-Wswitch]

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

KLapshin added a comment. @labath, I updated patch against actual source in SVN - i.e. with taking into account your change (Halt*->Stop*). Regarding matter of this patch - I just tried to make process stop synchronous, see Process::ResumeSynchronous() - same technique was applied month ago.

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

KLapshin marked an inline comment as done. KLapshin added a comment. Done. Repository: rL LLVM http://reviews.llvm.org/D12968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

KLapshin added a comment. In http://reviews.llvm.org/D12968#251719, @labath wrote: > In http://reviews.llvm.org/D12968#251696, @KLapshin wrote: > > > Regarding matter of this patch - I just tried to make process stop > > synchronous, see Process::ResumeSynchronous() - same technique was applied

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

labath added a comment. In http://reviews.llvm.org/D12968#251696, @KLapshin wrote: > Regarding matter of this patch - I just tried to make process stop > synchronous, see Process::ResumeSynchronous() - same technique was applied > months ago (@ki.stfu). > > Agreed what crash may be related to

[Lldb-commits] [lldb] r248384 - Cleaned up results formatter options hand-off.

Author: tfiala Date: Wed Sep 23 10:21:28 2015 New Revision: 248384 URL: http://llvm.org/viewvc/llvm-project?rev=248384=rev Log: Cleaned up results formatter options hand-off. * --results-formatter-options renamed to --results-formatter-option, with short version of -O * Multiple

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

KLapshin removed rL LLVM as the repository for this revision. KLapshin updated this revision to Diff 35491. http://reviews.llvm.org/D12968 Files: source/Target/Process.cpp Index: source/Target/Process.cpp === ---

Re: [Lldb-commits] [PATCH] D13094: LLDB-MI: Fix assignment operator in CMIUtilString

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13102: Rename clang_type -> compiler_type for variables.

brucem added a comment. This doesn't cover files with Clang in their name. But it should cover just about everything else. http://reviews.llvm.org/D13102 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good as long as the test suite if happy. http://reviews.llvm.org/D13066 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13049: execinfo.h isn't needed on Mac OS X for Host.mm.

brucem added a comment. Ping? This should be safe and almost risk-free. http://reviews.llvm.org/D13049 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r248397 - test framework: fixed issue when using results formatter with no formatter options

Author: tfiala Date: Wed Sep 23 12:20:09 2015 New Revision: 248397 URL: http://llvm.org/viewvc/llvm-project?rev=248397=rev Log: test framework: fixed issue when using results formatter with no formatter options I broke the formatter options-passing parsing when no formatter options are

Re: [Lldb-commits] [lldb] r248366 - Testcase and fix for bug 24074

On 23 September 2015 at 03:19, Ravitheja Addepally via lldb-commits wrote: > Author: ravitheja > Date: Wed Sep 23 02:19:02 2015 > New Revision: 248366 > > URL: http://llvm.org/viewvc/llvm-project?rev=248366=rev > Log: > Testcase and fix for bug 24074 This change

Re: [Lldb-commits] [lldb] r247953 - TypeSystem is now a plugin interface and removed any "ClangASTContext ::GetClangASTContext()" functions.

% ./dotest.py lang/cpp/dynamic-value LLDB library dir: /Volumes/work/gclayton/Documents/src/lldb/tot/build/Debug LLDB import library dir: /Volumes/work/gclayton/Documents/src/lldb/tot/build/Debug lldb-350.99.0 lldb.pre_flight: None lldb.post_flight: None Session logs for test

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. If you are going to hijack you do need to do it before you call Halt(). Repository: rL LLVM http://reviews.llvm.org/D12968 ___

Re: [Lldb-commits] [PATCH] D13096: Handle new types in ClangASTContext::GetEncoding

emaste added a comment. http://reviews.llvm.org/rL248414 http://reviews.llvm.org/D13096 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r248421 - Revert 248366 "Testcase and fix for bug 24074"

Author: enrico Date: Wed Sep 23 14:32:56 2015 New Revision: 248421 URL: http://llvm.org/viewvc/llvm-project?rev=248421=rev Log: Revert 248366 "Testcase and fix for bug 24074" This commit introduced regressions in several test cases on FreeBSD and Mac OS X Removed:

Re: [Lldb-commits] [lldb] r248366 - Testcase and fix for bug 24074

> On Sep 23, 2015, at 12:09 PM, Ed Maste wrote: > > I'd suggest we revert for now and bring it back after testing on all > platforms. There were a couple of nits and changes in the committed > version relative to the version in the review as well so I think it's > better to

Re: [Lldb-commits] [PATCH] D13096: Handle new types in ClangASTContext::GetEncoding

emaste retitled this revision from "Handle OMPArraySection in ClangASTContext::GetEncoding" to "Handle new types in ClangASTContext::GetEncoding". emaste updated this revision to Diff 35532. emaste added a comment. More new types added after my initial patch. http://reviews.llvm.org/D13096

[Lldb-commits] [lldb] r248414 - Handle new types in ClangASTContext::GetEncoding

Author: emaste Date: Wed Sep 23 13:32:34 2015 New Revision: 248414 URL: http://llvm.org/viewvc/llvm-project?rev=248414=rev Log: Handle new types in ClangASTContext::GetEncoding And remove the switch default, so that the -Wcovered-switch-default warning will catch new types next time they're

Re: [Lldb-commits] [lldb] r248366 - Testcase and fix for bug 24074

I am seeing the same issue on OS X Ravitheja, can you investigate this? Or should we just revert? > On Sep 23, 2015, at 9:54 AM, Ed Maste via lldb-commits > wrote: > > On 23 September 2015 at 03:19, Ravitheja Addepally via lldb-commits >

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

sivachandra added a comment. Friendly periodic ping. Let me know if once in 2 days is too frequent. http://reviews.llvm.org/D12809 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13111: [TestCppIncompleteTypes] Fix Makefile to handle different archs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248416: [TestCppIncompleteTypes] Fix Makefile to handle different archs. (authored by sivachandra). Changed prior to commit: http://reviews.llvm.org/D13111?vs=35535=35539#toc Repository: rL LLVM

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

dawn added a subscriber: lldb-commits. http://reviews.llvm.org/rL248338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [Diffusion] rL247709: Make the source-map help grammatical.

dawn added a subscriber: dawn. dawn raised a concern with this commit. dawn added a comment. Hi Jim, This test has been failing on OSX ever since this commit: ./dotest.py -f RegisterCommandsTestCase.test_register_expressions

[Lldb-commits] [lldb] r248366 - Testcase and fix for bug 24074

Author: ravitheja Date: Wed Sep 23 02:19:02 2015 New Revision: 248366 URL: http://llvm.org/viewvc/llvm-project?rev=248366=rev Log: Testcase and fix for bug 24074 Summary: In bug 24074, the type information is not shown correctly. This commit includes the following - -> Changes for displaying

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

ki.stfu requested changes to this revision. ki.stfu added a comment. Please, next time make a patch with full context: svn diff --diff-cmd diff -x "-U" > mypatch.txt This will help us to reduce the review time. Comment at:

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. We need to get Sean Callanan as a reviewer on this. Jim is out for a few weeks, so Sean will need to OK this. Repository: rL LLVM http://reviews.llvm.org/D13073

[Lldb-commits] [lldb] r248434 - Check existence of SIGHUP before using it

Author: chying Date: Wed Sep 23 16:53:18 2015 New Revision: 248434 URL: http://llvm.org/viewvc/llvm-project?rev=248434=rev Log: Check existence of SIGHUP before using it Summary: -SIGHUP doesn't exist on Windows Reviewers: tfiala Subscribers: lldb-commits Differential Revision:

Re: [Lldb-commits] [Diffusion] rL247968: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

dawn added a subscriber: lldb-commits. Users: jaydeep (Author) http://reviews.llvm.org/rL247968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D13111: [TestCppIncompleteTypes] Fix Makefile to handle different archs.

sivachandra created this revision. sivachandra added a reviewer: chying. sivachandra added a subscriber: lldb-commits. http://reviews.llvm.org/D13111 Files: test/lang/cpp/incomplete-types/Makefile Index: test/lang/cpp/incomplete-types/Makefile

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

dawn added a subscriber: dawn. dawn raised a concern with this commit. dawn added a comment. Hi Enrico, This commit has caused catasrophic test failures on OSX. The failure count went up by 512. lldb is built with cmake/ninja, and tests are run in the test dir as follows: cd ~/llvm mkdir

Re: [Lldb-commits] [Diffusion] rL248048: Added support for resolving symbolic links to FileSpec.

dawn added a subscriber: lldb-commits. Users: spyffe (Author) http://reviews.llvm.org/rL248048 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

clayborg added a subscriber: clayborg. clayborg added a comment. Even though clang isn't done this way for historical reason, I would like to see the Go expression parser files (.cpp and .h) over into "source/Plugins/ExpressionParser/Go". The following files should be moved:

Re: [Lldb-commits] [Diffusion] rL248048: Added support for resolving symbolic links to FileSpec.

dawn raised a concern with this commit. Users: spyffe (Author) dawn (Auditor) http://reviews.llvm.org/rL248048 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r248429 - The Visual Studio compiler does not like this C-ism when 'enum class'es are involved

> On Sep 23, 2015, at 2:31 PM, Zachary Turner wrote: > > If you change "enum" to "enum class" I think it will work Yes that would also work > (IANALL but I think it's even more correct). IANALL either, but I beg to differ on that The way I usually heard it explained is

Re: [Lldb-commits] [Diffusion] rL247968: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

dawn added a subscriber: dawn. dawn raised a concern with this commit. dawn added a comment. Hi Jay, This test has been failing on OSX ever since this commit: ./dotest.py -f ConnectRemoteTestCase.test_connect_remote

Re: [Lldb-commits] [Diffusion] rL248048: Added support for resolving symbolic links to FileSpec.

dawn added a subscriber: dawn. dawn added a comment. Hi Sean, These 3 tests have been failing on OSX ever since this commit: Failure-TestLaunchWithShellExpand.LaunchWithShellExpandTestCase.test_with_dsym-x86_64-clang.log

Re: [Lldb-commits] [Diffusion] rL247773: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

dawn added a subscriber: dawn. dawn raised a concern with this commit. dawn added a comment. Hi Jay, This test has been failing on OSX ever since this commit: ./dotest.py -f TestCppNsImport.test_with_dwarf_and_run_command

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

> On Sep 23, 2015, at 12:42 PM, Dawn Perchik via lldb-commits > wrote: > > dawn added a subscriber: dawn. > dawn raised a concern with this commit. > dawn added a comment. > > Hi Enrico, > > This commit has caused catasrophic test failures on OSX. The failure

[Lldb-commits] [PATCH] D13114: Check existence of SIGHUP before using it

chying created this revision. chying added a reviewer: tfiala. chying added a subscriber: lldb-commits. -SIGHUP doesn't exist on Windows http://reviews.llvm.org/D13114 Files: test/dosep.py Index: test/dosep.py === ---

[Lldb-commits] [lldb] r248429 - The Visual Studio compiler does not like this C-ism when 'enum class'es are involved

Author: enrico Date: Wed Sep 23 15:49:15 2015 New Revision: 248429 URL: http://llvm.org/viewvc/llvm-project?rev=248429=rev Log: The Visual Studio compiler does not like this C-ism when 'enum class'es are involved Modified:

Re: [Lldb-commits] [Diffusion] rL247968: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

jaydeep added a comment. Hi Dawn, Let me check and get back to you. Regards, Jaydeep Users: jaydeep (Author) dawn (Auditor) http://reviews.llvm.org/rL247968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

ribrdb added a comment. Hmm. I assumed you're using clang to generate llvm IR, is that not the case? I don't really want to write a whole go compiler. Right now I'm interpreting the AST using the ValueObject API. This also lets me reuse the error checking and things implemented in the type

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

sivachandra added inline comments. Comment at: test/lang/cpp/incomplete-types/Makefile:8 @@ +7,3 @@ + +ifneq (,$(findstring clang,$(CC))) + CFLAGS_LIMIT += -flimit-debug-info dblaikie wrote: > In case it's interesting, you can get similarly problematic DWARF by

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

dblaikie added a subscriber: dblaikie. Comment at: test/lang/cpp/incomplete-types/Makefile:8 @@ +7,3 @@ + +ifneq (,$(findstring clang,$(CC))) + CFLAGS_LIMIT += -flimit-debug-info In case it's interesting, you can get similarly problematic DWARF by using a

Re: [Lldb-commits] [Diffusion] rL247741: Clean up register naming conventions inside lldb.

dawn added a subscriber: dawn. dawn added a comment. These tests have been failing on OSX ever since this commit: ./dotest.py -f LldbGdbServerTestCase.test_qRegisterInfo_returns_all_valid_results_debugserver_dsym ./dotest.py -f

Re: [Lldb-commits] [Diffusion] rL247741: Clean up register naming conventions inside lldb.

dawn added a subscriber: lldb-commits. http://reviews.llvm.org/rL247741 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r248450 - Added the ability to register key callbacks for much easier key handling. Also added the elapsed time display to the status bar.

Author: gclayton Date: Wed Sep 23 19:19:42 2015 New Revision: 248450 URL: http://llvm.org/viewvc/llvm-project?rev=248450=rev Log: Added the ability to register key callbacks for much easier key handling. Also added the elapsed time display to the status bar. Modified:

Re: [Lldb-commits] [PATCH] D13049: execinfo.h isn't needed on Mac OS X for Host.mm.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248457: execinfo.h isn't needed on Mac OS X for Host.mm. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13049?vs=35354=35581#toc Repository: rL LLVM

[Lldb-commits] [lldb] r248457 - execinfo.h isn't needed on Mac OS X for Host.mm.

Author: brucem Date: Wed Sep 23 20:37:32 2015 New Revision: 248457 URL: http://llvm.org/viewvc/llvm-project?rev=248457=rev Log: execinfo.h isn't needed on Mac OS X for Host.mm. Summary: This is no longer needed as this file no longer calls backtrace(). Reviewers: clayborg Subscribers:

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

brucem added a subscriber: brucem. brucem added a comment. I ran into this myself and looked into it. What is happening is that it is looking for `argdumper` and not finding it. This happens because it is looking in the `lib` directory within the build directory, but `argdumper` is in the