Author: labath
Date: Tue Sep 29 07:42:56 2015
New Revision: 248790
URL: http://llvm.org/viewvc/llvm-project?rev=248790=rev
Log:
Enable test_create_after_attach_with_dwarf_and_popen on linux
The test still remains XTIMEOUTed. Will remove that as well if it turns out its
passing.
Modified:
brucem added a comment.
This looks good to me and like the correct fix. Leaving it for zturner to give
the official nod of approval though.
Repository:
rL LLVM
http://reviews.llvm.org/D13234
___
lldb-commits mailing list
krytarowski updated this revision to Diff 35950.
krytarowski added a comment.
Use proper include.
Repository:
rL LLVM
http://reviews.llvm.org/D12748
Files:
tools/lldb-server/lldb-gdbserver.cpp
Index: tools/lldb-server/lldb-gdbserver.cpp
enlight created this revision.
enlight added reviewers: brucem, zturner.
enlight added a subscriber: lldb-commits.
enlight set the repository for this revision to rL LLVM.
After a developer builds LLDB from source on Windows (assuming they've built it
with Python support enabled), they may be
This revision was automatically updated to reflect the committed changes.
tberghammer marked an inline comment as done.
Closed by commit rL248788: Change oat symbolization code for android to work on
non-rooted devices (authored by tberghammer).
Changed prior to commit:
krytarowski added inline comments.
Comment at: include/lldb/Config/config.h.cmake:6
@@ +5,3 @@
+#else
+#define CONFIG_H
+
krytarowski wrote:
> brucem wrote:
> > brucem wrote:
> > > This should be `LLDB_CONFIG_CONFIG_H` rather than just `CONFIG_H`.
> > >
> > >
Author: tberghammer
Date: Tue Sep 29 06:04:18 2015
New Revision: 248788
URL: http://llvm.org/viewvc/llvm-project?rev=248788=rev
Log:
Change oat symbolization code for android to work on non-rooted devices
On android when debugging an apk we run lldb-server as application user
because the sell
tberghammer created this revision.
tberghammer added a reviewer: jasonmolenda.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
.ARM.exidx/.ARM.extab sections contain unwind information used on ARM
architecture from unwinding from an exception.
KLapshin marked an inline comment as done.
KLapshin added a comment.
m_lldbResult usage has beed removed in ExecRun::Acknowledge() method,
corresponding member removed from cmd class.
Repository:
rL LLVM
http://reviews.llvm.org/D12977
___
labath added a subscriber: labath.
labath added a comment.
I don't know much about the arm unwind info, but I have some style comments
from a casual read-through.
Comment at: include/lldb/Symbol/UnwindTable.h:71
@@ -67,4 +70,3 @@
-DWARFCallFrameInfo* m_eh_frame;
-
zturner added a comment.
This looks great. This has always really annoyed me. One thing I want to
point out based on your summary of the patch. A user *must* build Python
himself, even if he is building a release version of LLDB. You *cannot* use
the version that is installed on the
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D13245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jasonmolenda added a comment.
Looks good to me, I don't have anything beyond Pavel's suggestions. I don't
know the format of the ARM .exidx .extab unwind info so I don't have any
feedback on the parsing of that.
I forgot about that code in RegisterContextLLDB::GetFullUnwindPlanForFrame()
for
tfiala updated this revision to Diff 36043.
tfiala added a comment.
Fixes for Windows per previous comments, for posterity's sake.
This is the patch I will be committing.
http://reviews.llvm.org/D13124
Files:
test/dosep.py
test/test_runner/README.txt
test/test_runner/lib/lldb_utils.py
tfiala closed this revision.
tfiala added a comment.
Committed here:
svn commit
Sendingtest/dosep.py
Adding test/test_runner
Adding test/test_runner/README.txt
Adding test/test_runner/lib
Adding test/test_runner/lib/lldb_utils.py
Adding
sas created this revision.
sas added a reviewer: clayborg.
sas added a subscriber: lldb-commits.
We were missing the symbol for the version number.
http://reviews.llvm.org/D13271
Files:
cmake/LLDBDependencies.cmake
source/CMakeLists.txt
Index: source/CMakeLists.txt
Author: tfiala
Date: Tue Sep 29 17:19:06 2015
New Revision: 248834
URL: http://llvm.org/viewvc/llvm-project?rev=248834=rev
Log:
test runner: switch to pure-Python timeout mechanism
The timeout mechanism has been implemented in python,
so there is no more dependence on external utilities
for
Author: spyffe
Date: Tue Sep 29 17:52:50 2015
New Revision: 248842
URL: http://llvm.org/viewvc/llvm-project?rev=248842=rev
Log:
Removed a bunch of dependencies of Materializer on ClangUserExpression.
Instead we now just generically use UserExpression.
Modified:
dawn added a subscriber: lldb-commits.
Users:
paulherman (Author)
http://reviews.llvm.org/rL247836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda added a comment.
Greg's out this week, he or Jim may want to comment.
I was curious about this method IncrementFalseAlarmsAndReviseHitCount, there
weren't any calls to it. A little digging shows that the one use of it was
removed in
Does timeout not work?
On Tue, Sep 29, 2015 at 4:06 PM, Todd Fiala via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: tfiala
> Date: Tue Sep 29 18:06:56 2015
> New Revision: 248846
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248846=rev
> Log:
> Skipping TestAttachDenied.py on
dawn accepted this commit.
dawn added a comment.
> Clang (the LLDB compiler) does not ask for the value ScNSpacGl in the global
> namespace, but just for a value named ScNSpacGl.
Ok, I've opened a separate bug for this then,
https://llvm.org/bugs/show_bug.cgi?id=24994.
Users:
paulherman
Can you add a test for this?
On Tue, Sep 29, 2015 at 5:41 PM Jason Molenda via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> jasonmolenda added a subscriber: jasonmolenda.
> jasonmolenda added a comment.
>
> Greg's out this week, he or Jim may want to comment.
>
> I was curious about this
zturner added a subscriber: zturner.
zturner added a comment.
Can you add a test for this?
Repository:
rL LLVM
http://reviews.llvm.org/D13241
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn added a subscriber: dawn.
dawn added a comment.
Bug https://llvm.org/bugs/show_bug.cgi?id=24995 opened for "regressions" after
this commit.
Users:
paulherman (Author)
http://reviews.llvm.org/rL247836
___
lldb-commits mailing list
mohit.bhakkad added a comment.
Jason, in MIPS watch registers, last 3 bits of watchpoint addresses are masked
by IRW(instruction, read, write types) flags,
so machine gives exception for any address having other bits same to the actual
watch address execept last 3 bits.
Comment at line number
dawn added a subscriber: lldb-commits.
Users:
paulherman (Author)
http://reviews.llvm.org/rL247746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Hey Zachary,
Have you seen diff 5 or diff 6 on Windows yet? What results did you get? I
think I'm just waiting on a clean Windows run at this point.
Thanks!
-Todd
http://reviews.llvm.org/D13124
___
lldb-commits mailing
tfiala added a comment.
> Does that look right to you?
That result looks right - the two soft terminate tests get skipped when it's
not reported.
If you ran the lldb test suite with that setup, they should work as well as
they did before the change. (If they don't, I'm missing a lower level
ribrdb created this revision.
ribrdb added a reviewer: tfiala.
ribrdb added a subscriber: lldb-commits.
ribrdb set the repository for this revision to rL LLVM.
This implements basic line editing for the interactive python interpreter on
linux.
No tab completion, but at least backspace works.
30 matches
Mail list logo
