Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

evgeny777 updated this revision to Diff 36341. evgeny777 added a comment. Changed DoesPrintValue() function prototype http://reviews.llvm.org/D13058 Files: include/lldb/API/SBTypeSummary.h source/API/SBTypeSummary.cpp test/tools/lldb-mi/variable/TestMiGdbSetShowPrint.py

[Lldb-commits] [lldb] r249120 - Change expected stop reason in TestInferiorAssert for Android API <= 16

Author: tberghammer Date: Fri Oct 2 07:00:04 2015 New Revision: 249120 URL: http://llvm.org/viewvc/llvm-project?rev=249120=rev Log: Change expected stop reason in TestInferiorAssert for Android API <= 16 Modified: lldb/trunk/test/functionalities/inferior-assert/TestInferiorAssert.py

Re: [Lldb-commits] [PATCH] D13362: Enhance test runner timeout logic to detect successful completion of spawned process when stdout/stderr are shared to still-existing child processes

labath added a comment. In http://reviews.llvm.org/D13362#258314, @tfiala wrote: > The OS X one seems to be related to load (not terribly surprising). I'm > seeing timeouts as I crank up the --threads. But I don't think that's the > whole story. On the Linux side, I've been cranking down

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

evgeny777 added inline comments. Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:372 @@ +371,3 @@ +CMIUtilString +CMICmnLLDBUtilSBValue::GetValueSummary() const +{ granata.enrico wrote: > I might be missing something, but how is this going to work when an

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

On 1 October 2015 at 23:09, Kamil Rytarowski via lldb-commits wrote: > > Yes, please! Better incomplete support in the source trees then once > almost complete but rotting in a local patch... I agree - I think it's better to get basic support in as soon as possible

[Lldb-commits] [lldb] r249119 - Fix several issues around .ARM.exidx section handling

Author: tberghammer Date: Fri Oct 2 06:58:26 2015 New Revision: 249119 URL: http://llvm.org/viewvc/llvm-project?rev=249119=rev Log: Fix several issues around .ARM.exidx section handling * Use .ARM.exidx as a fallback unwind plan for non-call site when the instruction emulation based unwind

Re: [Lldb-commits] [PATCH] D13380: Fix several issues around .ARM.exidx section handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL249119: Fix several issues around .ARM.exidx section handling (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D13380?vs=36338=36343#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D13362: Enhance test runner timeout logic to detect successful completion of spawned process when stdout/stderr are shared to still-existing child processes

tfiala added a comment. > I think that is a reasonable course of action. Having three threads servicing > the same process seems wasteful/hard to maintain and has a very big race > potential. Yeah I'm not liking how complex this is getting. I'll have more comments once I address the other

[Lldb-commits] LLVM buildnaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 6 PM Pacific time today. Sorry for the noise. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

granata.enrico accepted this revision. granata.enrico added a comment. I am not deeply involved in MI internals, so I am going to assume you ran the test suite, and that you actually verified that types without summaries still work In general, once you opt into data formatters, you get a lot

[Lldb-commits] [lldb] r249167 - Made GetScratchTypeSystemForLanguage return an error if desired.

Author: spyffe Date: Fri Oct 2 13:40:30 2015 New Revision: 249167 URL: http://llvm.org/viewvc/llvm-project?rev=249167=rev Log: Made GetScratchTypeSystemForLanguage return an error if desired. Also made it not store nullptrs in its TypeSystemMap, so it will retry to make the AST context if it

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

dawn added a comment. This patch is good to commit now right? It's not marked "accepted" for some reason. http://reviews.llvm.org/D13058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

I Thought I had marked it as good to go. My bad if I have not. - Enrico Sent from my iPhone > On Oct 2, 2015, at 1:12 PM, Dawn Perchik wrote: > > dawn added a comment. > > This patch is good to commit now right? It's not marked "accepted" for some > reason. > > >

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

dawn added a comment. > You can use clang-format to follow the LLDB coding style, or just do the > following: So we've been telling folks to use clang-format, but it's not working correctly (my version is clang-format version 3.6.0 (217927)). It's turns: bool DoesPrintValue

[Lldb-commits] [lldb] r249182 - Fix race on subprocess.Popen return values.

Author: tfiala Date: Fri Oct 2 15:51:11 2015 New Revision: 249182 URL: http://llvm.org/viewvc/llvm-project?rev=249182=rev Log: Fix race on subprocess.Popen return values. This fixes: https://llvm.org/bugs/show_bug.cgi?id=25019 Modified: lldb/trunk/test/test_runner/lib/process_control.py

Re: [Lldb-commits] [PATCH] D13362: Enhance test runner timeout logic to detect successful completion of spawned process when stdout/stderr are shared to still-existing child processes

tfiala abandoned this revision. tfiala added a comment. I've fixed: https://llvm.org/bugs/show_bug.cgi?id=25019 I think for now I am not interested in trying to tackle the intent of this change as it unduly complicates the timeout detection logic. I am okay with saying: "If you run a process

[Lldb-commits] [lldb] r249185 - Add hooks that enable NSSet, NSDictionary and NSString formatting to apply to other types beyond the well-known ones

Author: enrico Date: Fri Oct 2 15:59:58 2015 New Revision: 249185 URL: http://llvm.org/viewvc/llvm-project?rev=249185=rev Log: Add hooks that enable NSSet, NSDictionary and NSString formatting to apply to other types beyond the well-known ones This is meant to support languages that can do

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

zturner added a comment. Hi Vadim, when I run CMake with this change I get the following output: [1/1] Re-running CMake... - Warning: Did not find file Compiler/MSVC-ASM - Target triple: i686-pc-win32 - Native target architecture is X86 - Threads enabled. - Doxygen disabled. - Sphinx disabled.

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

Hi Tamas, This breaks TestBuiltinTrap on Windows. Do you have any insight about why this might be happening? That test is not modified at all by this patch from what I can tell, but a bisect pinpoints this CL as the reason for the failure. On Thu, Oct 1, 2015 at 1:05 AM Ed Maste

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

zturner added a comment. Hi Tamas, This breaks TestBuiltinTrap on Windows. Do you have any insight about why this might be happening? That test is not modified at all by this patch from what I can tell, but a bisect pinpoints this CL as the reason for the failure. Repository: rL LLVM

[Lldb-commits] [lldb] r249203 - Fix TestCompDirSymLink.py - remove existing symlink leftovers if previous test run

Author: ovyalov Date: Fri Oct 2 17:37:55 2015 New Revision: 249203 URL: http://llvm.org/viewvc/llvm-project?rev=249203=rev Log: Fix TestCompDirSymLink.py - remove existing symlink leftovers if previous test run was terminated (e.g., due timeout). Modified:

[Lldb-commits] [lldb] r249208 - Updated xfail / skip status on a few tests.

Author: zturner Date: Fri Oct 2 17:47:28 2015 New Revision: 249208 URL: http://llvm.org/viewvc/llvm-project?rev=249208=rev Log: Updated xfail / skip status on a few tests. TestDiamond and TestSBValueCast were due to a bug in clang. That bug has been fixed, so xfail is removed. However fixing

[Lldb-commits] [lldb] r249209 - Re-disable TestBuiltinTrap on Windows.

Author: zturner Date: Fri Oct 2 17:47:37 2015 New Revision: 249209 URL: http://llvm.org/viewvc/llvm-project?rev=249209=rev Log: Re-disable TestBuiltinTrap on Windows. This was inadvertently re-enabled as a in r248883. Modified: lldb/trunk/test/linux/builtin_trap/TestBuiltinTrap.py

Re: [Lldb-commits] [PATCH] D13404: Teach CMake to find versions of Python != 2.7

On Fri, Oct 2, 2015 at 5:54 PM Zachary Turner wrote: > > Note that I'm claiming with this revision that LLDB itself works with > Python versions other than 2.7. s/claiming/*not* claiming/ ___ lldb-commits mailing list

[Lldb-commits] [lldb] r249210 - Do not attempt to join the remote paths if none exist

Author: enrico Date: Fri Oct 2 17:53:32 2015 New Revision: 249210 URL: http://llvm.org/viewvc/llvm-project?rev=249210=rev Log: Do not attempt to join the remote paths if none exist Modified: lldb/trunk/test/lldbtest.py Modified: lldb/trunk/test/lldbtest.py URL:

[Lldb-commits] [lldb] r249207 - Remove instance reference of static member function.

Author: zturner Date: Fri Oct 2 17:47:14 2015 New Revision: 249207 URL: http://llvm.org/viewvc/llvm-project?rev=249207=rev Log: Remove instance reference of static member function. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Modified:

[Lldb-commits] [PATCH] D13404: Teach CMake to find versions of Python != 2.7

zturner created this revision. zturner added a reviewer: enlight. zturner added a subscriber: lldb-commits. Hi Vadim, Would you mind taking a look at this? My CMake-fu is only level 5, so if you have any suggestions on how to improve this, let me know. Note that I'm claiming with this

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

enlight added a comment. That looks fine to me. CMake prints those messages during the configuration step, at that point the generator expressions haven't been expanded yet. I could prettify those messages a bit to read: `Found PythonLibs: C:/Python27_LLDB/x86/libs/python27_d.lib and

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

Yea that's what I meant. Everything works, but the configuration step is supposed to print out stuff that people can read at a glance. So prettifying it would be desirable. On Fri, Oct 2, 2015 at 10:39 PM Vadim Macagon wrote: > enlight added a comment. > > That looks