Re: [Lldb-commits] [lldb] r249507 - Route the preferred-display-language mechanism to the ValueObjectPrinter and actually fill in a few gaps for dynamic and synthetic values to be able to adopt this i

I am not done here. Also, even once I am done, all that you will be able to see here is no regressions in existing functionality. I am plumbing through a set of facilities that I need in order to make certain parts of data formatting logic Language-plugin based. That is required to make it

[Lldb-commits] [lldb] r249421 - Reduce load on TestMultipleDebuggers.

Author: tfiala Date: Tue Oct 6 10:33:51 2015 New Revision: 249421 URL: http://llvm.org/viewvc/llvm-project?rev=249421=rev Log: Reduce load on TestMultipleDebuggers. 4-core CPUs have a hard time keeping up with the number of debuggers we were simultaneously spawning. This leads to a timeout,

[Lldb-commits] [lldb] r249407 - Rename a test case to avoid name conflict

Author: tberghammer Date: Tue Oct 6 09:39:05 2015 New Revision: 249407 URL: http://llvm.org/viewvc/llvm-project?rev=249407=rev Log: Rename a test case to avoid name conflict Rename the python source file for DataFormatterOSTypeTestCase to match the purpose of the test and to avoid a name

Re: [Lldb-commits] [PATCH] D13448: Update swig generation shell scripts to run under Python 3.x

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. I saw no issues on Ubuntu 14.04 x86_64 and the changes all look reasonable. http://reviews.llvm.org/D13448 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r249419 - Switching TestCallUserDefinedFunction from xfail to flaky on OS X.

Author: tfiala Date: Tue Oct 6 10:23:52 2015 New Revision: 249419 URL: http://llvm.org/viewvc/llvm-project?rev=249419=rev Log: Switching TestCallUserDefinedFunction from xfail to flaky on OS X. This is passing 50/50 times for me. Moving to flaky as precautionary measure. Modified:

Re: [Lldb-commits] [lldb] r249379 - Bug 25050: X87 FPU Special Purpose Registers

I had submitted a patch for the Bug 24457 which is similar kind of bug but on Linux x86_64 Platform. There, I had submitted a new test to reproduce this issue. The test is already there in public repository. Since, the same test goes for FreeBSD also therefore I didn’t need to write a new one.

Re: [Lldb-commits] [lldb] r249507 - Route the preferred-display-language mechanism to the ValueObjectPrinter and actually fill in a few gaps for dynamic and synthetic values to be able to adopt this i

It looks like there's only 1 test added for all of this functionality from this and the last few commits, and that the test is specific to Objective C. The functionality itself seems language agnostic though. Is there any way to write a test that does not rely on a particular language? That

Re: [Lldb-commits] [lldb] r249507 - Route the preferred-display-language mechanism to the ValueObjectPrinter and actually fill in a few gaps for dynamic and synthetic values to be able to adopt this i

Actually upon further inspection it looks like the test that was updated was not really anything new, but an update of an existing test to pass a new argument through. Can you add some tests that test this specific functionality? On Tue, Oct 6, 2015 at 9:09 PM Zachary Turner

[Lldb-commits] [lldb] r249434 - Fix Darwin build of lldb-server.

Author: sas Date: Tue Oct 6 13:03:04 2015 New Revision: 249434 URL: http://llvm.org/viewvc/llvm-project?rev=249434=rev Log: Fix Darwin build of lldb-server. Summary: We were missing the symbol for the version number. Reviewers: clayborg Subscribers: lldb-commits Differential Revision:

[Lldb-commits] [lldb] r249433 - Create a logging category that is specific to data formatters activity

Author: enrico Date: Tue Oct 6 12:55:14 2015 New Revision: 249433 URL: http://llvm.org/viewvc/llvm-project?rev=249433=rev Log: Create a logging category that is specific to data formatters activity Modified: lldb/trunk/include/lldb/Core/Logging.h lldb/trunk/source/Core/FormatEntity.cpp

Re: [Lldb-commits] [PATCH] D13271: Fix Darwin build of lldb-server.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249434: Fix Darwin build of lldb-server. (authored by sas). Changed prior to commit: http://reviews.llvm.org/D13271?vs=36035=36638#toc Repository: rL LLVM http://reviews.llvm.org/D13271 Files:

[Lldb-commits] [lldb] r249448 - Bungled my last change in a tweak.

Author: tfiala Date: Tue Oct 6 14:23:22 2015 New Revision: 249448 URL: http://llvm.org/viewvc/llvm-project?rev=249448=rev Log: Bungled my last change in a tweak. I took out a skip_test check that wasn't necessary, but didn't fully yank it out. Would break a normal go install. Modified:

Re: [Lldb-commits] [PATCH] D13268: Simple readline functionality for interactive python on linux.

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. Thanks, Ryan! Repository: rL LLVM http://reviews.llvm.org/D13268 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r249446 - Address failing Go tests on go version from Ubuntu 14.04

Author: tfiala Date: Tue Oct 6 14:15:56 2015 New Revision: 249446 URL: http://llvm.org/viewvc/llvm-project?rev=249446=rev Log: Address failing Go tests on go version from Ubuntu 14.04 Go tests fail on Ubuntu 14.04's go1.2.1. This change puts a minimum go version in the skipUnlessGoInstalled()

Re: [Lldb-commits] [PATCH] D13463: Remove GetShortPluginName.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249452: Remove GetShortPluginName. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13463?vs=36602=36649#toc Repository: rL LLVM http://reviews.llvm.org/D13463 Files:

[Lldb-commits] [lldb] r249452 - Remove GetShortPluginName.

Author: brucem Date: Tue Oct 6 15:15:27 2015 New Revision: 249452 URL: http://llvm.org/viewvc/llvm-project?rev=249452=rev Log: Remove GetShortPluginName. Summary: This was deprecated and removed. Reviewers: clayborg Subscribers: lldb-commits Differential Revision:

Re: [Lldb-commits] [lldb] r249446 - Address failing Go tests on go version from Ubuntu 14.04

Okay, I can adjust that. On Tue, Oct 6, 2015 at 1:24 PM, Ryan Brown wrote: > I was wondering if we'd need this. Go 1.4 is the minimum supported version. > > On Tue, Oct 6, 2015 at 12:17 PM Todd Fiala via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> Author: tfiala

Re: [Lldb-commits] [lldb] r249446 - Address failing Go tests on go version from Ubuntu 14.04

Changed this here: Sendingtest/lldbtest.py Transmitting file data . Committed revision 249477. Now requires a minimum of version 1.4.0. On Tue, Oct 6, 2015 at 1:52 PM, Todd Fiala wrote: > Okay, I can adjust that. > > On Tue, Oct 6, 2015 at 1:24 PM, Ryan Brown

Re: [Lldb-commits] [PATCH] D13149: Create GoLanguageRuntime

ribrdb closed this revision. ribrdb added a comment. Submitted in revisions 249456 and 249459. Repository: rL LLVM http://reviews.llvm.org/D13149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r249467 - Update swig generation scripts to support Python 3.

Author: zturner Date: Tue Oct 6 16:11:28 2015 New Revision: 249467 URL: http://llvm.org/viewvc/llvm-project?rev=249467=rev Log: Update swig generation scripts to support Python 3. Modified: lldb/trunk/scripts/Python/buildSwigPython.py lldb/trunk/scripts/Python/modify-python-lldb.py

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

zturner added a comment. My change to support Python 3 is in. Now that that's in, would you mind trying to prettify the output messages when you get a chance? Repository: rL LLVM http://reviews.llvm.org/D13234 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r249477 - Modify minimumg go version to 1.4.0 for tests.

Author: tfiala Date: Tue Oct 6 17:14:33 2015 New Revision: 249477 URL: http://llvm.org/viewvc/llvm-project?rev=249477=rev Log: Modify minimumg go version to 1.4.0 for tests. Modified: lldb/trunk/test/lldbtest.py Modified: lldb/trunk/test/lldbtest.py URL:

[Lldb-commits] [lldb] r249381 - [MIPS] Emulate microMIPS instructions

Author: bhushan.attarde Date: Tue Oct 6 03:52:08 2015 New Revision: 249381 URL: http://llvm.org/viewvc/llvm-project?rev=249381=rev Log: [MIPS] Emulate microMIPS instructions SUMMARY: This patch includes: 1. Emulation of prologue/epilogue and branch instructions for microMIPS.

[Lldb-commits] [lldb] r249506 - Enable the StringPrinter to have prefixes that are strings instead of just a single character; and also introduce a comparable suffix mechanism

Author: enrico Date: Tue Oct 6 21:06:48 2015 New Revision: 249506 URL: http://llvm.org/viewvc/llvm-project?rev=249506=rev Log: Enable the StringPrinter to have prefixes that are strings instead of just a single character; and also introduce a comparable suffix mechanism Modified:

[Lldb-commits] [lldb] r249507 - Route the preferred-display-language mechanism to the ValueObjectPrinter and actually fill in a few gaps for dynamic and synthetic values to be able to adopt this in us

Author: enrico Date: Tue Oct 6 21:36:35 2015 New Revision: 249507 URL: http://llvm.org/viewvc/llvm-project?rev=249507=rev Log: Route the preferred-display-language mechanism to the ValueObjectPrinter and actually fill in a few gaps for dynamic and synthetic values to be able to adopt this in

Re: [Lldb-commits] [Diffusion] rL247968: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

dawn added a comment. This test is still failing. Can you please have a look? Thanks. Users: jaydeep (Author) dawn (Auditor) http://reviews.llvm.org/rL247968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r249503 - Introduce a variant of GetSummaryAsCString() that takes a LanguageType argument, and use it when crafting summaries by running selectors

Author: enrico Date: Tue Oct 6 20:41:23 2015 New Revision: 249503 URL: http://llvm.org/viewvc/llvm-project?rev=249503=rev Log: Introduce a variant of GetSummaryAsCString() that takes a LanguageType argument, and use it when crafting summaries by running selectors This is the first in a series

[Lldb-commits] [PATCH] D13462: Fix virtual/override warnings in new MIPS code.

brucem created this revision. brucem added reviewers: bhushan, tberghammer. brucem added a subscriber: lldb-commits. http://reviews.llvm.org/D13462 Files: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h Index: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h

[Lldb-commits] [PATCH] D13463: Remove GetShortPluginName.

brucem created this revision. brucem added a reviewer: clayborg. brucem added a subscriber: lldb-commits. This was deprecated and removed. http://reviews.llvm.org/D13463 Files: source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h

[Lldb-commits] [lldb] r249387 - Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile()

Author: brucem Date: Tue Oct 6 05:17:34 2015 New Revision: 249387 URL: http://llvm.org/viewvc/llvm-project?rev=249387=rev Log: Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile() Summary: When `module_spec.GetFileSpec().GetDirectory().AsCString()` returned a `nullptr`

Re: [Lldb-commits] [PATCH] D13462: Fix virtual/override warnings in new MIPS code.

labath added a subscriber: labath. labath accepted this revision. labath added a reviewer: labath. labath added a comment. This revision is now accepted and ready to land. I think you can commit things like this as obvious. :) http://reviews.llvm.org/D13462

Re: [Lldb-commits] [PATCH] D13462: Fix virtual/override warnings in new MIPS code.

tberghammer accepted this revision. tberghammer added a comment. I agree with Pavel, that you don't have to send these trivial changes for core review http://reviews.llvm.org/D13462 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13268: Simple readline functionality for interactive python on linux.

ribrdb updated this revision to Diff 36637. Repository: rL LLVM http://reviews.llvm.org/D13268 Files: CMakeLists.txt scripts/Python/modules/readline/CMakeLists.txt scripts/Python/modules/readline/readline.cpp source/CMakeLists.txt Index: source/CMakeLists.txt

[Lldb-commits] [lldb] r249405 - Fix virtual/override warnings in new MIPS code.

Author: brucem Date: Tue Oct 6 09:19:32 2015 New Revision: 249405 URL: http://llvm.org/viewvc/llvm-project?rev=249405=rev Log: Fix virtual/override warnings in new MIPS code. Reviewers: bhushan, tberghammer Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D13462

Re: [Lldb-commits] [PATCH] D13462: Fix virtual/override warnings in new MIPS code.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249405: Fix virtual/override warnings in new MIPS code. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13462?vs=36601=36622#toc Repository: rL LLVM