[Lldb-commits] [lldb] r250531 - Fix linkage of `init_lldb` SWIG method in Python 3.

2015-10-16 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Oct 16 12:52:03 2015 New Revision: 250531 URL: http://llvm.org/viewvc/llvm-project?rev=250531=rev Log: Fix linkage of `init_lldb` SWIG method in Python 3. Modified: lldb/trunk/source/API/SystemInitializerFull.cpp

[Lldb-commits] [lldb] r250530 - Convert SWIG typemap string operations to PythonObjects.

2015-10-16 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Oct 16 12:51:49 2015 New Revision: 250530 URL: http://llvm.org/viewvc/llvm-project?rev=250530=rev Log: Convert SWIG typemap string operations to PythonObjects. Modified: lldb/trunk/scripts/Python/python-typemaps.swig

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method HasChildAtIndex.

2015-10-16 Thread Siva Chandra via lldb-commits
sivachandra added a comment. When such an error occurs, it is unlikely to be an lldb bug, or data-formatter bug. One can come up with a data structure for which reading a child element would require complete debug info, but reading the # of child elements need not require complete debug info

Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

2015-10-16 Thread Enrico Granata via lldb-commits
granata.enrico added inline comments. Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:37 @@ +36,3 @@ +return false; +stream.Printf("%d %s", (int)value.GetValueAsSigned(), value.GetValue()); +return true; I would definitely not stop the revision

Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

2015-10-16 Thread Enrico Granata via lldb-commits
granata.enrico added inline comments. Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:835 @@ +834,3 @@ + +if (!MI_add_summary(miCategory, "char", MI_char_summary_provider, +lldb::eTypeOptionHideValue | lldb::eTypeOptionSkipPointers))

[Lldb-commits] [lldb] r250533 - Make some more of the LLDB/SWIG/Python glue Python 3 aware.

2015-10-16 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Oct 16 12:52:32 2015 New Revision: 250533 URL: http://llvm.org/viewvc/llvm-project?rev=250533=rev Log: Make some more of the LLDB/SWIG/Python glue Python 3 aware. Mostly this is just converting some print statements to print functions. Modified:

Re: [Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

2015-10-16 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I would rather you be able to ask the current platform for the default memory cache line size and have lldb_private::Process do this automatically on the first memory read if

[Lldb-commits] [PATCH] D13830: [LLDB] Fix Clang-tidy modernize-use-override warnings in some headers in source/Plugins/Process/Utility; other minor fixes.

2015-10-16 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: brucem, labath, clayborg. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: emaste. I checked this patch on my own build on RHEL 6.

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method HasChildAtIndex.

2015-10-16 Thread Siva Chandra via lldb-commits
sivachandra updated this revision to Diff 37630. sivachandra added a comment. Address comments. http://reviews.llvm.org/D13778 Files: include/lldb/API/SBValue.h include/lldb/Core/ValueObject.h include/lldb/Core/ValueObjectCast.h include/lldb/Core/ValueObjectChild.h

[Lldb-commits] [lldb] r250499 - Resubmit: RenderScript command for printing allocation contents

2015-10-16 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Fri Oct 16 03:28:47 2015 New Revision: 250499 URL: http://llvm.org/viewvc/llvm-project?rev=250499=rev Log: Resubmit: RenderScript command for printing allocation contents Previous commit r250281 broke TestDataFormatterSmartArray.py Resolved in in this patch by adding

Re: [Lldb-commits] [PATCH] D13730: Resubmit: RenderScript command for printing allocation contents

2015-10-16 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250499: Resubmit: RenderScript command for printing allocation contents (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D13730?vs=37356=37562#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D13754: Split Socket class into Tcp/Udp/DomainSocket subclasses.

2015-10-16 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: source/Host/posix/DomainSocket.cpp:74 @@ +73,3 @@ +FileSystem::Unlink(FileSpec{name, true}); + +Error error; If we're going to use unique names, then this won't be necessary (and I would much rather see a random

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method HasChildAtIndex.

2015-10-16 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath added a comment. Not really my area, but couldn't the needed functionality be implemented on top of GetChildAtIndex(). I mean, if GetChildAtIndex(50) returns a valid SBValue, then the container has at least 50 elements, right? Then

[Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

2015-10-16 Thread Eugene Leviant via lldb-commits
evgeny777 created this revision. evgeny777 added reviewers: granata.enrico, ki.stfu, abidh. evgeny777 added subscribers: lldb-commits, KLapshin. Current revision do not use lldb type summaries for simple types with no children (like function pointers). So this patch makes MI use lldb type

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

2015-10-16 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 37566. tberghammer added a comment. Create optional std::async based implementation http://reviews.llvm.org/D13727 Files: include/lldb/Utility/TaskPool.h source/Utility/CMakeLists.txt source/Utility/TaskPool.cpp unittests/Utility/CMakeLists.txt

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

2015-10-16 Thread Pavel Labath via lldb-commits
labath added a comment. Zachary, I don't think using std::async is a good idea because it provides a very different threading model than the one we want here. Let me demonstrate that with an example: #include #include #include #include #include using namespace std;

[Lldb-commits] [lldb] r250502 - Fix temporary directory computation on linux (pr25147)

2015-10-16 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Oct 16 04:32:05 2015 New Revision: 250502 URL: http://llvm.org/viewvc/llvm-project?rev=250502=rev Log: Fix temporary directory computation on linux (pr25147) Summary: On linux, the environment variables for temp directories that lldb checks for are generally not

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method HasChildAtIndex.

2015-10-16 Thread Siva Chandra via lldb-commits
sivachandra added a comment. There could be an error reading the k-th element for k < n.In which case, we will wrongly conclude that there are only k-1 elements. http://reviews.llvm.org/D13778 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

2015-10-16 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: clayborg, tberghammer. labath added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. ADB packets have a fixed size of 4k. This means the size of memory reads does not affect speed too much (as long as it

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method HasChildAtIndex.

2015-10-16 Thread Pavel Labath via lldb-commits
labath added a comment. How big of an error does it have to be for that to happen? Is that something we would consider an "lldb bug"/"data formatter bug" or it can be caused by something out of our control, like missing debug info on one of the children? http://reviews.llvm.org/D13778

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

2015-10-16 Thread Zachary Turner via lldb-commits
zturner added a comment. Sorry, should have mentioned that the lgtm is contingent on Todd's concerns. I like the idea of having a setting in LLDB that controls the maximum number of threads to use for parallel work. We should probably set this at a very h igh level in dotest so that all

[Lldb-commits] [lldb] r250576 - Skip hanging watchpoint test on Windows (rather than just xfailing).

2015-10-16 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Fri Oct 16 18:19:22 2015 New Revision: 250576 URL: http://llvm.org/viewvc/llvm-project?rev=250576=rev Log: Skip hanging watchpoint test on Windows (rather than just xfailing). Modified: lldb/trunk/test/python_api/watchpoint/condition/TestWatchpointConditionAPI.py

[Lldb-commits] [lldb] r250580 - Split getting the key from a window from the code that handles the key.

2015-10-16 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Oct 16 18:34:40 2015 New Revision: 250580 URL: http://llvm.org/viewvc/llvm-project?rev=250580=rev Log: Split getting the key from a window from the code that handles the key. Modified: lldb/trunk/test/lldbcurses.py Modified: lldb/trunk/test/lldbcurses.py URL:

[Lldb-commits] [lldb] r250581 - Handle eFormatVectorOfFloat16

2015-10-16 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Oct 16 18:42:04 2015 New Revision: 250581 URL: http://llvm.org/viewvc/llvm-project?rev=250581=rev Log: Handle eFormatVectorOfFloat16 Modified: lldb/trunk/source/Commands/CommandObjectMemory.cpp Modified: lldb/trunk/source/Commands/CommandObjectMemory.cpp URL:

[Lldb-commits] [PATCH] D13836: Fix write-after-close of file descriptor in ScriptInterpreterPython

2015-10-16 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added reviewers: clayborg, granata.enrico. zturner added a subscriber: lldb-commits. When we acquire the GIL with `Locker`, we save off the current stdio handles, redirect them, and when we release the GIL we put the old handles back. This triggers a

[Lldb-commits] [lldb] r250593 - [LLDB] Fix Clang-tidy modernize-use-override warnings in some headers in source/Plugins/Process/Utility; other minor fixes.

2015-10-16 Thread Eugene Zelenko via lldb-commits
Author: eugenezelenko Date: Fri Oct 16 19:19:57 2015 New Revision: 250593 URL: http://llvm.org/viewvc/llvm-project?rev=250593=rev Log: [LLDB] Fix Clang-tidy modernize-use-override warnings in some headers in source/Plugins/Process/Utility; other minor fixes. Differential Revision:

[Lldb-commits] [PATCH] D13840: [LLDB] Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins; other minor fixes.

2015-10-16 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: brucem, labath, clayborg. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Repository: rL LLVM

[Lldb-commits] [lldb] r250599 - Teach an old pony a few new tricks.

2015-10-16 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Oct 16 20:05:50 2015 New Revision: 250599 URL: http://llvm.org/viewvc/llvm-project?rev=250599=rev Log: Teach an old pony a few new tricks. ValueObjectPrinter can now mask out pointer values during a printout; also, it supports helper functions to print declarations in

[Lldb-commits] [lldb] r250567 - Move TypeSummaryImpl over to LLVM-style RTTI for subclassing

2015-10-16 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Oct 16 17:51:56 2015 New Revision: 250567 URL: http://llvm.org/viewvc/llvm-project?rev=250567=rev Log: Move TypeSummaryImpl over to LLVM-style RTTI for subclassing Modified: lldb/trunk/include/lldb/DataFormatters/TypeSummary.h

Re: [Lldb-commits] [PATCH] D13830: [LLDB] Fix Clang-tidy modernize-use-override warnings in some headers in source/Plugins/Process/Utility; other minor fixes.

2015-10-16 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250593: [LLDB] Fix Clang-tidy modernize-use-override warnings in some headers in… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D13830?vs=37634=37662#toc Repository:

Re: [Lldb-commits] [PATCH] D13754: Split Socket class into Tcp/Udp/DomainSocket subclasses.

2015-10-16 Thread Oleksiy Vyalov via lldb-commits
ovyalov added inline comments. Comment at: source/Host/posix/DomainSocket.cpp:74 @@ +73,3 @@ +FileSystem::Unlink(FileSpec{name, true}); + +Error error; labath wrote: > If we're going to use unique names, then this won't be necessary (and I would > much

[Lldb-commits] [lldb] r250525 - Update SWIG typemaps to use `PythonFile`.

2015-10-16 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Oct 16 11:39:18 2015 New Revision: 250525 URL: http://llvm.org/viewvc/llvm-project?rev=250525=rev Log: Update SWIG typemaps to use `PythonFile`. Using the Python native C API is non-portable across Python versions, so this patch changes them to use the `PythonFile`

[Lldb-commits] [PATCH] D13819: LLDBStandalone: Report nice errors on missing vars

2015-10-16 Thread Ramkumar Ramachandra via lldb-commits
artagnon created this revision. artagnon added reviewers: chaoren, brucem. artagnon added a subscriber: lldb-commits. http://reviews.llvm.org/D13819 Files: cmake/modules/LLDBStandalone.cmake Index: cmake/modules/LLDBStandalone.cmake