Re: [Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D14060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D14020: Port the python api decorator to use test categories

This revision was automatically updated to reflect the committed changes. Closed by commit rL251277: Port the python api decorator to use test categories (authored by labath). Changed prior to commit: http://reviews.llvm.org/D14020?vs=38235=38383#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

labath created this revision. labath added reviewers: tfiala, dawn, ki.stfu, abidh. labath added a subscriber: lldb-commits. This change deprecates -m/+m dotest options (the options are still recognized but they print an error message pointing to the new options) and adds a new lldb-mi test

[Lldb-commits] [lldb] r251282 - Fix a fission expression evaluation issue

Author: tberghammer Date: Mon Oct 26 05:53:58 2015 New Revision: 251282 URL: http://llvm.org/viewvc/llvm-project?rev=251282=rev Log: Fix a fission expression evaluation issue This fix should eliminate the duplicate definition errors when debug info is available in multiple dwo symbol file for

[Lldb-commits] [PATCH] D14089: Avoid using `..` in paths for include dirs.

sas created this revision. sas added reviewers: dawn, brucem. sas added a subscriber: lldb-commits. This breaks when using a symlink from llvm/tools/lldb to the lldb source tree, instead of cloning directly as a child. With this change, we can build properly, even when using links.

Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

ovyalov added a comment. In http://reviews.llvm.org/D14085#275442, @zturner wrote: > I'm not sure I agree with this change. The interface to programming with > socket is by definition a property of the Host operating system. It seems to > me like Host was already the correct place for this

Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

zturner added a comment. I think most of the time they are used in a Connection class, but I don't think it's necessarily guaranteed they will always be that way. I can think of at least one use case in the future where we will need to open a socket to a server we don't control and stream some

Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

clayborg added a comment. In http://reviews.llvm.org/D14085#275507, @zturner wrote: > I think most of the time they are used in a Connection class, but I don't > think it's necessarily guaranteed they will always be that way. > > I can think of at least one use case in the future where we will

Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

zturner added a comment. I still think implementation should be in Host as well. If the idea is to simplify the creation scheme, then you could create an enum: enum class SocketType { Tcp, Udp, UnixDomain }; and provide a static method on SocketBase like this: class

Re: [Lldb-commits] [lldb] r251340 - Clang module compilation options need to be per-platform.

FYI: This broke the Windows build (which doesn't have getuid), and the fix wasn't immediately obvious, so I reverted the change. Adrian. On Mon, Oct 26, 2015 at 1:33 PM, Sean Callanan via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: spyffe > Date: Mon Oct 26 15:33:24 2015 > New

[Lldb-commits] [PATCH] D14091: Remove some useless typedef's.

sas created this revision. sas added reviewers: clayborg, zturner. sas added a subscriber: lldb-commits. This does not have any functionnal difference but I found myself searching for 'struct RegisterInfo$' to find a definition and couldn't find it. The version without typedef seems more common

[Lldb-commits] [lldb] r251351 - Remove some useless typedef's.

Author: sas Date: Mon Oct 26 16:32:31 2015 New Revision: 251351 URL: http://llvm.org/viewvc/llvm-project?rev=251351=rev Log: Remove some useless typedef's. Summary: This does not have any functionnal difference but I found myself searching for 'struct RegisterInfo$' to find a definition and

Re: [Lldb-commits] [PATCH] D14091: Remove some useless typedef's.

This revision was automatically updated to reflect the committed changes. Closed by commit rL251351: Remove some useless typedef's. (authored by sas). Changed prior to commit: http://reviews.llvm.org/D14091?vs=38455=38464#toc Repository: rL LLVM http://reviews.llvm.org/D14091 Files:

Re: [Lldb-commits] [PATCH] D14085: Add Socket::Create factory method which uses socket scheme (tcp, unix, ..) to find an appropriate implementation class.

zturner added a comment. Do we need this `GetScheme()` method? And instead of having `Create` take a string, couldn't it just take a `SocketProtocol` instead? It seems like the logic of converting the string to the enum should be done in the `Acceptor` class, as this URI format is defined by

[Lldb-commits] [lldb] r251377 - Minor cleanup of SBTypeSummary::CreateWithCallback to take an optional description argument

Author: enrico Date: Mon Oct 26 20:17:28 2015 New Revision: 251377 URL: http://llvm.org/viewvc/llvm-project?rev=251377=rev Log: Minor cleanup of SBTypeSummary::CreateWithCallback to take an optional description argument Modified: lldb/trunk/include/lldb/API/SBTypeSummary.h

[Lldb-commits] [lldb] r251368 - Change TestTypeCompletion to not rely on std::string

Author: enrico Date: Mon Oct 26 18:39:12 2015 New Revision: 251368 URL: http://llvm.org/viewvc/llvm-project?rev=251368=rev Log: Change TestTypeCompletion to not rely on std::string On some combination of platform and c++ library, this dependency was causing the test to fail for reasons

Re: [Lldb-commits] [PATCH] D14085: Add Socket::Create factory method which uses socket scheme (tcp, unix, ..) to find an appropriate implementation class.

ovyalov retitled this revision from "Make Socket to support plugin interface" to "Add Socket::Create factory method which uses socket scheme (tcp, unix,..) to find an appropriate implementation class.". ovyalov updated the summary for this revision. ovyalov updated this revision to Diff 38484.

[Lldb-commits] [PATCH] D14101: Treat hostname in android URL as device id unless it matches "localhost"

ovyalov created this revision. ovyalov added reviewers: tberghammer, labath. ovyalov added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. We can connect to a device using various protocols (tcp, unix domain, abstract). Instead of adding new URL schemes (e.g.,

[Lldb-commits] [lldb] r251386 - Fix for Arm watchpoint cache corruption in case of ptrace failure

Author: omjavaid Date: Tue Oct 27 00:56:56 2015 New Revision: 251386 URL: http://llvm.org/viewvc/llvm-project?rev=251386=rev Log: Fix for Arm watchpoint cache corruption in case of ptrace failure Differential revision: http://reviews.llvm.org/D14051 Modified:

[Lldb-commits] [lldb] r251329 - Python 3: Convert uses of `callable(x)` to `six.callable(x)`.

Author: zturner Date: Mon Oct 26 13:48:24 2015 New Revision: 251329 URL: http://llvm.org/viewvc/llvm-project?rev=251329=rev Log: Python 3: Convert uses of `callable(x)` to `six.callable(x)`. Modified: lldb/trunk/test/dotest.py lldb/trunk/test/lldbcurses.py lldb/trunk/test/lldbtest.py

[Lldb-commits] [lldb] r251328 - Remove use of octal literals.

Author: zturner Date: Mon Oct 26 13:48:14 2015 New Revision: 251328 URL: http://llvm.org/viewvc/llvm-project?rev=251328=rev Log: Remove use of octal literals. Python 3 has a different syntax for octal literals than Python 2 and they are incompatible with each other. Six doesn't provide a

[Lldb-commits] [lldb] r251293 - [RenderScript] Add option to break on a specific kernel invocation

Author: ewancrawford Date: Mon Oct 26 09:04:37 2015 New Revision: 251293 URL: http://llvm.org/viewvc/llvm-project?rev=251293=rev Log: [RenderScript] Add option to break on a specific kernel invocation Adds option -c to the 'language renderscript kernel breakpoint set' command. Breaks

Re: [Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

tfiala accepted this revision. tfiala added a comment. LGTM. Who currently owns the MI tests (or system) these days? I suppose you are doing this to squelch them from failing on the buildbots. On our end, we see the MI tests fail fairly frequently, typically intermittently.

Re: [Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

labath added a comment. We have XFAILed MI tests that were failing on our linux build bot. Atm, I am seeing expected passes, so I might try enabling them soon... However, these tests are not remote-ready, so we have to skip them on the android built bots. http://reviews.llvm.org/D14060

[Lldb-commits] [lldb] r251303 - Convert deprecated unittest method names.

Author: zturner Date: Mon Oct 26 11:50:39 2015 New Revision: 251303 URL: http://llvm.org/viewvc/llvm-project?rev=251303=rev Log: Convert deprecated unittest method names. Plural methods were long deprecated, and in Python 3 they are gone. Convert to the actual supported method names. Modified:

[Lldb-commits] [lldb] r251305 - Convert `long` to `int`, and portably detect all integral types.

Author: zturner Date: Mon Oct 26 11:51:09 2015 New Revision: 251305 URL: http://llvm.org/viewvc/llvm-project?rev=251305=rev Log: Convert `long` to `int`, and portably detect all integral types. Modified: lldb/trunk/test/functionalities/abbreviation/TestCommonShortSpellings.py

[Lldb-commits] [lldb] r251308 - Fix tabs and spaces in one of the python files.

Author: zturner Date: Mon Oct 26 11:51:36 2015 New Revision: 251308 URL: http://llvm.org/viewvc/llvm-project?rev=251308=rev Log: Fix tabs and spaces in one of the python files. Modified: lldb/trunk/examples/synthetic/gnu_libstdcpp.py Modified: lldb/trunk/examples/synthetic/gnu_libstdcpp.py

[Lldb-commits] [lldb] r251310 - Re-use prologue parsing code that was already written instead of having two copies of code that parse line table prologues.

Author: gclayton Date: Mon Oct 26 12:16:50 2015 New Revision: 251310 URL: http://llvm.org/viewvc/llvm-project?rev=251310=rev Log: Re-use prologue parsing code that was already written instead of having two copies of code that parse line table prologues. Also since we always read in the DWARF

[Lldb-commits] [lldb] r251309 - Fix Clang-tidy modernize-use-override warnings in some files in source; other minor fixes.

Author: eugenezelenko Date: Mon Oct 26 12:00:13 2015 New Revision: 251309 URL: http://llvm.org/viewvc/llvm-project?rev=251309=rev Log: Fix Clang-tidy modernize-use-override warnings in some files in source; other minor fixes. Modified: lldb/trunk/source/Core/IOHandler.cpp

Re: [Lldb-commits] [PATCH] D14083: Fix race condition in process resume

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good as long as we always want to send the broadcast even if the continue packet fails to send. Comment at:

[Lldb-commits] [lldb] r251301 - [lldb-server] Send PC of every thread along in the stop-reply packet

Author: labath Date: Mon Oct 26 11:25:28 2015 New Revision: 251301 URL: http://llvm.org/viewvc/llvm-project?rev=251301=rev Log: [lldb-server] Send PC of every thread along in the stop-reply packet This avoids the need to query the PC for private resume operations (public resumes have the PC

[Lldb-commits] [lldb] r251302 - Fix usages of range() and xrange() for Python 3.

Author: zturner Date: Mon Oct 26 11:49:57 2015 New Revision: 251302 URL: http://llvm.org/viewvc/llvm-project?rev=251302=rev Log: Fix usages of range() and xrange() for Python 3. Modified: lldb/trunk/test/example/TestSequenceFunctions.py

[Lldb-commits] [PATCH] D14083: Fix race condition in process resume

labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. Gdb-remote's async thread sent out the eBroadcastBitRunPacketSent message *before* actually sending out the continue packet. Since it's this message the actually triggers the public state

Re: [Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

tfiala added a comment. In http://reviews.llvm.org/D14060#275211, @labath wrote: > We have XFAILed MI tests that were failing on our linux build bot. Atm, I am > seeing expected passes, so I might try enabling them soon... I have been seeing them fail intermittently on both OS X and Ubuntu

[Lldb-commits] [PATCH] D14088: Some minor improvements on the symtab parsing code

tberghammer created this revision. tberghammer added a reviewer: clayborg. tberghammer added a subscriber: lldb-commits. Some minor improvements on the symtab parsing code * Remove an unnecessary re-computation on arch spec from the ELF file * Use a local cache to optimize name based section