Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

dawn added a subscriber: dawn. dawn added a reviewer: evgeny777. dawn added a comment. Eugene has been doing some work in this area - perhaps he can accept this patch for you. http://reviews.llvm.org/D12809 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r252521 - Avoid sending bare '*' and '}' in an lldb-server packet

Author: tnorthover Date: Mon Nov 9 16:05:05 2015 New Revision: 252521 URL: http://llvm.org/viewvc/llvm-project?rev=252521=rev Log: Avoid sending bare '*' and '}' in an lldb-server packet They get treated as special RLE encoding symbols and packets get corrupted. Most other packet types already

Re: [Lldb-commits] [lldb] r252381 - Python 3 - Don't use unbuffered I/O in text mode.

Hmm, ok. I'll loop back around to this when I get some cycles. Still working on Python 3 stuff so I don't think this will fall off my radar On Mon, Nov 9, 2015 at 12:56 PM Todd Fiala wrote: > The reason you probably want this unbuffered is for cases where you > crash.

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

dawn added a subscriber: dawn. dawn closed this revision. dawn added a comment. This was committed in svn r251820. Repository: rL LLVM http://reviews.llvm.org/D13073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r252516 - Extend the TypeSystem's ShouldPrintAsOneLiner implementation so that the ValueObject itself also gets a say in the process; NFC

Author: enrico Date: Mon Nov 9 15:28:55 2015 New Revision: 252516 URL: http://llvm.org/viewvc/llvm-project?rev=252516=rev Log: Extend the TypeSystem's ShouldPrintAsOneLiner implementation so that the ValueObject itself also gets a say in the process; NFC Modified:

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

dawn requested changes to this revision. dawn added a reviewer: dawn. dawn added a comment. This revision now requires changes to proceed. 1. Please rebase again - this patch no longer applies cleanly, and fails to build after fixing merge conflicts. 2. Please add tests.

Re: [Lldb-commits] [lldb] r252381 - Python 3 - Don't use unbuffered I/O in text mode.

Sounds good. Not super critical, but I'd definitely rather it stay unbuffered where possible. On Mon, Nov 9, 2015 at 1:10 PM, Zachary Turner wrote: > Hmm, ok. I'll loop back around to this when I get some cycles. Still > working on Python 3 stuff so I don't think this

[Lldb-commits] [lldb] r252588 - Add support for tvos and watchos to ObjectFileMachO.

Author: jmolenda Date: Mon Nov 9 23:21:54 2015 New Revision: 252588 URL: http://llvm.org/viewvc/llvm-project?rev=252588=rev Log: Add support for tvos and watchos to ObjectFileMachO. Add support for the new dyld shared cache format on ios etc devices. Small changes for classifying ObjC metadata

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

zturner added inline comments. Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:369-374 @@ +368,8 @@ + +template +T +ResolveNameAs(llvm::StringRef name) const +{ +return ResolveName(name).AsType(); +} +}; I need

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

On Mon, Nov 9, 2015 at 5:22 PM Zachary Turner wrote: > zturner created this revision. > zturner added reviewers: granata.enrico, clayborg, tfiala. > zturner added a subscriber: lldb-commits. > > The goal here is to eventually replace some code in `python-wrapper.swig` > with

[Lldb-commits] [lldb] r252581 - The MacOSXi386 ABI should be used for watchos simulator debug sessions.

Author: jmolenda Date: Mon Nov 9 21:21:59 2015 New Revision: 252581 URL: http://llvm.org/viewvc/llvm-project?rev=252581=rev Log: The MacOSXi386 ABI should be used for watchos simulator debug sessions. Also, add an async error message if the dyld solib loaded callback function can't find an ABI

Re: [Lldb-commits] [lldb] r252583 - The other half of a change made by Enrico for trying to get a correct

This is really the kind of thing that would be good to write a unit test for. There's a lot of institutional knowledge hidden away in these kinds of deep low level stuff, and a unit test is good documentation for it. I suspect this is almost guaranteed to break at some point in the future

Re: [Lldb-commits] [PATCH] D14488: Add --curses shortcut for specifying the curses-based test results formatter.

tfiala closed this revision. tfiala added a comment. Closed by commit: Committed r252498 M packages/Python/lldbsuite/test/dosep.py M packages/Python/lldbsuite/test/dotest_args.py M packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [lldb] r252498 - Add --curses shortcut for specifying the curses-based test results formatter.

Author: tfiala Date: Mon Nov 9 12:51:04 2015 New Revision: 252498 URL: http://llvm.org/viewvc/llvm-project?rev=252498=rev Log: Add --curses shortcut for specifying the curses-based test results formatter. This commit closes the following review: http://reviews.llvm.org/D14488 Modified:

[Lldb-commits] [lldb] r252503 - Add a way for source languages to "mark" ValueObjects with language-specific flags

Author: enrico Date: Mon Nov 9 13:27:34 2015 New Revision: 252503 URL: http://llvm.org/viewvc/llvm-project?rev=252503=rev Log: Add a way for source languages to "mark" ValueObjects with language-specific flags In this way, when a language needs to tell itself things that are not bound to a

[Lldb-commits] [PATCH] D14507: Make sure we use symbol flags to detect thumbness.

sas created this revision. sas added reviewers: tberghammer, clayborg. sas added a subscriber: lldb-commits. Herald added a subscriber: rengolin. This was GetAddressClass' behavior before. This is required when debugging binaries that don't have mapping symbols ($a, $t, etc). These binaries will

Re: [Lldb-commits] [lldb] r252381 - Python 3 - Don't use unbuffered I/O in text mode.

The reason you probably want this unbuffered is for cases where you crash. When a dotest.py process crashes, the buffered content won't necessarily get flushed. So the session file may or may not contain the last thing that happened in that case. I think we want it unbuffered where we can.

[Lldb-commits] [PATCH] D14528: Allow to override python-config executable name from command line

krytarowski created this revision. krytarowski added subscribers: joerg, lldb-commits, brucem. krytarowski set the repository for this revision to rL LLVM. pkgsrc (on NetBSD) ships with python2.7-config. Repository: rL LLVM http://reviews.llvm.org/D14528 Files: Makefile lib/Makefile

[Lldb-commits] [PATCH] D14529: Use library discovery for curses and panel

krytarowski created this revision. krytarowski added subscribers: lldb-commits, joerg, brucem. krytarowski set the repository for this revision to rL LLVM. This approach is tunable with custom paths for curses library. It also detects whether there are requirements met. I make use of it on

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

granata.enrico added a comment. This seems reasonable to me. I would wait for Greg to OK it, just to be safe. http://reviews.llvm.org/D14524 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r252583 - The other half of a change made by Enrico for trying to get a correct

Author: jmolenda Date: Mon Nov 9 22:11:37 2015 New Revision: 252583 URL: http://llvm.org/viewvc/llvm-project?rev=252583=rev Log: The other half of a change made by Enrico for trying to get a correct triple for a process. He writes, "Changes to the way setting the triple works on a target so

[Lldb-commits] [lldb] r252584 - Upstream a small change from Greg Clayton for the REPL support:

Author: jmolenda Date: Mon Nov 9 22:18:12 2015 New Revision: 252584 URL: http://llvm.org/viewvc/llvm-project?rev=252584=rev Log: Upstream a small change from Greg Clayton for the REPL support: "Modify internal breakpoints so they resolve just like external breakpoints do. This allow you to set

[Lldb-commits] [lldb] r252529 - Rework the way in which ValueObjectChild decides how to update itself; this is a slight refactoring that I need as part of a larger master plan. As such, should be NFC

Author: enrico Date: Mon Nov 9 17:07:55 2015 New Revision: 252529 URL: http://llvm.org/viewvc/llvm-project?rev=252529=rev Log: Rework the way in which ValueObjectChild decides how to update itself; this is a slight refactoring that I need as part of a larger master plan. As such, should be NFC

Re: [Lldb-commits] [PATCH] D14507: Make sure we use symbol flags to detect thumbness.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. You should populate the m_address_class_map in ObjectFileELF::ParseSymbols() as this is where the m_address_class_map is already being populated. For ARM symbols, just check the

Re: [Lldb-commits] [PATCH] D14507: Make sure we use symbol flags to detect thumbness.

clayborg added a comment. See Inlined comment. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:975-997 @@ -974,5 +974,25 @@ { -// No entry in the address class map before the address. Return -// default address class for an address in a code

Re: [Lldb-commits] [PATCH] Fix for PR25300

On 3 November 2015 at 07:38, Pavel Labath wrote: > Looks good, but I'd like to avoid adding new "not remote ready" tests > to the test suite. Your test looks like it should be easy to fix -- > the only problem there is the stdout redirection. If you *don't* > redirect the

[Lldb-commits] [lldb] r252560 - Code cleanup

Author: enrico Date: Mon Nov 9 18:21:10 2015 New Revision: 252560 URL: http://llvm.org/viewvc/llvm-project?rev=252560=rev Log: Code cleanup Modified: lldb/trunk/include/lldb/Core/ValueObject.h lldb/trunk/include/lldb/Core/ValueObjectDynamicValue.h

[Lldb-commits] [lldb] r252553 - More rework of the updating logic for ValueObjectChild. Still just refactoring with no feature change

Author: enrico Date: Mon Nov 9 17:59:53 2015 New Revision: 252553 URL: http://llvm.org/viewvc/llvm-project?rev=252553=rev Log: More rework of the updating logic for ValueObjectChild. Still just refactoring with no feature change Modified: lldb/trunk/source/Core/ValueObjectChild.cpp

[Lldb-commits] [lldb] r252536 - Use PythonDataObjects in swig helper functions.

Author: zturner Date: Mon Nov 9 17:23:52 2015 New Revision: 252536 URL: http://llvm.org/viewvc/llvm-project?rev=252536=rev Log: Use PythonDataObjects in swig helper functions. Relying on manual Python C API calls is error prone, especially when trying to maintain compatibility with Python 2 and

[Lldb-commits] [PATCH] D14493: [MIPS][LLDB]Fix TestBreakpointCondition.py for MIPS

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The self.getArchitecture() returns the architecture based on the

[Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

zturner created this revision. zturner added reviewers: granata.enrico, clayborg, tfiala. zturner added a subscriber: lldb-commits. The goal here is to eventually replace some code in `python-wrapper.swig` with this code. This way it can be properly unit tested and we can easily deal with

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

zturner updated this revision to Diff 39776. zturner added a comment. Fix some indentation http://reviews.llvm.org/D14524 Files: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h