[Lldb-commits] [lldb] r259084 - Update lldb for API change in clang r259070.

2016-01-28 Thread Manman Ren via lldb-commits
Author: mren Date: Thu Jan 28 13:55:50 2016 New Revision: 259084 URL: http://llvm.org/viewvc/llvm-project?rev=259084&view=rev Log: Update lldb for API change in clang r259070. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp Modified: lldb/trunk/source/Plugins/Ex

Re: [Lldb-commits] [PATCH] D16703: Fix TestDataFormatterScript for Linux.

2016-01-28 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. That seems reasonable, yes. In general, I wish I had done this not via two strings - only one of which gets to be valid in some arbitrary order - but via either two distinct subclasses, or at least via a pair of a string and an enum class specifying the kind. Bu

[Lldb-commits] [lldb] r259153 - Fix TestDataFormatterScript for Linux.

2016-01-28 Thread Chaoren Lin via lldb-commits
Author: chaoren Date: Thu Jan 28 21:48:08 2016 New Revision: 259153 URL: http://llvm.org/viewvc/llvm-project?rev=259153&view=rev Log: Fix TestDataFormatterScript for Linux. Summary: m_function_name will contain a dummy name for the auto-generated function from the python script on Linux. Check fo

Re: [Lldb-commits] [PATCH] D16703: Fix TestDataFormatterScript for Linux.

2016-01-28 Thread Chaoren Lin via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL259153: Fix TestDataFormatterScript for Linux. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D16703?vs=46330&id=46340#toc Repository: rL LLVM http://reviews.llvm.org/D16703

[Lldb-commits] [PATCH] D16703: Fix TestDataFormatterScript for Linux.

2016-01-28 Thread Chaoren Lin via lldb-commits
chaoren created this revision. chaoren added a reviewer: granata.enrico. chaoren added a subscriber: lldb-commits. m_function_name will contain a dummy name for the auto-generated function from the python script on Linux. Check for script name first. http://reviews.llvm.org/D16703 Files: sourc

[Lldb-commits] [lldb] r259135 - Fix a bug where type list would ignore the -w argument

2016-01-28 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Jan 28 19:12:13 2016 New Revision: 259135 URL: http://llvm.org/viewvc/llvm-project?rev=259135&view=rev Log: Fix a bug where type list would ignore the -w argument rdar://24379879 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/ty

[Lldb-commits] [lldb] r259131 - Fix a bug where LLDB would not print the name of the function that a scripted summary is bound to

2016-01-28 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Jan 28 18:56:52 2016 New Revision: 259131 URL: http://llvm.org/viewvc/llvm-project?rev=259131&view=rev Log: Fix a bug where LLDB would not print the name of the function that a scripted summary is bound to rdar://24380076 Added: lldb/trunk/packages/Python/lldbsuit

[Lldb-commits] [lldb] r259114 - fix up missing header from change r259084.

2016-01-28 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Jan 28 17:17:53 2016 New Revision: 259114 URL: http://llvm.org/viewvc/llvm-project?rev=259114&view=rev Log: fix up missing header from change r259084. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp Modified: lldb/trunk/source/Plugins/Ex

[Lldb-commits] [PATCH] D16695: Update LLDB Windows buildbot to use MSVC 2015 and Python 3.5

2016-01-28 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: gkistanova. zturner added a subscriber: lldb-commits. Hi Galina, I've already got everything ready to go on the slave itself, so this CL can go in any time and it should start working. LMK if this looks ok. http://reviews.llvm.org/D16695

[Lldb-commits] [lldb] r259102 - add back an Xcode-specific Makefile for header installation

2016-01-28 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Jan 28 16:34:36 2016 New Revision: 259102 URL: http://llvm.org/viewvc/llvm-project?rev=259102&view=rev Log: add back an Xcode-specific Makefile for header installation Added: lldb/trunk/tools/install-headers/Makefile Added: lldb/trunk/tools/install-headers/Makefile U

Re: [Lldb-commits] [PATCH] D16662: [LLDB] Remove autoconf support from source directories

2016-01-28 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL259098: Remove autoconf support from source directories. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D16662?vs=46201&id=46312#toc Repository: rL LLVM http://reviews

[Lldb-commits] [lldb] r259086 - Fix build after rL259070.

2016-01-28 Thread Chaoren Lin via lldb-commits
Author: chaoren Date: Thu Jan 28 14:25:46 2016 New Revision: 259086 URL: http://llvm.org/viewvc/llvm-project?rev=259086&view=rev Log: Fix build after rL259070. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp Modified: lldb/trunk/source/Plugins/ExpressionParser/C

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-28 Thread Todd Fiala via lldb-commits
tfiala added a comment. Glad to hear it! Repository: rL LLVM http://reviews.llvm.org/D16508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-28 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thank you @clayborg and @tfiala I'm processing your feedback. In case of further questions I will let you know. Your answers make the things more clear. Repository: rL LLVM http://reviews.llvm.org/D16508 ___ lldb-co

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Todd Fiala via lldb-commits
tfiala added a comment. Sounds great, Zachary. Thanks! http://reviews.llvm.org/D16680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] LLVM buildmaster will go off-line today after 5 PM Pacific for short time

2016-01-28 Thread Galina Kistanova via lldb-commits
Hello everyone, LLVM buildmaster will be taken off-line today after 5 PM Pacific for short time for maintenance and also will be updated. Thank you for understanding. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-28 Thread Hans Wennborg via lldb-commits
hans added a comment. I've committed the patch to 3.8 in r259081. Please confirm if this fixes the issue there. http://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Zachary Turner via lldb-commits
I'm working on getting the MSVC buildbot using VS 2015, but I'll take a stab at this after it's done. Feel free to leave everything as is for now, I dont' think anyone but Windows is broken on this anyway for now. On Thu, Jan 28, 2016 at 11:21 AM Todd Fiala wrote: > tfiala added a comment. > >

[Lldb-commits] [lldb] r259078 - Fix an issue where the type list command would not accept a valid argument and instead error out complaining about a malformed regex

2016-01-28 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Jan 28 13:21:38 2016 New Revision: 259078 URL: http://llvm.org/viewvc/llvm-project?rev=259078&view=rev Log: Fix an issue where the type list command would not accept a valid argument and instead error out complaining about a malformed regex rdar://problem/24380025 Add

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Todd Fiala via lldb-commits
tfiala added a comment. That seems very reasonable. http://reviews.llvm.org/D16680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Zachary Turner via lldb-commits
I think I have a good idea how to fix this. in lldbsuite.support we can add unicode_file.py. Make it implement the file interface so that it looks just like an io object so it can be used with print(file=), and with the 'with' keyword, etc. Make the open method call io.open() with an encoding, t

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-28 Thread Keno Fischer via lldb-commits
loladiro added a comment. Sorry I've been away. No this didn't make it in before the Makefiles were removed from trunk. What would you prefer we do? http://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lis

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-28 Thread Hans Wennborg via lldb-commits
hans added a comment. loladiro: Ping? http://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-28 Thread Todd Fiala via lldb-commits
tfiala added a comment. > What's the correct approach to address it? Mirror modified > RegisterInfos_x86_64.h in RegisterContextNetBSD_x86_64.cpp and > removed/altered static_assert? I think that's worth trying. That will let you have a contiguous, consistent register set. Repository: rL

Re: [Lldb-commits] [PATCH] D16678: Fix linking of lldb-server with BUILD_SHARED_LIBS

2016-01-28 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Seems reasonable to me. http://reviews.llvm.org/D16678 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. The traceback calculation is done inside unittest2 so I think we shouldn't change it and we don't have access to the session variable either. http://reviews.llvm.org/D16680 ___ lldb-commits mailing list lldb-commits@lis

Re: [Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

2016-01-28 Thread Luke Drummond via lldb-commits
ldrumm added a comment. Hi Sean If you have the time I'd appreciate it if you could take another look over my latest iteration of this feature. Thanks Luke http://reviews.llvm.org/D15527 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-28 Thread Greg Clayton via lldb-commits
clayborg added a comment. In http://reviews.llvm.org/D16508#338046, @krytarowski wrote: > 1. I was trying to comment out `DBG` registers (as unsupported by NetBSD) > from `RegisterInfos_x86_64.h` with the following patch: > > But I get this assert being triggered: > > In file included from >

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Zachary Turner via lldb-commits
What if you try traceback.print_exception()? Does it work? Maybe it's smart enough to detect whether it needs to encode the traceback before printing. On Thu, Jan 28, 2016 at 9:13 AM Tamas Berghammer wrote: > tberghammer added a comment. > > I converted the strings it was complaining about but

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. I converted the strings it was complaining about but I haven't managed to get the traceback printing working without converting the data to utf-8 manually. We are using traceback.format_exception to collect the stack trace what returns a string, then we store it in

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. I don't think using unicode strings everywhere is a good idea because when we compare a string coming from the SB API with a string literal we don't want to do a lot of conversion. Also I think enforcing all string literals to be unicode is something what will break

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Zachary Turner via lldb-commits
zturner added a comment. On second thought I think the best solution is just to decide that we're always going to use unicode strings everywhere. That means using u"" instead of "" everywhere. It's hard to do this all over the entire codebase, but we can start with this and see what happens. Th

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Zachary Turner via lldb-commits
Python 3.4.3 (v3.4.3:9b73f1c3e601, Feb 24 2015, 22:43:06) [MSC v.1600 32 bit (Intel)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> dir(str) ['__add__', '__class__', '__contains__', '__delattr__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getat

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. I am more worried about Windows and python3 and I don't think we have any build bot running the tests on Windows. I don't really know what is the original issue this commit try to address so I plan to wait until Zachary can check it out (the current ToT works on Lin

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Hey Tamas, I haven't tried it yet, but I won't be into the office until later. Why don't you go ahead and submit it, and if it blows up the OS X testbot, you'll get an email and you (or whoe

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Todd Fiala via lldb-commits
tfiala added a comment. I can give this a try later today. http://reviews.llvm.org/D16680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r259042 - Fix const cast error for MSVC2015 build.

2016-01-28 Thread Aidan Dodds via lldb-commits
Author: aidandodds Date: Thu Jan 28 07:05:21 2016 New Revision: 259042 URL: http://llvm.org/viewvc/llvm-project?rev=259042&view=rev Log: Fix const cast error for MSVC2015 build. The Visual Studio 2015 build was failing with the following error: error C2440: 'initializing': cannot convert from 'co

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. I know that this version is not the cleanest implementation but I think this is a very robust because we don't depend on the system encoding anywhere. Please gave it a try and feel free to commit it if if works. http://reviews.llvm.org/D16680 ___

[Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-01-28 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: zturner, tfiala. tberghammer added a subscriber: lldb-commits. Re-submit rL258759: Write the session log file in UTF-8. Previously we were writing in the default encoding, which depends on the operating system and is not guaranteed t

[Lldb-commits] [PATCH] D16678: Fix linking of lldb-server with BUILD_SHARED_LIBS

2016-01-28 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: zturner, tfiala. labath added a subscriber: lldb-commits. The BUILD_SHARED_LIBS branch of lldb-server link flags was hopelessly broken, at least since we started restricting the symbols exported by liblldb. lldb-server depends on symbols from

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-28 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. Hello @ldrumm, I did investigate the issue and my finding is that incorrect values are being passed to the SetDataWithReadMemoryFallback function. Now I suspect the ElfSectionHeader is wrongly parsed in your case and the size and offsets obtained are wrong. To talk

[Lldb-commits] [lldb] r259028 - fixed Xcode gtest build failure

2016-01-28 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Jan 28 02:16:18 2016 New Revision: 259028 URL: http://llvm.org/viewvc/llvm-project?rev=259028&view=rev Log: fixed Xcode gtest build failure Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://llvm.org/v