[Lldb-commits] LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 8 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17635: Continue after process exit

jingham added a comment. I don't think you can manipulate the public run lock in PrivateResume like this. PrivateResume gets run in a bunch of places (like calling functions) that are way below the level the public run lock. You probably need to catch errors from PrivateResume in Resume and

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

Ok, so back to check_inlines. I realized after I hit send that the explanation I had written out is exactly what I thought I had to do for check_inlines == true. I guess a concrete example would make it clearer. If I have this code: // foo.cpp #include "foo.h" int main(int argc, char **argv)

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

> On Feb 26, 2016, at 3:22 PM, Zachary Turner wrote: > > > > On Fri, Feb 26, 2016 at 3:16 PM Greg Clayton wrote: > > > On Feb 26, 2016, at 2:49 PM, Zachary Turner wrote: > > > I'm coming back around to this now. What happens if

[Lldb-commits] [lldb] r262090 - Make LLDB safer to use with respect to the global destructor chain.

Author: gclayton Date: Fri Feb 26 17:20:08 2016 New Revision: 262090 URL: http://llvm.org/viewvc/llvm-project?rev=262090=rev Log: Make LLDB safer to use with respect to the global destructor chain. Modified: lldb/trunk/source/Target/Process.cpp lldb/trunk/source/Target/Target.cpp

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

On Fri, Feb 26, 2016 at 3:16 PM Greg Clayton wrote: > > > On Feb 26, 2016, at 2:49 PM, Zachary Turner wrote: > > > I'm coming back around to this now. What happens if check_inlines is > False, but the FileSpec is a header file like . You said "If >

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

> On Feb 26, 2016, at 2:49 PM, Zachary Turner wrote: > > > > On Thu, Feb 18, 2016 at 6:16 PM Greg Clayton wrote: > > > Just to make sure I understand, is it safe to say that: > > > > If check_inlines is false, sc_list should return with exactly 1 > >

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

On Thu, Feb 18, 2016 at 6:16 PM Greg Clayton wrote: > > > Just to make sure I understand, is it safe to say that: > > > > If check_inlines is false, sc_list should return with exactly 1 > SymbolContext with m_comp_unit set to the main source file? > > You would get one

Re: [Lldb-commits] [PATCH] D17658: Register value is not necessarily scalar.

This revision was automatically updated to reflect the committed changes. Closed by commit rL262081: Register value is not necessarily scalar. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D17658?vs=49237=49238#toc Repository: rL LLVM

[Lldb-commits] [lldb] r262081 - Register value is not necessarily scalar.

Author: chaoren Date: Fri Feb 26 16:12:35 2016 New Revision: 262081 URL: http://llvm.org/viewvc/llvm-project?rev=262081=rev Log: Register value is not necessarily scalar. Reviewers: aidan.dodds, mamai Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D17658 Modified:

Re: [Lldb-commits] [PATCH] D17658: Register value is not necessarily scalar.

chaoren updated this revision to Diff 49237. chaoren added a comment. Check return value of GetScalarValue directly. http://reviews.llvm.org/D17658 Files: source/Expression/Materializer.cpp Index: source/Expression/Materializer.cpp

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

Hmm. Weird. That assert is failing on Linux: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/11833 On Fri, Feb 26, 2016 at 9:40 AM, Aidan Dodds via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: aidandodds > Date: Fri Feb 26 11:40:50 2016 > New Revision:

[Lldb-commits] [lldb] r262053 - Make sure the Target, Process and Thread GetGlobalProperties() static methods are thread safe.

Author: gclayton Date: Fri Feb 26 13:38:18 2016 New Revision: 262053 URL: http://llvm.org/viewvc/llvm-project?rev=262053=rev Log: Make sure the Target, Process and Thread GetGlobalProperties() static methods are thread safe. Modified: lldb/trunk/source/Target/Process.cpp

[Lldb-commits] [lldb] r262051 - SymbolFileDWARFDebugMap::FindTypes didn't obey the max_matches flag,

Author: jingham Date: Fri Feb 26 13:33:11 2016 New Revision: 262051 URL: http://llvm.org/viewvc/llvm-project?rev=262051=rev Log: SymbolFileDWARFDebugMap::FindTypes didn't obey the max_matches flag, but kept looking through .o files even after it had found as many matches as were requested.

Re: [Lldb-commits] [PATCH] D17650: Fix TestInlines.py on Windows

zturner added inline comments. Comment at: packages/Python/lldbsuite/test/lang/cpp/inlines/inlines.h:1-4 @@ +1,4 @@ +int inner_inline (int inner_input, int mod_value); +int outer_inline (int outer_input); +int not_inlined_2 (int input); +int not_inlined_1 (int input);

Re: [Lldb-commits] [PATCH] D17650: Fix TestInlines.py on Windows

zturner added a comment. I don't know where we draw the line between `test/lang` and `test/functionalities` but I feel like the purpose of this test is just to make sure LLDB has the general ability to handle setting breakpoints on inline call sites. With that in mind, it make more sense to

[Lldb-commits] [PATCH] D17650: Fix TestInlines.py on Windows

amccarth created this revision. amccarth added reviewers: zturner, spyffe. amccarth added a subscriber: lldb-commits. The inlining semantics for C and C++ are different, which affects the test's expectation of the number of times the function should appear in the binary. In the case of this

[Lldb-commits] [lldb] r262043 - remove unused local string in IRForTarget.cpp

Author: aidandodds Date: Fri Feb 26 12:03:06 2016 New Revision: 262043 URL: http://llvm.org/viewvc/llvm-project?rev=262043=rev Log: remove unused local string in IRForTarget.cpp Committed on behalf of: ldrumm Differential revision: http://reviews.llvm.org/D16412

Re: [Lldb-commits] [PATCH] D16412: remove unused local string in IRForTarget.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL262043: remove unused local string in IRForTarget.cpp (authored by aidandodds). Changed prior to commit: http://reviews.llvm.org/D16412?vs=48006=49206#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D16412: remove unused local string in IRForTarget.cpp

ADodds added a subscriber: ADodds. ADodds accepted this revision. ADodds added a reviewer: ADodds. ADodds added a comment. This revision is now accepted and ready to land. I'm happy to commit this for you. http://reviews.llvm.org/D16412 ___

Re: [Lldb-commits] [PATCH] D17618: Improve looking up functions with equivalent mangled names.

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. Sean should be the one to OK this. http://reviews.llvm.org/D17618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D17635: Continue after process exit

jingham requested changes to this revision. jingham added a reviewer: jingham. jingham added a comment. This revision now requires changes to proceed. I agree with Zachary, it would be better to put it in PrivateResume before the call to WillResume. Having this happen in Process::PrivateResume

Re: [Lldb-commits] [PATCH] D17635: Continue after process exit

zturner added a comment. It doesn't look like `Process::PrivateResume()` returns an error if the process is alive unless `WillResume()` returns an error, which is up to the individual process implementation. So maybe the short circuit needs to happen there. This isn't really my area though

Re: [Lldb-commits] [PATCH] D17635: Continue after process exit

Honsik added a comment. I tried to put this check in PrivateResume, but its not that simple because of the public RUN lock. I am not that sure if it is safe to always unclock the lock inside PrivateResume. http://reviews.llvm.org/D17635 ___

Re: [Lldb-commits] [PATCH] D17167: Fix bug with register values byte order in expression evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rL262041: Fix bug with register values byte order in expression evaluation. (authored by aidandodds). Changed prior to commit: http://reviews.llvm.org/D17167?vs=48486=49204#toc Repository: rL LLVM

[Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

Author: aidandodds Date: Fri Feb 26 11:40:50 2016 New Revision: 262041 URL: http://llvm.org/viewvc/llvm-project?rev=262041=rev Log: Fix bug with register values byte order in expression evaluation. The evaluation of expressions containing register values was broken for targets for which

[Lldb-commits] [lldb] r262040 - The IOHandlerProcessSTDIO is the _only_ IOHandler that gets pushed and popped from functions that are run due to something that is NOT input from the user. All other IO

Author: gclayton Date: Fri Feb 26 11:36:44 2016 New Revision: 262040 URL: http://llvm.org/viewvc/llvm-project?rev=262040=rev Log: The IOHandlerProcessSTDIO is the _only_ IOHandler that gets pushed and popped from functions that are run due to something that is NOT input from the user. All other

Re: [Lldb-commits] [PATCH] D17635: Continue after process exit

jingham added a subscriber: jingham. jingham added a comment. It's okay to short-circuit this here, but why was PrivateResume not returning an error when the process was not alive. That error should have gotten propagated to the caller, obviating the need for this short-circuit.

[Lldb-commits] [lldb] r262028 - Add new java plugin files to the xcode project

Author: tberghammer Date: Fri Feb 26 09:47:35 2016 New Revision: 262028 URL: http://llvm.org/viewvc/llvm-project?rev=262028=rev Log: Add new java plugin files to the xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

Re: [Lldb-commits] [PATCH] D17167: Fix bug with register values byte order in expression evaluation

mamai added a comment. Are the changes correct? And if so, could someone commit it for me? I don't have commit access. Repository: rL LLVM http://reviews.llvm.org/D17167 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r262023 - Revert part of rL262014 as it caused issues on gcc-i386

Author: tberghammer Date: Fri Feb 26 09:33:32 2016 New Revision: 262023 URL: http://llvm.org/viewvc/llvm-project?rev=262023=rev Log: Revert part of rL262014 as it caused issues on gcc-i386 Modified: lldb/trunk/source/Expression/DWARFExpression.cpp Modified:

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

cameron314 updated this revision to Diff 49185. http://reviews.llvm.org/D17107 Files: lldb/trunk/cmake/modules/LLDBConfig.cmake lldb/trunk/include/lldb/Host/FileSystem.h lldb/trunk/include/lldb/Host/posix/HostInfoPosix.h lldb/trunk/include/lldb/Host/windows/HostInfoWindows.h

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

cameron314 added inline comments. Comment at: lldb/trunk/source/Host/common/FileSpec.cpp:242 @@ -221,1 +241,3 @@ +path.push_back(0); +path.pop_back(); } amccarth wrote: > I recognize that you're just repeating the pattern from above, but ...

[Lldb-commits] [lldb] r262021 - Add mips32 software breakpoints into platform::GetSoftwareBreakpointTrapOpcode().

Author: aidandodds Date: Fri Feb 26 09:11:01 2016 New Revision: 262021 URL: http://llvm.org/viewvc/llvm-project?rev=262021=rev Log: Add mips32 software breakpoints into platform::GetSoftwareBreakpointTrapOpcode(). The software breakpoint definitions for mips32 should have been included in my

[Lldb-commits] [lldb] r262016 - Fix address class lookup for absolute symbols

Author: tberghammer Date: Fri Feb 26 08:21:27 2016 New Revision: 262016 URL: http://llvm.org/viewvc/llvm-project?rev=262016=rev Log: Fix address class lookup for absolute symbols Modified: lldb/trunk/source/Symbol/ObjectFile.cpp Modified: lldb/trunk/source/Symbol/ObjectFile.cpp URL:

Re: [Lldb-commits] [PATCH] D17616: Add a set of new plugins to handle Java debugging

This revision was automatically updated to reflect the committed changes. tberghammer marked 2 inline comments as done. Closed by commit rL262015: Add a set of new plugins to handle Java debugging (authored by tberghammer). Changed prior to commit:

Re: [Lldb-commits] [PATCH] D17616: Add a set of new plugins to handle Java debugging

tberghammer marked 2 inline comments as done. Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:81 @@ +80,3 @@ +HardcodedFormatters::HardcodedSummaryFinder +JavaLanguage::GetHardcodedSummaries() +{ granata.enrico wrote: > Is there any reason to use

[Lldb-commits] [lldb] r262014 - Add support for DW_OP_push_object_address in dwarf expressions

Author: tberghammer Date: Fri Feb 26 08:21:10 2016 New Revision: 262014 URL: http://llvm.org/viewvc/llvm-project?rev=262014=rev Log: Add support for DW_OP_push_object_address in dwarf expressions Additionally fix the type of some dwarf expression where we had a confusion between scalar and load

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

sagar closed this revision. sagar added a comment. Committed in revision 262011. Repository: rL LLVM http://reviews.llvm.org/D17131 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r262011 - [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

Author: slthakur Date: Fri Feb 26 07:30:34 2016 New Revision: 262011 URL: http://llvm.org/viewvc/llvm-project?rev=262011=rev Log: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS Patch by Nitesh Jain. Summary: The debug version of libc.so is require for backtracing which may not be available on